This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 22610 - Highlight caret-point row should default to on
Summary: Highlight caret-point row should default to on
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: PC All
: P1 blocker (vote)
Assignee: issues@editor
URL:
Keywords:
: 56202 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-04-18 23:43 UTC by _ tboudreau
Modified: 2007-11-05 13:42 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2002-04-18 23:43:33 UTC
This is a useful feature of the editor which almost nobody 
knows about.  A couple changes would make its usefulness 
apparent:

 - Default it to on
 - Make sure the color difference with the background is 
*very* subtle so it doesn't intrude on reading code.
 - Possibly calculate the color based on the editor 
background color (if dark, HSV brightness + 10, if 
brightness > 90, HSV brightness - 10)
Comment 1 Marek Grummich 2002-07-22 12:11:45 UTC
Set target milestone to TBD
Comment 2 Marek Grummich 2002-07-22 12:16:00 UTC
Set target milestone to TBD
Comment 3 _ tboudreau 2003-12-10 21:42:35 UTC
Raising priority to P1 re the recent discussion on nbui.  We should at
least try turning it on by default in dev builds.  It will fit nicely
with the other editor enhancements.
Comment 4 _ tboudreau 2004-01-06 20:14:13 UTC
Any chance of doing this for 3.6?  It's a trivial change to implement.
Comment 5 Miloslav Metelka 2004-01-21 09:05:40 UTC
I personally agree.  What UI guys think - Gabo? Not sure whether we
can make this into 3.6 because for the default rule that you've
mentioned we will likely have to make an additional setting -
something like "Use default computation for caret line highlight" or
we need to reuse some concrete color value as a marker for the default
computation and have a special property editor. This is probably not
good in longterm as we would like to allow alpha values to be used in
the color values settings so we will in fact use all four bytes of the
color setting.
Comment 6 Gabriel Tichy 2004-01-23 14:50:43 UTC
I think "Highlight Insertion Point Row" in Fonts & Colors is rather enough for current 
design. However, I'm not sure if "Highlight Caret Row" property is needed. Do you 
think the user want to turn it on/off so often that Inherit checkbox is not appropriate?
Anyway, I agree to turn this feature on by default.
Comment 7 _ tboudreau 2004-01-23 15:04:34 UTC
Check out my Editor Themes mini-module on alpha autoupdate for a
simple approach to editor customization that is all that 99% of users
will ever want...

If only we could do that options window redesign...
Comment 8 _ tboudreau 2005-02-20 06:59:21 UTC
Hey!  This issue has been open for 3 years!  Gabo agreed over a year ago that it's the right 
thing to do.  How hard is it to change one boolean default?

Sorry to be a pain, but can we do this for 4.1?
Comment 9 Dusan Balek 2005-03-14 10:42:39 UTC
Default set to ON in [maintrunk].

Checking in ExtSettingsDefaults.java;
/cvs/editor/libsrc/org/netbeans/editor/ext/ExtSettingsDefaults.java,v  <-- 
ExtSettingsDefaults.java
new revision: 1.38; previous revision: 1.37
done
Comment 10 Miloslav Metelka 2005-03-14 13:05:34 UTC
*** Issue 56202 has been marked as a duplicate of this issue. ***
Comment 11 _ tboudreau 2005-03-14 20:01:52 UTC
Thank you, thank you, thank you!

Quick question:  If the user has an existing userdir, and they've changed some editor color, will the default 
be on, or will there be some saved "off" setting (I remember this problem with something else editor 
setting related)?
Comment 12 Dusan Balek 2005-03-15 08:59:34 UTC
The default for Highlight Caret Row should not be affected by other editor
settings (e.g. colors).