This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
When a bundle key's value is split across several lines, the ide.ergonomics will copy only the first line into its merged bundle, and because of this the next key will be missing (as it will be believed the next key is the second line of the previous' key's value). This lead to a NPE (bug #221335), and was fixed by joining the bundle lines together: http://hg.netbeans.org/main-golden/rev/6a10ecadc358 I am not very happy with that fix, for two reasons: 1. it makes the Bundles uglier, without a good reason (this is the smaller problem) 2. next time a hint will be introduced, description of which will span multiple lines, bug #221335 will re-appear without having a reasonable chance to catch this soon (I find this to be the bigger problem). I would suggest to fix the bundle merger to properly understand values spanning multiple lines.
Can you justify P2 priority? E.g. will you block the 7.3 release unless this is fixed? I certainly appreciate your time spent while debugging the foreign code in ide.ergonomics build scripts. That must have been frustrating. On the other hand I believe we have a workaround. In such case I suggest to keep the issue P4. With ergonomics we just don't have a complete flexibility. The dynamic analysis of the layers is limited in some respects. We have the verification to tell us if something goes wrong. We certainly don't want anyone else to spend time on debugging this kind of problem. We should detect it in the dynamic verification. So, if you are OK with improving the infrastructure to detect the multi-line problem, I agree this is P3 that should addressed for the benefit of NetBeans IDE developers.
(In reply to comment #1) > Can you justify P2 priority? E.g. will you block the 7.3 release unless this is The original bug was a P2 and we are at risk that this P2 will be reintroduced anytime. I must say that if I were asked to review the 6a10ecadc358 patch, I would be very reluctant to approve it. > fixed? > > I certainly appreciate your time spent while debugging the foreign code in > ide.ergonomics build scripts. That must have been frustrating. > > On the other hand I believe we have a workaround. In such case I suggest to > keep the issue P4. With ergonomics we just don't have a complete flexibility. > The dynamic analysis of the layers is limited in some respects. We have the > verification to tell us if something goes wrong. > > We certainly don't want anyone else to spend time on debugging this kind of > problem. We should detect it in the dynamic verification. So, if you are OK > with improving the infrastructure to detect the multi-line problem, I agree > this is P3 that should addressed for the benefit of NetBeans IDE developers. I fail to see the reason: my estimate is that the fix should be trivial (if the line ends with '\', include the next line?). What advantage is in creating a test that will basically do the same and will annoy developers, as opposed to simply fix the bug?
I don't have plans to fix this. The errors are detected and reported. It is easy to fix them when they occur.
(In reply to comment #1) > problem. We should detect it in the dynamic verification. ergonomics#3a762173f8eb
ergonomics#40e1fcde80af
Integrated into 'main-golden', will be available in build *201212200001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/3a762173f8eb User: Jaroslav Tulach <jtulach@netbeans.org> Log: #222483: Test to detect that all keywords are properly preserved
I noticed it's still happens in 7.3 RC build. Could you please check? http://smetiste.cz.oracle.com/builds/netbeans/7.3/daily/2013-01-11_21-00-38/zip/ In build netbeans-7.3rc1-201301112100.zip, e.g. ./org/netbeans/modules/ide/ergonomics/webcommon/Bundle.properties : ApacheConfResolver=Apache Conf Files Support for editing Apache Conf files. Templates/Other/ApacheConfTemplate.conf=Apache Conf File It looks strange.
Reopening as P1 for 7.3. The bug is blocking L10N.
What key is wrong? Can I see that in the UI?
Hi Jaroslav, For example, in org/netbeans/modules/ide/ergonomics/webcommon/Bundle.properties in build jar file in RC1 build, Support for editing Apache Conf files. line is wrong. It looks it should be OpenIDE-Module-Long-Description=\ Support for editing Apache Conf files. merged from org/netbeans/modules/languages/apacheconf/resources/Bundle.properties. Invalid .properties files can not be accepted in translation process. We need a quick fix and need to deliver files to translation vendor asap. Please evaluate.
I see, the generated Bundle contains some debris. As far as I can tell, those extra lines are harmless during runtime as they get ignored. We don't translators to waste time on debris, but it is not a blocker. I'll see what I can do with it.
ergonomics#501711eb0d34
Integrated into 'main-golden', will be available in build *201301180001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/501711eb0d34 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #222483: Exclude non-meaningful lines
Verified the fix in trunk build 201301180001. Thank you!
changeset: 6aecb04d1533 branch: release73
Integrated into 'releases', will be available in build *201301182100* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/501711eb0d34 User: Jaroslav Tulach <jtulach@netbeans.org> Log: #222483: Exclude non-meaningful lines