This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220468 - Quick search results (with long paths) are truncated
Summary: Quick search results (with long paths) are truncated
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Quick Search (show other bugs)
Version: 7.3
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Assignee: Jaroslav Havlin
URL:
Keywords:
: 153854 210672 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-10-20 09:33 UTC by schlaefer
Modified: 2013-03-11 09:24 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
truncated quicksearch results (31.73 KB, image/png)
2012-10-20 09:33 UTC, schlaefer
Details
Proposed Patch (7.70 KB, patch)
2012-10-24 09:07 UTC, Jaroslav Havlin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description schlaefer 2012-10-20 09:33:43 UTC
Created attachment 126230 [details]
truncated quicksearch results

The quick search results are truncated. See attached image for example: the beginning of the path is visible which is identical for all items. 

Possible solutions:

a) autoresize the result popup
b) allow user to manually resize result popup and save size
c) omit the base path to project folder
d) truncate in the middle and not at the end
Comment 1 Jaroslav Havlin 2012-10-22 12:37:11 UTC
The name is set by search provider GoToSymbolProvider in module jumpto.
Reassigning. Please evaluate the solutions. Thank you.
Comment 2 Tomas Zezula 2012-10-22 15:06:55 UTC
The GoToSymbolProvider shows the information got from SymbolDescription, for Java it's a class FQN in fact the c) variant.
For PHP it's absolute path which is too long. The path relative to project root (similar to the class FQN in java) seems to me better. Consider to add the a) or b) or reassign to PHP. I personally vote for b) as even the relative name may be large.

Current workaround is to use Go To Symbol which provides the same information with better UI and performance.
Comment 3 Tomas Zezula 2012-10-22 15:07:26 UTC
Adding Ondra for PHP part.
Comment 4 Ondrej Brejla 2012-10-22 15:22:43 UTC
Personally I'm for b) too (because of possible large names), but I can look at PHP implementation as well. But not sure if that "extra long" path isn't caused by CSL abstraction since we use IndexSearcher.Description. Will look at it...
Comment 5 Ondrej Brejla 2012-10-22 15:25:18 UTC
IndexSearcher.Descriptor of course ;)

Just another quick look into PHP module and I think that I can do something with it. Note4Me: PHPTypeSearcher.getContextName:297
Comment 6 Jaroslav Havlin 2012-10-22 15:26:57 UTC
OK, I'll try to implement solution b). Thank you for your comments.
Comment 7 Jaroslav Havlin 2012-10-24 09:07:53 UTC
Created attachment 126438 [details]
Proposed Patch

Patch that makes the QuickSearch pop-up resizable.

I'm considering changing the issue type to Defect and applying the patch so that it gets into 7.3. What do you think?
Comment 8 Jaroslav Havlin 2012-10-26 08:51:41 UTC
> Created attachment 126438 [details]
> Proposed Patch
> 
> Patch that makes the QuickSearch pop-up resizable.
Added upper limit for the pop-up width and integrated as
http://hg.netbeans.org/core-main/rev/d75499c2e35e

Thank you for your help.
Comment 9 Quality Engineering 2012-10-27 01:32:54 UTC
Integrated into 'main-golden', will be available in build *201210270001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/d75499c2e35e
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #220468: Quick search results (with long paths) are truncated
Comment 10 Jaroslav Havlin 2012-12-19 09:39:59 UTC
*** Bug 210672 has been marked as a duplicate of this bug. ***
Comment 11 Jaroslav Havlin 2012-12-19 15:08:47 UTC
*** Bug 153854 has been marked as a duplicate of this bug. ***
Comment 12 Ondrej Brejla 2012-12-21 10:05:46 UTC
*** Bug 224107 has been marked as a duplicate of this bug. ***
Comment 13 Ondrej Brejla 2012-12-21 10:13:07 UTC
Jardo is it possible to autoresize that result window if longer items, then current window width, come? Because if I use it for the first time, longer items are being shown, but are not visible, because that window doesn't autoresize.
Comment 14 Jaroslav Havlin 2013-01-07 15:07:03 UTC
> Jardo is it possible to autoresize that result window...
It should be possible. It's probably too late to fix it in 7.3, so I'd rather fix it in the next version. Would it be OK?
Comment 15 Ondrej Brejla 2013-01-07 15:09:08 UTC
Definitely yes :)
Comment 16 Jaroslav Havlin 2013-03-07 16:31:51 UTC
(In reply to comment #13)
> Jardo is it possible to autoresize that result window if longer items, then
> current window width, come? Because if I use it for the first time, longer
> items are being shown, but are not visible, because that window doesn't
> autoresize.
Fixed in http://hg.netbeans.org/core-main/rev/c1fa3fa1d5e1
The quick search is autoresized only if its width hasn't been set manually.
Please check if this behavior is fine. Thank you.
Comment 17 Quality Engineering 2013-03-08 02:02:31 UTC
Integrated into 'main-golden', will be available in build *201303072300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c1fa3fa1d5e1
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #220468: Autoresize QuickSearch pop-up;
Comment 18 Ondrej Brejla 2013-03-11 09:24:07 UTC
Seems to be quite ok for me :)