This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 219098 - Add warning message about Chrome debugging
Summary: Add warning message about Chrome debugging
Status: VERIFIED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Extbrowser (show other bugs)
Version: 7.3
Hardware: All All
: P1 normal (vote)
Assignee: Denis Anisimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 05:20 UTC by Tomas Mysik
Modified: 2012-10-01 12:06 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screen shot (105.02 KB, image/png)
2012-09-27 13:42 UTC, Tomas Mysik
Details
screenshot from GTK (21.23 KB, image/png)
2012-09-27 14:20 UTC, Vladimir Riha
Details
new warning dialog (20.24 KB, image/png)
2012-09-28 09:49 UTC, Vladimir Riha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2012-09-27 05:20:49 UTC
When one is going to install NetBeans Chrome plugin, NetBeans informs him via a small dialog what to do. Please, add a warning (with bold text I assume) to this dialog that user cannot close the "plugin is debugging this tab" infobar otherwise the NetBeans Chrome integration will not work at all.

Thanks.
Comment 1 Denis Anisimov 2012-09-27 07:58:32 UTC
Could you please clarify the behavior ?
I don't see how debugging relates to the chrome plugin installation.
That's two different actions.
Plugin is used not just for debugging but it also provides other functionality.
Does infobar closing block any functionality provided by plugin ?
Because otherwise it seems the wrong area is chosen for the issue.
Comment 2 Tomas Mysik 2012-09-27 08:07:36 UTC
(In reply to comment #1)
> I don't see how debugging relates to the chrome plugin installation.
> That's two different actions.

I don't think so. The problem is that if one closes the "plugin is debugging this tab" infobar (no matter if one clicks the Cancel or the "X" button), the NetBeans features like "Selection Mode", "Refresh on Save" or "Change Window Size" (and perhaps some more) will stop working.

> Plugin is used not just for debugging but it also provides other functionality.

This other functionality often relies on the debugger API.

> Does infobar closing block any functionality provided by plugin ?

Sure. If you close it, perhaps the whole integration simply does not work.

> Because otherwise it seems the wrong area is chosen for the issue.

This was discussed recenly on the Easel meeting in Prague (AFAIR you were on the phone). This is the best (and perhaps the only possible way) where to inform user _just once_ - right during the installation.

Thanks.
Comment 3 Tomas Mysik 2012-09-27 09:05:27 UTC
BTW corresponding Chrome issue is here [1].

[1] http://code.google.com/p/chromium/issues/detail?id=138258
Comment 4 Denis Anisimov 2012-09-27 09:18:42 UTC
>This was discussed recenly on the Easel meeting in Prague (AFAIR you were on
>the phone). 
I wasn't.

No problem then to add warning.
But from my personal point of view it is not so useful to show this message 
on the install plugin stage. As a user I would just pay attention on plugin 
installation message and ignore any additional not related to the installation 
text in the message. No matter how it is marked out ( like bold ).
Message should be contextual. And installation stage is not a context for 
mentioned infobar.
That's of course just my personal opinion.
Comment 5 Tomas Mysik 2012-09-27 09:41:30 UTC
(In reply to comment #4)
> I wasn't.

Sorry :)

> No problem then to add warning.
> But from my personal point of view it is not so useful to show this message 
> on the install plugin stage. As a user I would just pay attention on plugin 
> installation message and ignore any additional not related to the installation 
> text in the message. No matter how it is marked out ( like bold ).
> Message should be contextual. And installation stage is not a context for 
> mentioned infobar.
> That's of course just my personal opinion.

Well, the problem is not to bother user so often, ideally warn user just once; therefore we have agreed that this message should be in the installation dialog.

In any case, I guess it can be easily changed for FCS if there is a better place for this warning available.
Comment 6 Denis Anisimov 2012-09-27 12:53:34 UTC
web-main#8a59158e062c
Comment 7 Tomas Mysik 2012-09-27 13:32:18 UTC
I guess this is a Beta stopper - Petře, can you confirm?
Comment 8 Petr Jiricka 2012-09-27 13:34:14 UTC
Not really, but I understand this is a safe fix.
Comment 9 Tomas Mysik 2012-09-27 13:42:20 UTC
Sorry, have to reopen since the text is not correctly visible (it is scrolled).

Attaching screenshot...
Comment 10 Tomas Mysik 2012-09-27 13:42:52 UTC
Created attachment 125005 [details]
screen shot
Comment 11 Petr Jiricka 2012-09-27 13:44:18 UTC
Cc Marian. I don't think this is a stopper for beta if we don't have a 100% correct and safe fix.
Comment 12 Tomas Mysik 2012-09-27 13:48:51 UTC
My understanding was that _noone_ can easily guess that closing the infobar will _silently_ break the NetBeans integration at all. BTW this is clearly visible in the results of the UI study. This is the reason why I filed it as P1 and marked it as a Beta stopper - but of course, the final decision is on QA.

Thanks.
Comment 13 Marian Mirilovic 2012-09-27 13:50:21 UTC
> My understanding was that _noone_ can easily guess that closing the infobar
> will _silently_ break the NetBeans integration at all. BTW this is clearly
> visible in the results of the UI study. This is the reason why I filed it as P1
> and marked it as a Beta stopper - but of course, the final decision is on QA.


Agreed, fix it if you can please.
Comment 14 Denis Anisimov 2012-09-27 13:51:35 UTC
(In reply to comment #9)
> Sorry, have to reopen since the text is not correctly visible (it is scrolled).
> 
> Attaching screenshot...

Sorry, I don't understand why the scrolling is the problem ?
Comment 15 Vladimir Riha 2012-09-27 13:52:51 UTC
wouldn't be better if the warning text contains "NetBeans IDE Support Plugin is debugging this tab" since it is what it really says?
Comment 16 Tomas Mysik 2012-09-27 13:56:23 UTC
(In reply to comment #14)
> Sorry, I don't understand why the scrolling is the problem ?

The screenshot is taken right after I clicked the Run button - I did not scroll the text myself. Shouldn't I see the text from its beginning?
Comment 17 Vladimir Riha 2012-09-27 14:20:24 UTC
Created attachment 125008 [details]
screenshot from GTK

I can confirm the same behavior on GTK+Ubuntu, also there is no new line ("empty line") between black and red font. It could be GTK-only issue...
Comment 18 Denis Anisimov 2012-09-28 06:35:05 UTC
web-main#423dff188349
Comment 19 Vladimir Riha 2012-09-28 09:49:45 UTC
Created attachment 125061 [details]
new warning dialog

Thanks, it seems fine for me. Please integrate it to Beta

Product Version: NetBeans IDE Dev (Build web-main-8699-on-20120928)
Java: 1.7.0; Java HotSpot(TM) 64-Bit Server VM 21.0-b17
System: Linux version 3.5.0-4-generic running on amd64; UTF-8; en_US (nb)
Comment 21 Quality Engineering 2012-10-01 04:20:34 UTC
Integrated into 'releases', will be available in build *201210010205* or newer. Wait for official and publicly available build.
Changeset: http://hg.netbeans.org/releases/rev/ff168166a225
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#219098 - Add warning message about Chrome debugging
Comment 22 Denis Anisimov 2012-10-01 06:50:02 UTC
(In reply to comment #20)
> Transplanted to beta: 
> http://hg.netbeans.org/releases/rev/ff168166a225
> http://hg.netbeans.org/releases/rev/b83bce2cceb6

Thanks a lot Petr.
It takes a time to work with several branches via HG.
Comment 23 Vladimir Riha 2012-10-01 07:48:14 UTC
verified in beta

Product Version: NetBeans IDE 7.3 Beta (Build 201210010205)
Java: 1.7.0_07; Java HotSpot(TM) Client VM 23.3-b01
System: Linux version 3.2.0-31-generic-pae running on i386; UTF-8; en_US (nb)
Comment 24 Quality Engineering 2012-10-01 12:06:53 UTC
Integrated into 'main-golden', will be available in build *201210010929* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/8a59158e062c
User: Denis Anisimov <ads@netbeans.org>
Log: Fix for BZ#219098 - Add warning message about Chrome debugging