This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 212333 - JSch upgrade
Summary: JSch upgrade
Status: RESOLVED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: libs (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Vladimir Kvashin
URL:
Keywords:
Depends on:
Blocks: 241365
  Show dependency tree
 
Reported: 2012-05-10 17:19 UTC by Jesse Glick
Modified: 2015-02-11 03:34 UTC (History)
8 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2012-05-10 17:19:16 UTC
Do we want to upgrade JSch? Orbit is now publishing 0.1.46, which I hope would be compatible with Mylyn, and may have some fixes useful for CND as well. 0.1.48 is available from the source, but not (yet?) on Orbit.

I have tried to make sure the Orbit bundle has all the necessary OSGi headers (e.g. bug #208616), so we may be able to reuse the Eclipse JAR without patching the manifest. Beware that they use Import-Package, not Require-Bundle, for jzlib; not sure if this impacts our AU catalog generation.
Comment 1 Tomas Stupka 2012-05-10 18:53:50 UTC
(In reply to comment #0)
> Do we want to upgrade JSch? Orbit is now publishing 0.1.46, which I hope would
> be compatible with Mylyn, and may have some fixes useful for CND as well.
> 0.1.48 is available from the source, but not (yet?) on Orbit.
no plans because of mylyn. afaik mylyn doesn't use jsch, but checked only in updates.xml, which is entirely based on Require-Bundle. 

jgit uses jsch - ondra on cc 

beyond cnd - is there any other motivation for an update?

> I have tried to make sure the Orbit bundle has all the necessary OSGi headers
> (e.g. bug #208616), so we may be able to reuse the Eclipse JAR without patching
> the manifest. Beware that they use Import-Package, not Require-Bundle, for
> jzlib; not sure if this impacts our AU catalog generation.
o.n.nbbuild.MakeUpdateDesc.fakeOSGiInfoXml() doesn't do anything about Import-Package, so guess that would cause the same problem as in issue #201612
Comment 2 Ondrej Vrabec 2014-02-04 08:00:50 UTC
JGit (v. 3.3.0) will depend on JSCh 0.1.50, we will have to upgrade JSCh in NetBeans before upgrading JGit. Has several new features and two bugfixes. I do not expect any regressions in our code but adding clients of JSCh on CC. Along with it we should also upgrade jsch-agent-proxy

http://www.jcraft.com/jsch/ChangeLog
https://github.com/ymnk/jsch-agent-proxy
Comment 3 Vladimir Kvashin 2015-01-23 12:13:24 UTC
So it seems we agreed on the upgrade jsch to 1.50, right?
Comment 4 Ondrej Vrabec 2015-01-23 12:16:57 UTC
there's already a jsch-0.1.51. But for JGit no upgrade was necessary after all, so i do not have a reason to upgrade it. Do you need any newer version?
Comment 5 Vladimir Kvashin 2015-02-03 11:12:46 UTC
Yes, I meant 0.1.51, sorry for misspelling.

Yes, we'd like to upgrade: we don't need new features, but there are many fixes in 0.1.51.

I can easily do the upgrade if nobody minds.
Comment 6 Ondrej Vrabec 2015-02-03 11:24:15 UTC
vladimir, please upgrade the JSch lib.
Thanks
Comment 7 Vladimir Kvashin 2015-02-04 11:06:29 UTC
Upgraded to 0.1.51
http://hg.netbeans.org/cnd-main/rev/11ff3b44bdf4
Comment 8 Vladimir Kvashin 2015-02-10 08:07:14 UTC
additional fix:
hg.netbeans.org/cnd-main/rev/dd4ae5ae7773
Comment 9 Quality Engineering 2015-02-11 03:34:05 UTC
Integrated into 'main-silver', will be available in build *201502110001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/dd4ae5ae7773
User: Vladimir Kvashin <vkvashin@netbeans.org>
Log: addfix for #212333 - JSch upgrade