This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 211763 - Tools->Variables confuses C/C++ users
Summary: Tools->Variables confuses C/C++ users
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant Project (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Jesse Glick
URL:
Keywords: UI
Depends on: 213857
Blocks: 196002
  Show dependency tree
 
Reported: 2012-04-26 08:24 UTC by Alexander Simon
Modified: 2012-07-09 14:48 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Simon 2012-04-26 08:24:35 UTC
"Manage Variables" dialog is project type (language) specific dialog.
It should be moved in project type specific options or have project type (language) combo box.
Comment 1 igor_nikiforov 2012-04-26 09:15:52 UTC
Another alike problem is with Tools -> Libraries dialog. It is available in the CND, but not usable as it is not possible to add some library. Only remove button is enabled. It also should be moved to some other place.
Comment 2 Jesse Glick 2012-04-26 15:30:33 UTC
Both dialogs are also useless for Maven projects, thus specific to Ant-based project types, not Java projects as such. Of course various other dialogs opened from the Tools menu are specific to certain project types. If you do not want Tools > Libraries and Tools > Variables to appear, exclude project.ant and project.libraries from your build.

Up to UI folks what to do with this. Could label the dialogs and/or menu items something like "Ant Libraries" resp. "Ant Variables". Or disable the menu items when no Ant-based project is open. (A bit tricky in the case of Libraries since there is no API for indicating whether a project might use this module or not.)
Comment 3 Vladimir Voskresensky 2012-04-26 16:00:06 UTC
(In reply to comment #2)
> Both dialogs are also useless for Maven projects, thus specific to Ant-based
> project types, not Java projects as such. Of course various other dialogs
> opened from the Tools menu are specific to certain project types. If you do not
> want Tools > Libraries and Tools > Variables to appear, exclude project.ant and
> project.libraries from your build.
> 
> Up to UI folks what to do with this. Could label the dialogs and/or menu items
> something like "Ant Libraries" resp. "Ant Variables". 
Agree with this
> Or disable the menu items when no Ant-based project is open. (A bit tricky in the case of Libraries since
> there is no API for indicating whether a project might use this module or not.)
Only disabling is not enough, because it will be activated when at least one Ant-based project is opened, but it is still not applicable to all other opened projects, so better name + disabling is the most preferable. 
While better name is also enough.
Comment 4 Petr Somol 2012-05-11 13:21:32 UTC
for the time being I endorse the idea to label the dialogs and menu items
"Ant Libraries" resp. "Ant Variables". IMHO we can afford to do this even now after feature freeze, as it does not actually change the UI structure nor logic and it should cause no confusion as the new names do contain the old names. More detailed changes in Tools menu can be considered after 7.2..
Comment 5 Jesse Glick 2012-05-11 21:22:47 UTC
core-main #bae64ac16e12
Comment 6 Quality Engineering 2012-05-12 09:56:14 UTC
Integrated into 'main-golden', will be available in build *201205120400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/bae64ac16e12
User: Jesse Glick <jglick@netbeans.org>
Log: #211763: Tools->Variables confuses C/C++ users
Comment 7 Quality Engineering 2012-06-01 05:27:24 UTC
Integrated into 'main-golden', will be available in build *201206010001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/0e073fa82d60
User: Jesse Glick <jglick@netbeans.org>
Log: #211763 (label change) follow-up.
Comment 8 David Konecny 2012-07-04 21:45:15 UTC
Rename of Variables to Ant Variables makes sense because the only purpose of that dialog is to set Ant properties.

But Libraries case is very different and I think it does not make any sense to label generic libraries support as "Ant Libraries". For NetBeans 7.3 we are working on improving JavaScript support and I used Libraries SPI/API to manage JavaScript libraries. Similarly C/C++ team could use them to model C/C++ libraries as Libraries SPI/API is fairly generic. In that light I think this change was premature. Libraries menu item was in place since NetBeans 4.0 and I doubt there was much confusion about it - opening a dialog you get list of libraries grouped by their type, eg. "Class Libraries", "Server Libraries", etc. If we decide to go ahead with JavaScript Libraries for 7.3 there will be a new group called "JavaScript Libraries" and I will have to file P2 issues to revert the name back to "Libraries".

If it is not too late I would suggest to revert this change (I mean "Ant Libraries" part) for 7.2. This is P3 after all.

What others think about this?
Comment 9 homberghp 2012-07-05 05:58:02 UTC
The concept 'Libraries' is generic enough. For Java folks these are jars,
for C/C++ people libXXX.a , libXXX.so  or XXX.dll, dependent on what church you are praying in. Also maven people will grasp the concept. So I would stick with the "Tools->Libraries" name and evolve libraries for different languages (as suggested for 7.3/javascript libraries). That the libraries are for ant are implemented as "ant variables" in only a smart but otherwise implementation detail. They help my students a lot when working on a project with mixed development machines. Agree on the name and windows aficionados, mac lovers and Linux guys can peacefully cooperate on projects.

It will also not break compatibility with any documentation, books, university course materials (which it would in my case).
Comment 10 Tomas Zezula 2012-07-09 14:48:38 UTC
>and I will have to file P2 issues to revert the name back to "Libraries".
David, if you want me to change it back to "Libraries" you need to make it P1.
Otherwise QE does not allow me to integrate it into NB 7.2.
Thanks