This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 197659 - do not parse file in EDT during each enter key press
Summary: do not parse file in EDT during each enter key press
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Editor (show other bugs)
Version: 7.0.1
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-12 12:07 UTC by Marek Fukala
Modified: 2011-04-13 08:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Fukala 2011-04-12 12:07:45 UTC 
Found when profiling indentation of the big html file attached to the Bug 197458 - evaluate bottlenecks when opening large files

After each enter key press the whole file is parsed in EDT:

 "AWT-EventQueue-1" - Thread t@31
    java.lang.Thread.State: RUNNABLE
	at java.lang.String.intern(Native Method)
	at org.netbeans.editor.ext.html.parser.SyntaxAnalyzer.tag(SyntaxAnalyzer.java:176)
	at org.netbeans.editor.ext.html.parser.SyntaxAnalyzer.tag(SyntaxAnalyzer.java:149)
	at org.netbeans.editor.ext.html.parser.SyntaxAnalyzer.parseDocument(SyntaxAnalyzer.java:363)
	at org.netbeans.editor.ext.html.parser.SyntaxAnalyzer.elements(SyntaxAnalyzer.java:103)
	at org.netbeans.editor.ext.html.parser.api.SyntaxAnalyzerResult.getElements(SyntaxAnalyzerResult.java:103)
	at org.netbeans.editor.ext.html.parser.api.SyntaxAnalyzerResult.getDoctypeDeclaration(SyntaxAnalyzerResult.java:453)
	at org.netbeans.editor.ext.html.parser.api.SyntaxAnalyzerResult.detectHtmlVersion(SyntaxAnalyzerResult.java:142)
	at org.netbeans.editor.ext.html.parser.api.SyntaxAnalyzerResult.getDetectedHtmlVersion(SyntaxAnalyzerResult.java:130)
	at org.netbeans.editor.ext.html.parser.api.SyntaxAnalyzerResult.getHtmlVersion(SyntaxAnalyzerResult.java:107)
	at org.netbeans.editor.ext.html.parser.api.SyntaxAnalyzerResult.findParser(SyntaxAnalyzerResult.java:173)
	at org.netbeans.editor.ext.html.parser.api.SyntaxAnalyzerResult.getHtmlModel(SyntaxAnalyzerResult.java:117)
	at org.netbeans.modules.html.editor.indent.HtmlIndenter.<init>(HtmlIndenter.java:77)
	at org.netbeans.modules.html.editor.indent.HtmlIndentTask.<init>(HtmlIndentTask.java:65)
	at org.netbeans.modules.html.editor.indent.HtmlIndentTaskFactory.createTask(HtmlIndentTaskFactory.java:57)
Comment 1 Marek Fukala 2011-04-12 16:41:38 UTC 
fixed in web-main#c30be3cbbc60 by adding a parser iterator so one may stop using the iterator and hence parsing the file if the searched element has been found.
Comment 2 Quality Engineering 2011-04-13 08:41:46 UTC 
Integrated into 'main-golden', will be available in build *201104130401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/c30be3cbbc60
User: Marek Fukala <mfukala@netbeans.org>
Log: #197659 - do not parse file in EDT during each enter key press