This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 17101 - CVSROOT can include server port to connect to (since cvs 1.11)
Summary: CVSROOT can include server port to connect to (since cvs 1.11)
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscore (show other bugs)
Version: 3.x
Hardware: PC Linux
: P1 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
: 16483 (view as bug list)
Depends on:
Blocks: 21336 26105
  Show dependency tree
 
Reported: 2001-10-29 17:00 UTC by dmladek
Modified: 2002-07-29 21:51 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dmladek 2001-10-29 17:00:58 UTC
THIS ISN'T DUPLICATE OF THE ISSUE #13901 !!!!
IT IS NECESSEARY TO HAVE AN EXTRA BUG FOR THIS MODULE AS FOR VCSGENERIC AND JAVACVS.

IT IS NECESSEARY TO INCLUDE ITS IMPLEMENTATION INTO THE RELEASE OF NB3.3 'CAUSE
JAVACVS HAS ALREADY IMPLEMENTED THIS AND THEN IT WILL BE FOR ANOTHER CVS MODULES
MOUNT CVS FS WHICH USE DIFERENT PORT BECAUSE OF DIFERENT CVSROOT STRING.
--------------------------------------------------------------------------------

We should support the new form of te CVSROOT variable (string) that enables to
specify the port of the cvs server as well.

Example:
pserver:mkleint@localhost:3210:/cvs


This means changes in library and the filesystem as well.
--------------------------------------------------------------------------------

FOR MORE DETAILS SEE THE ORIGINAL ISSUE #13901
Comment 1 Milos Kleint 2001-10-29 21:28:30 UTC
can you tell me why it's so IMPORTANT? and why you use the upper case
letters all the time? do you think it gives your bug more validity? :)
.. and BTW what do you actually propose? to incluse the port in the
wizard?
Comment 2 Milos Kleint 2001-10-30 13:27:48 UTC
see #16483 for details discussion..
Comment 3 Milos Kleint 2001-10-30 13:44:18 UTC
*** Issue 16483 has been marked as a duplicate of this issue. ***
Comment 4 dmladek 2001-10-30 14:23:56 UTC
CC'ing Lloyd, the original submiter of that issue
Comment 5 Martin Entlicher 2001-10-30 19:45:27 UTC
O.K., so any suggestion of what to do with this in 3.3? It's too late
to include the port number in the wizard (and we're not sure whether
we really want to do this).
So we can:
1) either leave the wizard as it is (this means, that when the CVSROOT
will contain the port, the wizard will not parse it correctly and it
will not fill the connection settings (probably - I didn't try))
2) or parse the port number, but do not set it to the mounted
filesystem (the other settings will be set correctly)

- in these two cases the user will not be able to successfully login
from the wizard and will have to probably set the offline mode to
proceed. Then the user will have to go to the FS customizer (or
proerties), set the port and turn off the offline mode.

3) or parse the port number, and pass it to the mounted filesystem if
the user will not change the settings. It's probably too tricky, but
in case, that the user will not modify the settings (I believe that in
most cases one should not have a reason to do that) everything will
work right. If the user will do some modification the further behavior
will fall under 2).

4) add the port number to the CVS mount wizard next to the "Password
Server" check box (UI team would have to be asked for confirmation).
It could be pre-filled with the default port number and a tooltip like
"Do not change this if you do not know what you're doing" can be
added. - It's more work, the wizard gets more complex, but the
functionality will be fulfilled.

Any comments/other opinions? Should we consider changes like 3) or 4)
to 3.3 or wait for better ideas to 3.4 (or 4.0)?
Comment 6 dmladek 2001-10-31 08:31:09 UTC
Well,

everything depends on a time;-) What time we're planing the release of
3.3? Within 1 month? And how many days will you spend on it? 2 or 3?
Remember that always you need to make changes in the FS customizer...
Then rather I'd say NO. But we'll need to discuse it more.

Comment 7 Martin Entlicher 2001-10-31 13:00:32 UTC
Yes, the time is also an issue here. We're approaching to FCS and we
have to be really careful about any change. I just want to collect the
possibilities first and what would be necessary to do for each one.
Then we'll decide with respect to the time we have.
Comment 8 Martin Entlicher 2001-11-01 14:10:26 UTC
O.K., so we agreed not to do the changes into the current CVS mount
wizard. You can always login via the CVS Password Manager and both
JavaCVS and Generic VCS have support for different mount points
although CVS part of Generic VCS can not parse the CVSROOT with the
port number.
Deferred for next version 3.4.
Comment 9 Martin Entlicher 2002-03-08 09:52:37 UTC
Increased priority - defining feature for NB 3.4
Comment 10 Martin Entlicher 2002-04-05 16:43:04 UTC
Reassigning...
Comment 11 Martin Entlicher 2002-04-09 12:13:14 UTC
The port number was added to the joined CVS mount wizard.
Comment 12 Jiri Kovalsky 2002-04-23 09:57:43 UTC
Works fine in development build #200204230100 of NetBeans 3.4 with CVS
1.11p1 however does not work with CVS 1.11 and older. On the other
hand there is a regression in CVS 1.11p1 that it does not accept
Windows CVS servers with repository like C:\cvs\repository. I think
both these items should be mentioned in next Release Notes. Therefore
added RELNOTE keyword so that doc guys don't forget about it.
Comment 13 Patrick Keegan 2002-07-23 15:57:15 UTC
Jirka, I'm not clear whether this needs to be release noted for 3.4 or 
not and exactly which information would be applicable.
Comment 14 Jiri Kovalsky 2002-07-23 16:39:35 UTC
Patrick, I would document it in supported VCS tools section. Let's
inform users that in order to connect to CVS server running on
non-default port, they must have 1.11.p1 version of CVS client or
higher. In such case they can use the feature fixed by this issue.
As for the second matter, I don't expect that too many users will run
their CVS server on Windows. If so, they must resolve problems with
bad CVSROOT themselves.
Don't hesitate to ask further, if you need.
Comment 15 Patrick Keegan 2002-07-29 21:51:42 UTC
removing relnote keyword