This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 156396 - need to delegate (or stop proxying) project types that are enabled
Summary: need to delegate (or stop proxying) project types that are enabled
Status: RESOLVED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Features On Demand (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on: 154427
Blocks:
  Show dependency tree
 
Reported: 2009-01-07 07:03 UTC by Milos Kleint
Modified: 2009-06-21 13:43 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Milos Kleint 2009-01-07 07:03:17 UTC
the simplified  project folder recognition introduced by ergonomics seems to persist even when the project type in
question is already enabled. that is causing problems in UI.

steps to reproduce:
1. svn checkout http://svn.codehaus.org/mojo/trunk/mojo/mojo-archetypes/
2. open webapp-jee5/ folder as a maven project.
3. ERROR: expand Other Sources node, it has one subnode, expand it and you will see just the META-INF.maven package.
if you do the same with ergonomics purged (deleted cluster) and clean userdir, there are more packages shown.
Comment 1 Jaroslav Tulach 2009-01-07 15:46:34 UTC
I guess this is related to issue 154427: shall we improve proxying or replace the project in OpenProjects list?
Comment 2 Milos Kleint 2009-01-07 18:16:24 UTC
no, IMHO this is about the ergonomics isProject()/loadProject() method not being completely equal to barebone maven
project factory. If maven projects are enabled, the ergonomics factory shall either completely ignore the maven project
resolution or shall completely delegate to the maven factory. It's not about project instances, if these are created
it's already too late.
Comment 3 Jaroslav Tulach 2009-01-09 14:16:54 UTC
Reproduced. If I just open the project in ergonomics IDE, it contains just META-INF.maven. If I shutdown and restart, 
the project still contains just META-INF.maven. If I fully enable Web&J2EE category and restart the project contains 
more packages.

As such it is imho an example of issue 156338 - e.g. maven project that does not enable j2ee functionality. However 
just fixing issue 156338 is unlikely to be enough, the pom.xml contains "<packaging>jar</packaging>" and as such, j2ee 
would not be enabled either, even after fixing 156338.
Comment 4 Milos Kleint 2009-01-09 14:47:16 UTC
not sure if your evaluation is correct. The packages are missing because there is a pom.xml file at the resources and it
is falsely identified by ergonomics as a project, therefore the SourceGroup.contains() method will not include the
folders within and will skip them. The solution is to make sure the pom.xml in resources is not recognized as project.
Comment 5 Jaroslav Tulach 2009-01-09 16:28:06 UTC
I see. Thanks for explanation.
Comment 6 Jaroslav Tulach 2009-01-09 17:21:01 UTC
ergonomics#be75578d0634
Comment 7 Quality Engineering 2009-01-11 17:03:43 UTC
Integrated into 'main-golden', will be available in build *200901111401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/be75578d0634
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #156396: Provide recognition only for disabled feature infos