This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
the current implementation of toolbars is hard to maintain (see #59242). i want to rewrite the implementation with the following major changes: - all look & feel specific code will move from openide.loaders module to core.windows - toolbar drag and drop implementation will move from openide.loaders module to core.windows the following API changes will be made: - deprecation of toolbar dnd interfaces and methods (see attached toolbar.diff) - deprecation of some methods in ToolbarPool that were needed by toolbar layout management (see attached toolbarpoo.diff) - new version of DTD for toolbar configuration (see attachment)
Created attachment 74118 [details] changes in org.openide.awt.Toolbar
Created attachment 74119 [details] changes in org.openide.awt.ToolbarPool
Created attachment 74120 [details] new version of toolbar configuration DTD
VS1: (This more a question than apireview) Is it possible to reuse all this for editor toolbar? How? Basically, the editor somehow knows the actions that it wants to put on the toolbar and the question is how it could create a toolbar implemented in openide/core? Currently we have our own toolbar and I suspect it was somehow copied from core with all the L&F tricks, etc. Thanks
VS1: do you really need in editor toolbar the extra functionality from the main window toolbar (multiple toolbar rows, customization of toolbar buttons, toolbar repositioning etc). afaik, editor toolbar is a plain toolbar with fixed set of buttons that cannot be customized. and in this case the default swing JToolbar should work perfectly
VS1: Not all of the extra functionality, but some features would be useful. Eg. buttons customization, multiple toolbars in a single row, maybe more...
well, the new toolbar implementation will be usable with implementation dependency on core.windows only. and even that will be difficult as the main and editor toolbars have different action pools (i think)
Customer in Germany has requested: -- the toolbar should be drag/droppable to all sides of the IDE
-- and the size of the icons in the toolbar should be customizable (not just 16x16 and 32x32)
PS: The above are about the whole toolbar area, not specific toolbars within it.
Added me to the CC.
> -- the toolbar should be drag/droppable to all sides of the IDE not in the plan at the moment > -- and the size of the icons in the toolbar should be customizable (not just 16x16 and 32x32) netbeans ide defines action icons either in 16x16 or 24x24 sizes. if they're building application on top of netbeans platform then they can use any icon size they want. the toolbar width/height will adjust accordingly
if there are no objections, i'll integrate the changes tomorrow (nov 28th)
done 9362087a438a
Integrated into 'main-golden', will be available in build *200811290201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/9362087a438a User: S. Aubrecht <saubrecht@netbeans.org> Log: #153835 - moving toolbar l&f code to core.windows, deprecated dnd related methods