This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 146604 - I18N : "Other" menu item is not localized without java.navigation module
Summary: I18N : "Other" menu item is not localized without java.navigation module
Status: VERIFIED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: CSS Visual Tools (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2008-09-09 04:44 UTC by Masaki Katakai
Modified: 2008-09-29 03:29 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
patch (1.98 KB, patch)
2008-09-24 11:24 UTC, Masaki Katakai
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2008-09-09 04:44:02 UTC
"Other" menu item of Window > Other is not from Bundle.properties
when NetBeans is installed without Java support component. e.g. when
users install NetBeans by using C/C++ and Ruby installer.

It seems that the bundle of "Other" is defined only in 

  java.navigation/src/org/netbeans/modules/java/navigation/resources/layer.xml

So without this module, it will be English.

When I checked quickly, it seems that these components are defining
"Other" menu item in layer.xml but do not use bundle in layer.xml
and do not define "Menu/Window/Other=Ot&her" in Bundle.properties.

  css.visual/src/org/netbeans/modules/css/resources/mf-layer.xml
  languages/src/org/netbeans/modules/languages/resources/layer.xml
  ruby.project/src/org/netbeans/modules/ruby/rubyproject/ui/resources/layer.xml
  swingapp/src/org/netbeans/modules/swingapp/resources/layer.xml

I'm not sure which one should define the localized bundle, css.visual? or all?
Please re-assign to proper modules. Thanks.
Comment 1 Peter Pis 2008-09-09 07:41:02 UTC
Reassigning to java for further evaluation.
Comment 2 Tomas Zezula 2008-09-09 10:09:16 UTC
Why java?
When java is installed it's correctly localized.
The C++ and GSF should localize the menu or the common module should localize the menu, but this is not definitely java cluster which is not available in 
Ruby, C++, PHP IDE.
Comment 3 Peter Pis 2008-09-09 10:17:45 UTC
Reassigning to cnd.
Comment 4 Thomas Preisler 2008-09-16 18:44:48 UTC
I grep'ed for Other in all our xml files and didn't get any hits. Any reason to believe it is from CND?
Comment 5 _ gordonp 2008-09-17 01:52:38 UTC
>   languages/src/org/netbeans/modules/languages/resources/layer.xml

wins the prize :-) In my cluster.config=cnd build the only module (from masaki's list) which
defines this menu item is the languages module.
Comment 6 Jan Jancura 2008-09-17 10:45:29 UTC

*** This issue has been marked as a duplicate of 147212 ***
Comment 7 Masaki Katakai 2008-09-22 02:51:35 UTC
The fix of bug 147212 does not help. It seems that CSS editor needs to define
the bundle properties for "Other" menu item.

  css.visual/src/org/netbeans/modules/css/resources/mf-layer.xml

I will reopen and move this to web/css. Please evaluate.
Comment 8 Marek Fukala 2008-09-22 10:35:57 UTC
fixed for css editor. I am not sure whether this one is the last one so reopen and reassign if needed.

changeset:   103125:ce7ff1e638ed
tag:         tip
user:        Marek Fukala <mfukala@netbeans.org>
date:        Mon Sep 22 11:33:59 2008 +0200
summary:     #146604 - localized Menu/Window/Other menu item
Comment 9 Quality Engineering 2008-09-23 17:59:13 UTC
Integrated into 'main-golden', will be available in build *200809231435* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/ce7ff1e638ed
User: Marek Fukala <mfukala@netbeans.org>
Log: #146604 - localized Menu/Window/Other menu item
Comment 10 Masaki Katakai 2008-09-24 03:10:56 UTC
Thank you Marek!

I tried the build(200809231435), but it seems not working properly.
Actually these fixes are integrated in the build, I checked the
contents in jar file.

When I compared with java navigation (org/netbeans/modules/java/navigation/resources/layer.xml),
the difference is "resources". I don't know the exact reason, but when
I change the two files to omit "resources", it's working fine for me.

mf-layer.xml:
from
 <attr name="SystemFileSystem.localizingBundle" stringvalue="org.netbeans.modules.css.resources.Bundle"/>
to
 <attr name="SystemFileSystem.localizingBundle" stringvalue="org.netbeans.modules.css.Bundle"/>

Added Menu/Window/Other=Ot&her to
  css.visual/src/org/netbeans/modules/css/Bundle.properties
instead of
  css.visual/src/org/netbeans/modules/css/resources/Bundle.properties

Comment 11 Marek Fukala 2008-09-24 10:17:04 UTC
The localization of the 'Other' menu is IMHO done properly. In the layer I reference the bundle.properties located in
org/netbeans/modules/css/resources folder. So I cannot understand how it can work if you ommit the resources folder from
the path. Or did you moved the bundle item from the **/resources/bundle.properties to the parent directory's bundle
file? In java the bundle file is not located in resources folder so the reference is correct.

Can you please attach a diff of your changes causing the localization to work? Maybe I miss something.
Comment 12 Masaki Katakai 2008-09-24 11:24:58 UTC
Created attachment 70429 [details]
patch
Comment 13 Masaki Katakai 2008-09-24 11:35:16 UTC
Hi Marek,

I also thought the fix is correct, but it's not working actually. Please try another word
in "Other" of bundle.properties, the menu item is not changed on IDE.
When I use "org/netbeans/modules/css/" instead of "org/netbeans/modules/css/resources",
it works fine. I don't undersand why but java.navigation is not using "resources" too.
I attached the patch, please evaluate.
Comment 14 Marek Fukala 2008-09-24 13:10:08 UTC
Ok. The patch is fine. I really wonder what is the problem, but feel free to integrate if it works. Thanks for your help.
Comment 15 Masaki Katakai 2008-09-26 00:50:03 UTC
Thank you Marek for the review.

I integrated the patch into trunk.

http://hg.netbeans.org/main/rev/ba140b1005db
Comment 16 Quality Engineering 2008-09-27 05:36:32 UTC
Integrated into 'main-golden', will be available in build *200809270201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/ba140b1005db
User: Masaki Katakai <masaki@netbeans.org>
Log: #146604 I18N : "Other" menu item is not localized without java.navigation module
Comment 17 Masaki Katakai 2008-09-29 03:29:10 UTC
verified on build 200809281401. Now the menu is localized on just php,ruby and c/c++ installation.