This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 14568 - I18N - two messages in project settings->workspaces not come from message files
Summary: I18N - two messages in project settings->workspaces not come from message files
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: David Simonek
URL:
Keywords: API, ARCH, I18N
Depends on: 19826
Blocks: 25396
  Show dependency tree
 
Reported: 2001-08-19 17:07 UTC by Ken Frank
Modified: 2008-12-23 11:47 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2001-08-19 17:07:13 UTC
In project settings->workspaces-> editor (or other
workspaces), the value of Toolbar Configuration,
Standard or Debugging, does not come from locale specific 
message files, even though these labels are present in those files

The names of all the workspace areas and the names of all
windows on the windows->windows menu does come from message files, so I don
think this is related to other issues of not seeing certain
labels if FFJ not installed in locale it is run in.
Comment 1 Jan Zajicek 2001-08-20 12:58:57 UTC
Why are now names of toolbars configurations labeled //NOI18N?

Assigning.
Comment 2 mslama 2001-09-03 16:31:07 UTC
Assign to Radko. It should be easy.
Comment 3 Radko Najman 2001-09-05 09:50:46 UTC
There is no support to localize toolbar configurations. The configurations are stored 
in the XML files and the name of the file is the name of the configuration which is 
shown in the toolbar configuration property editor.

Possible fix: add a tag to the configuration file which will describe how to get the 
localized name (e.g. from which bundle to get the localized name).
Comment 4 Jan Chalupa 2001-11-27 11:50:15 UTC
Target milestone -> 3.3.1.
Comment 5 Jan Chalupa 2001-11-27 11:53:40 UTC
Target milestone -> 3.3.1.
Comment 6 David Simonek 2001-12-19 16:41:33 UTC
I'm changing target milestone to 3.4, as this includes API change (DTD
format of xml which describes toolbar settings in in fact kind of
public API)
Comment 7 mslama 2002-01-11 13:17:39 UTC
Evaluation: Add support for toolbar localization, more work.
Comment 8 Ken Frank 2002-04-19 17:21:38 UTC
Is this one related to 19966 about toolbars, which is fixed ?

Or is this still an issue, since api changes mentioned or other fixes
might
have happened in last few months ?

ken.frank@sun.com
04/19/2002
Comment 9 David Simonek 2002-04-22 09:12:21 UTC
AFAIK, unfortunately this is still an issue. Whole toolbar
configuration impl is "not so good" (to be polite) when it comes to
localization and branding. Although bug seems to be easy to fix,
significant architecture redesign and rewrite is needed :-(
Comment 10 mslama 2002-06-26 10:48:36 UTC
Assigning to Dafe
Comment 11 David Simonek 2002-06-27 17:18:01 UTC
uff, too late for 3.4, I'm sorry. Changing milestone. Raising priority
to emphasize importance.
Comment 12 _ ttran 2002-06-29 13:26:06 UTC
added ARCH and API keywords to indicate that changes in those areas
are needed.  In fact the whole toolbar code should be rewritten.  It's
too buggy.
Comment 13 David Simonek 2002-07-08 15:11:41 UTC
Yarda: In my opinion there is a solution. If there is a definition:

<file name="Standard.xml" url="resources/Standard.xml" />

in the module layer. The localization JAR can add file
"resources/Standard_ja.xml" and this file will be used instead of the
"Standard.xml" if started with Japanese locale.

(the magic should be done by the nbresloc protocol, that is the
default one for url="nbresloc:resouces/Standard.xml").

Comment 14 Ken Frank 2002-07-08 16:39:13 UTC
Can solution be to not require an xml file to be localized ?
In netbeans and ffj, 99% of time the use of localized
bundle files is all that is needed. The xml file in module's
main jar and other module code take care of the logic to
use ja bundle file when user in ja locale.  Labels like
these should be just in bundle files, as per netbeans
i18n guidelines.

ken.frank@sun.com
07/08/2002
Comment 15 David Simonek 2002-07-09 17:07:11 UTC
I'm working on it...
Comment 16 David Simonek 2002-07-10 07:56:37 UTC
Ken, some details for you:
- Yes, part of solution is not to localize xml file in question. In
fact, xml isn't localized now and it will stay this way. Yarda's
comment expected that we need to localize info inside xml file (which
is not needed here)
- right solution (again thanks Yarda) is to localize name of xml file
(through standard bundle way) and update code on various places to
work with localized names of toolbar configurations correctly.
Comment 17 David Simonek 2002-07-10 15:48:12 UTC
fixed in main trunk.
localization now works through standard file object localization in
bundles. I've added english localization to the
org.netbeans.core.Bundle.properties:
Toolbars/Standard.xml=Standard
Toolbars/Debugging.xml=Debugging

To get correct japanese translation, it's needed to modify
org.netbeans.core.Bundle_ja.properties as usual. Thx.
Comment 18 Marian Mirilovic 2002-10-16 13:55:36 UTC
verified in [nb_dev](20021016)