This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Currently, the xml.tools module is part of nb.cluster.ide and this is build before any java modules are build. The fix for bug 90174 requires using retouche. http://www.netbeans.org/issues/show_bug.cgi?id=90174 The code for this fix will go into xml.tools module and will require dependencies on the following java modules: Java Source Java Source API Javac API wrapper As a result, after the fix the nb.cluster.ide will not compile since the java modules have not been build. The xml.tools module needs to be moved to nb.cluster.xml for #90174 to be fixed
apireviews is the correct place to ask about major architectural changes like this. To me at least the move seems reasonable.
Well, I believe that the xml.tools module contains quite a lot of functionality of its own, without the need to use anything from Java. If that is true, keep the xml.tools module where it is and create another xml.tools.java module(Y01) to provide the way to generate sax parser & co. Of course, for that you need some API between these two modules and it is very good that you have asked for review. Hopefully we can ensure such API is well designed, documented and read for future maintenance.
There may in fact be no need for any API between the two modules. IIRC the SAX/DOM parser generation actions are pretty much standalone tidbits of functionality.
Ok; I will go ahead and create a new module - xml.tools.java. This module will contain the two DTD actions that requires retouche (i) Generate DOM Scanner (ii)SAX Document Handler Wizard. The new module will not expose any public APIs and will be part of the java cluster. If there are no objections, I will integrate the code on Tuesday (19th Feb )
Fixed. changeset 58a6a45dce70 in main details: http://hg.netbeans.org/main?cmd=changeset;node=58a6a45dce70 description: issue# 127330 xml.tools module needs to be moved from ide cluster to java cluster (part 1 - WIP) changeset ecb56215c308 in main details: http://hg.netbeans.org/main?cmd=changeset;node=ecb56215c308 description: Fix for bug 127330 : xml.tools module needs to be moved from ide cluster to java cluster changeset 4e94d3588169 in main details: http://hg.netbeans.org/main?cmd=changeset;node=4e94d3588169 description: issue# 127330 xml.tools module needs to be moved from ide cluster to java cluster