This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 120480 - [regression] End tags not indented after closing it by '>'
Summary: [regression] End tags not indented after closing it by '>'
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Editor (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Tomasz Slota
URL:
Keywords: REGRESSION
: 120488 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-10-30 15:18 UTC by Marek Fukala
Modified: 2009-05-18 10:47 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Fukala 2007-10-30 15:18:27 UTC 
End tags are not indented after closing the tag by typing ending > character.

To reproduce:
1) create an empty html file
2) type <h1>
3) press enter
=> the cursor correctly jumps to <h1> level + one indent
4) type </h1
5) type >
=> the </h1> stays on its position but should be indented to the opening tag level.

Please fix this, it is quite annoying regression.
Comment 1 Tomasz Slota 2007-10-30 16:28:32 UTC 
confirmed, reproducible
Comment 2 Tomasz Slota 2007-10-30 16:33:12 UTC 
*** Issue 120488 has been marked as a duplicate of this issue. ***
Comment 3 Tomasz Slota 2007-11-02 22:56:56 UTC 
Fixed for HTML tags (pending fix for JSP-specific tags)

Checking in HTMLCompletionQuery.java;
/cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v  <--  HTMLCompletionQuery.java
new revision: 1.45; previous revision: 1.44
Comment 4 Tomasz Slota 2007-11-03 17:02:59 UTC 
Marek volunteered to finish fixing this bug, it should be easy for him as it is actually in the CC area...
Comment 5 Marek Fukala 2007-11-03 18:50:36 UTC 
fixed the JSP end tag completion reformatting.

But Tome, haven't you forget to commit the reformat hook at the DefaultKeyTypedAction? From the commit you just changed
the HTMLCompletionQuery, nothing else. I can also still reproduce the original problem - the only think which works now
is that the line is reformatted if user completes html or jsp end tag. If the tag is put manually it needs to be
properly indented after typing the closing '>' character - read my steps to reproduce.

I am not closing, reassigning back to you, please fix the remaining problem, thanks. 

Checking in JspCompletionItem.java;
/cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/completion/JspCompletionItem.java,v  <--  JspCompletionItem.java
new revision: 1.18; previous revision: 1.17
done
Comment 6 Tomasz Slota 2007-11-03 23:26:42 UTC 
Fix completed.

Checking in web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JSPKit.java;
/cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JSPKit.java,v  <--  JSPKit.java
new revision: 1.55; previous revision: 1.54
done
Checking in html/editor/src/org/netbeans/modules/editor/html/HTMLKit.java;
/cvs/html/editor/src/org/netbeans/modules/editor/html/HTMLKit.java,v  <--  HTMLKit.java
new revision: 1.32; previous revision: 1.31
done
Checking in xml/tageditorsupport/src/org/netbeans/modules/editor/structure/formatting/TagBasedLexerFormatter.java;
/cvs/xml/tageditorsupport/src/org/netbeans/modules/editor/structure/formatting/TagBasedLexerFormatter.java,v  <--  TagBasedLexerFormatter.java
new revision: 1.37; previous revision: 1.36
done