This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 118641 - Setting "all" for margin/padding for CSS in Style Builder breaks the code
Summary: Setting "all" for margin/padding for CSS in Style Builder breaks the code
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: CSS Visual Tools (show other bugs)
Version: 6.x
Hardware: All Windows XP
: P3 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-12 00:30 UTC by giorgio42
Modified: 2008-04-28 13:37 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screenshot of test.css after step 3 (44.08 KB, image/png)
2007-10-18 22:36 UTC, giorgio42
Details

Note You need to log in before you can comment on or make changes to this bug.
Description giorgio42 2007-10-12 00:30:48 UTC
NB6,200710100000,WinSPXP2,1.6.0_05-ea; Java HotSpot(TM) Client VM 1.6.0_05-ea-b04

With this rule,

.cell {
  color: white;
  font-style: normal;
  font-weight: bold;
  font-size: 10pt;
  line-height: normal;
  font-family: Verdana, Arial, Helvetica, sans-serif;
  text-decoration: none;
  background-color: #055959;
  text-align: left;
  padding: 4px;
  border: 1px solid black;
}

I see the following issues with style builder:
1) font size field shows <Not Set>, should be 10
2) font size unit drop down is disabled, should be enabled and show pt
3) border tab: all fields show <Not Set>
4) margin tab: all fields show <Not Set>
5) position tab: Position, Size and Clip labels are in larger font, blue and bold.
6) When I deselect the No Decorations check box, the line just below is out-dented by 1 space (background-color).
7) The text decoration deselect checkbox should be the first one, not somewhere in between (also probably be called "none").
8) Loading the visual css editor takes too long the first time.
9) Selecting 1px in the All margin drop down adds 4 lines to the rule at the bottom (one for each side) instead of one
(margin: 1px;).
10) Setting the All margin drop down back to <Not Set> leaves margin-right: 1px; but deletes the closing brace and makes
the Css unparsable.

I guess we leave at that for now...

Moreover the .css files are not recognized reliably, resulting in no syntax coloring and style builder showing
No Css Rule Selected. In some cases switching to a different file and then back helps, but not always. Sometimes not
even restarting the IDE helps.


Georg
Comment 1 Marek Fukala 2007-10-12 09:56:12 UTC
#1,2 - fixed

Checking in CssProperties.java;
/cvs/web/css/src/org/netbeans/modules/css/visual/model/CssProperties.java,v  <--  CssProperties.java
new revision: 1.6; previous revision: 1.5
done

#3,4,9 is unfortunatelly by the original design from creator. We may work on this in next version.

#5 - fixed (labels are still bold, that is an intention)

Checking in PositionStyleEditor.java;
/cvs/web/css/src/org/netbeans/modules/css/visual/ui/PositionStyleEditor.java,v  <--  PositionStyleEditor.java
new revision: 1.10; previous revision: 1.9
done
Checking in PositionStyleEditor.form;
/cvs/web/css/src/org/netbeans/modules/css/visual/ui/PositionStyleEditor.form,v  <--  PositionStyleEditor.form
new revision: 1.8; previous revision: 1.7
done

#6 - should be already fixed

#7 - fixed by moving at the end

Checking in FontStyleEditor.java;
/cvs/web/css/src/org/netbeans/modules/css/visual/ui/FontStyleEditor.java,v  <--  FontStyleEditor.java
new revision: 1.11; previous revision: 1.10
done
Checking in FontStyleEditor.form;
/cvs/web/css/src/org/netbeans/modules/css/visual/ui/FontStyleEditor.form,v  <--  FontStyleEditor.form
new revision: 1.10; previous revision: 1.9
done

#8 - is it significantly slower than other editors? I haven't noticed the UI slowing down the file opening.

>Moreover the .css files are not recognized reliably,
known issue, valid for all Schlieman based editors, should be fixed already.

Thanks for the valuable feedback! Please verify the changes, thanks!
Comment 2 giorgio42 2007-10-15 21:34:35 UTC
Using NB200710150000:
1) and 2): OK.

5) I don't understand why the labels should be bold. It is inconsistent with the formatting of the style, layout and
border panels and looks like an oversight.

6) is fixed.

7) and 10) are not fixed, shift left by 1 space and deleting closing brace still occur.

3), 4) and 9): NetBeans and Creator have different audiences. Creator is for former VB developers, NetBeans for
experienced Java developers (former C++ developers, hehe). Therefore it is important for NetBeans not to be satisfied
with Creator's loosing bloated half-cookedness...

Regards
Georg
Comment 3 Marek Fukala 2007-10-18 22:00:23 UTC
>5) I don't understand why the labels should be bold. It is inconsistent with the formatting of the style, layout and
>border panels and looks like an oversight.
fixed

Checking in PositionStyleEditor.java;
/cvs/web/css/src/org/netbeans/modules/css/visual/ui/PositionStyleEditor.java,v  <--  PositionStyleEditor.java
new revision: 1.11; previous revision: 1.10
done
Checking in PositionStyleEditor.form;
/cvs/web/css/src/org/netbeans/modules/css/visual/ui/PositionStyleEditor.form,v  <--  PositionStyleEditor.form
new revision: 1.9; previous revision: 1.8
done

>7) and 10) are not fixed, shift left by 1 space and deleting closing brace still occur.
Cannot reproduce, the original bug has been verified by QE AFAIK, can you please provide exact steps to reproduce???

>3), 4) and 9): NetBeans and Creator have different audiences. Creator is for former VB developers, NetBeans for
>experienced Java developers (former C++ developers, hehe). Therefore it is important for NetBeans not to be satisfied
>with Creator's loosing bloated half-cookedness...
I agree, however no chance to do that in 6.0. Feel free to file new enhancement, we can do that in 6.1.
Comment 4 giorgio42 2007-10-18 22:35:13 UTC
1. Starting with this:
.foo {
  padding: 1px;
  margin: 1px;
}

2. On Margin tab switch All - Not Set to All - 1. You get
foo {
  padding: 1px;
  margin: 1px;
  margin-right: 1px;
  margin-left: 1px;
  margin-bottom: 1px;
  margin-top: 1px;
}

3. Now changing All - 1 back to All - Not Set gives:
.foo {
  padding: 1px;
  margin: 1px;
 margin-left: 1px;


The closing brace is missing and margin-left: 1px; has been out-dented by 1 space.

Georg
Comment 5 giorgio42 2007-10-18 22:36:25 UTC
Created attachment 51249 [details]
Screenshot of test.css after step 3
Comment 6 giorgio42 2007-10-18 22:50:36 UTC
Just to make sure I tested this with a brand new userdir and it is still completely reproducible:

.foo {
}

Toggle margin All setting to 1 and delete the superfluous empty line before the closing brace.
Toggle margin All setting back to not set. You get:
.foo {
   margin-left: 1px;

Comment 7 Marek Fukala 2007-10-18 23:07:31 UTC
Thanks for the perfect steps to reproduce! I wish more users were like you. However, it perfectly works for me. Can you
please confirm that you use latest build?

.foo {
}

Toggle margin All setting to 1 =>

.foo {
    margin-right: 1px;
    margin-left: 1px;
    margin-bottom: 1px;
    margin-top: 1px;
}

Toggle margin All setting to <Not Set> =>

.foo {
}

I belive it was fixed [2007/10/08 07:10:58] by issue #105723 - CSS UI editor adding more rule items break the code. Can
you confirm you do use newer build?
Comment 8 giorgio42 2007-10-19 11:26:50 UTC
Perfectly reproducible with 200710181200 (takes less than 5 seconds).

Create new empty file test.css in a web project.
Insert the following rule and put the caret between the braces:
.foo {
|}

Toggle margin all from Not Set to 1 and back and, whoopee:
.foo {    
 margin-left: 1px;


If I find the time I create and attach a flash movie...

(I only wish the complete and utter hang-ups I am experiencing with the latest 2 or 3 dailies would be as easily
reproducible as this one).

Georg



Comment 9 Marek Fukala 2007-10-20 13:49:37 UTC
There must be something different in the UI events handling on your OS/jdk. It perfectly works for me. I'll add some
debug logging into the code so we can find the problem. The movie is not necessary, I belive you it doesn't work for
you. I'll add a comment once I add the logging. Thanks!

Jindro, could you please try to reproduce the problem somehow??
Comment 10 Jindrich Sedek 2007-10-23 16:06:30 UTC
I'm not able to reproduce on Linux and Solaris, but it's reproducible for Win XP (2000). It seems to be platform 
related issue, but it should be fixed in 60.
Comment 11 giorgio42 2008-02-06 14:16:16 UTC
Verified fix in 6.0 and latest 6.1 dailies.

Thanks!
Georg
Comment 12 Marek Fukala 2008-02-25 17:21:29 UTC
user verified the problem is fixed, closing