This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 97494 - [Code Review] Project conventions
Summary: [Code Review] Project conventions
Status: NEW
Alias: None
Product: soa
Classification: Unclassified
Component: SQL Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Pavan Veeravarapu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-08 18:25 UTC by Chris Webster
Modified: 2007-10-30 08:01 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Webster 2007-03-08 18:25:54 UTC
Project Actions:
* New (From template) should be on the project node 

* Make Clean & Build project action read, Clean and Build Project as other projects

* missing the Move, Delete, Rename ... project actions

* why have deploy and undeploy actions (which are disabled)

* Add tools action to project

* OPTIONAL remove explore from here to be consistent

* New from File -- I see IEP, SQL, and XSLT files available from both project
types. Do these files make sense and are they useful in the project types.

Logical View
* Both projects have the java package view. Does this make sense here? I  would
guess that the package view might be confusing. Another potential issue is that
the java operations such as refactoring and compile are pulled in. Seems it
would be more consistent with other SU type projects if the BPEL or XSLT
paradigm was followed or perhaps a better grouping which makes sense based on
the domain.

Customizer
* Both projects have subproject references. How is this used? If not used, then
this should be removed. Would it make more sense to incorporate the XML project
ref support?

* General section - Would it be possible to have more specific defaults for the
Assembly Unit (SQL Service Unit ...) and Application Sub Assembly dialogs.

Build Script
* The project build scripts should support user editing (for example to extend
targets). The build scripts both have references to java compilation which I
don't think is supported. The problem is that users who would like to modify the
build script find it difficult to determine how the build scripts work with dead
scripting code. The scripts need to be tailored to the appropriate task and
remove the unnecessary code. The pre and post extensions for the main targets
should be maintain as well as updating the comments about how to override the
script.

Code
* Remove: FileBuiltQueryImplementation fileBuilt =
helper.createGlobFileBuiltQuery(helper.getStandardPropertyEvaluator(),
            new String[] {"${src.dir}/*.java"}, // NOI18N
            new String[] {"${build.classes.dir}/*.class"} // NOI18N
        );

  from the project as there is no java code expected here.


* Remove Compile single from action provider as I don't think it makes sense.

* There is code in the action provider referring to the target server, since the
deployment is handled at the comp app level is this necessary ?

* The project generation code has a lot of references to java/j2ee which  are
not necessary. These generate extra properties and make the build script more
difficult to follow because of unused properties. 

* LogicalViewProvider.findPath -- I would recommend implementing this method as
things like the XML refactoring rely on this to find the path from a DataNode in
a project.
Comment 1 Venkat Srinivasan 2007-03-21 15:31:12 UTC
Please look into this.