This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 95607 - I18N - feature description section info not from bundle file
Summary: I18N - feature description section info not from bundle file
Status: VERIFIED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: dlipin
URL:
Keywords: I18N
Depends on: 90584
Blocks:
  Show dependency tree
 
Reported: 2007-02-14 19:44 UTC by Ken Frank
Modified: 2007-11-04 21:40 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2007-02-14 19:44:29 UTC
This might be true for all components - only using the nb6 one in the
generated nbi installer.

I know the bundle msgs from the componennt logic, 1.jar is not i18n'd yet
as to showing the messages from the localized bundle.

but the info in the feature descripotion section on right side of the features
setup panel, that info is not in the en bundle file.
Comment 1 dlipin 2007-04-17 19:48:00 UTC
Now feature description panel title is taken from the bundle file.
Ken, please verify on the next daily build.
Comment 2 Ken Frank 2007-05-25 19:08:30 UTC
am reopening - this was about the actual contents of the feature description setting
when one clicks on a component to be installed, for example, for 
Base IDE it says

"The NetBeans IDE is a free, Open-Source Integrated Development Environment for
software developers. The IDE runs on many platforms including Windows, Linux,
Solaris, and the MacOS. It is easy to install and use straight out of the box."

its that information that I don't think is in a bundle file.

ken.frank@sun.com
Comment 3 dlipin 2007-05-28 13:38:45 UTC
Ken,

Do I understand you correctly that this description ("The NetBeans IDE is a 
free...") is not in any of the bundle files?

I can say that actually it is in the Base IDE bundle file:

http://installer.netbeans.org/source/browse/installer/components/products/nb-
base/data/Bundle.properties?rev=1.2&view=markup

So I mark the issue as fixed. If we are not on the same page then please 
clarify what you meant.

Comment 4 Ken Frank 2007-05-28 19:05:16 UTC
for the bundle you refer to, and the others for the other components that can be
installed,
where are they in the logic,1.jar files that are part of installer  ?  Thats
what is being pseudo localized.


for example, for sjsas, in the logic1.jar of it
data/sjsas/9.1.0.41.20070424/solaris-sparc/logic/org/netbeans/installer/products/sjsas

there are 2 bundle files and neither has what appears to be that kind of description
in it that would be seen in description panel.

If all of these descriptions for all components are in the Bundle.properties of
their logic,1.jar files, then it could be I am missing some step.

ken.frank@sun.com
Comment 5 dlipin 2007-05-29 08:48:01 UTC
Ken,

I see you point of view.

For now this description is stored (as a source) in the bundle file but when 
the specific installer is created (bundle.jar with a lot of data,{i}.jar and 
logic,{i}.jar) this description is saved in the data/registry.xml file inside 
the bundle.jar.
Comment 6 Ken Frank 2007-05-29 15:13:45 UTC
Am reopening based on the comments that in installer, its saved in an xml file;
these descriptions need to come from bundle file (or html file if the localized
version will be found, for example, if in ja locale, <filename>_ja.html
will be used.

ken.frank@sun.com
Comment 7 Ken Frank 2007-07-19 20:14:34 UTC
since this covers a big part of messages to user, can it be fixed fairly soon ?
is marked for m9 but that is passed.

ken.frank@sun.com
Comment 8 dlipin 2007-07-22 12:35:05 UTC
Actually this issue very likely depends on Issue 
90584. As soon as we can handle jar'ed registries, 
we can put any i18n data in that jar. The fix seems 
to be not very complicated from the first view but 
we need to be carefull about backward 
compatibility.
Comment 9 dlipin 2007-10-12 10:34:52 UTC
Fixed.

Ken, please verify.
Comment 10 Ken Frank 2007-10-15 22:57:42 UTC
I need information to be able to verify this:

1. please point me to the specific english bundle file
and which installer jar it is in; I want to be
sure to pseudo localize this one.

for example, if it is in nbi.jar file, please let
me know which bundle file.
if its in some other jar file in installer, please
let me know about that one.

2. is this bundle file also in the installer l10n kit ?
please check the l10n kit to see.

ken.frank@sun.com
Comment 11 dlipin 2007-10-16 10:54:23 UTC
Take this one:

http://bits.nbextras.org/download/6.0/nightly/200710150000/bundles/netbeans-trunk-nightly-200710150000-javaee-
windows.exe

Extract it using command :
netbeans-trunk-nightly-200710150000-javaee-windows.exe --extract

In the current directory you`ll see bundle.jar.
Look into it at data\registry.xml file - search for e.g. glassfish description 
("Free, open source, production-quality application server that is also"...)

This description is in the kit file:
http://deadlock.netbeans.org/hudson/job/l10nkit/89/artifact/nbbuild/l10ndist/installer/l10n-071015.tar.gz

extract the installer kit and look into
workspace\installer.tar\installer\components\products\glassfish\data\Bundle.properties 
This file contains the same glassfish description.
Comment 12 Ken Frank 2007-10-16 16:01:48 UTC
Dmitry,

1. for the installer l10n kit, there is nbi.tar and installer.tar

each of them have section of nbi subdir.

Are both of these kits needed to be translated ?

If not, or even if yes, can there be just one installer l10n kit tar file, instead of 2 ?


2.for the actual glassfish description in the installer itself, I think you are saying that the bundle file
installer\components\products\glassfish\data\Bundle.properties

is not in the bundle.jar, but just the xml file; that during the build of the installer, the msgs in the bundle
file (which has been put back to translatedfiles/src) will be converted and inserted into the xml file in actual
installer ?

If yes, then that has been the confusing part for me, since other msgs of components are in logic1.jar file of each
component in the actual bundle.jar.

And if yes, it means I can't test this part by inserting my own bundles into logic1.jar and bundle.jar, thus 
I need a test installer from your team, based on some pseudo localized bundle file I can provide you.

ken.frank@sun.com
Comment 13 Ken Frank 2007-10-16 16:28:48 UTC
to reclarify question about how the translated bundle with the description gets into the
data/registry.xml

does it mean that the one data/registry.xml will have also all the translated msgs in it,
and the correct msg will be found based on locale user is in ?

or will you create a registry.xml per locale ?  I don't think java itself finds xml files
based on locale name as it does for bundle files.

ken.frank@sun.com
Comment 14 dlipin 2007-10-17 08:58:07 UTC
Ken

> 1. for the installer l10n kit, there is nbi.tar and installer.tar
correct

> each of them have section of nbi subdir.
you are not right here. each of them has engine subdir

> Are both of these kits needed to be translated ?
yes

> If not, or even if yes, can there be just one installer l10n kit tar file, instead of 2 ?
ask BE about that. actually some message files from nbi tar file are replaced by files from installer tar file 
since that have the same path (inside the tar).


> 2.for the actual glassfish description in the installer itself, I think you are saying that the bundle file
> installer\components\products\glassfish\data\Bundle.properties

> is not in the bundle.jar, but just the xml file; that during the build of the installer, the msgs in the bundle
> file (which has been put back to translatedfiles/src) will be converted and inserted into the xml file in actual
> installer ?
YES

> If yes, then that has been the confusing part for me, since other msgs of components are in logic1.jar file of each
> component in the actual bundle.jar.
The same applies to the component names as well - they are also in this registry.xml file.

> And if yes, it means I can't test this part by inserting my own bundles into logic1.jar and bundle.jar, thus 
> I need a test installer from your team, based on some pseudo localized bundle file I can provide you.
Ken, you can put the pseudo localized bundle file in translated files:
translatedfiles/src/nbi
translatedfiles/src/installer

>to reclarify question about how the translated bundle with the description gets into the
> data/registry.xml

> does it mean that the one data/registry.xml will have also all the translated msgs in it,
> and the correct msg will be found based on locale user is in ?
yes

> or will you create a registry.xml per locale ?  I don't think java itself finds xml files
> based on locale name as it does for bundle files.
no, we have only one registry.xml with all info and all localized messages
we don`t have registry_ja.xml and registry_zh_CN.xml


Dmitry


Comment 15 Ken Frank 2007-11-04 21:40:13 UTC
verified.  I see feature descriptions from bundle file now;
bundle files for feature descriptions are not in installer itself;
the installer processes the put back bundle files into an xml kind
of file.

ken.frank@sun.com