This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
NetBeans IDE Dev (Build 200702111900) 1.6.0; Java HotSpot(TM) Client VM 1.6.0-b105 Linux version 2.6.17-10-generic running on i386 cs_CZ (nb); UTF-8 - create Samples|NB Plug-in modules|Feedreader - look in projects view, Feedreader application (module suite) has an "old" icon, while modules have the new one. If you look into new project wizard under NB plug-in modules category,you'll find out,that module suite here has a new icon. P2 since internal UI consistency is surely eligible..
apisupport/project/src/org/netbeans/modules/apisupport/project/suite/resources/suite.gif
I changed the icon to the same one as the module (as it is in the wizard). Checking in src/org/netbeans/modules/apisupport/project/suite/resources/suite.gif; /cvs/apisupport/project/src/org/netbeans/modules/apisupport/project/suite/resources/suite.gif,v <-- suite.gif new revision: 1.3; previous revision: 1.2 done
Is it the final state or temporary solution, Pavle? Should not we have a different icon for suite? If yes, did you filed a new bug (could not find it)?
It seems strange to have same icons for suite and module. Try to create feedreader sample => hard to say what is suite quickly. Anybody knows who could deliver us right icon, i.e. who did the new icon for module?
Not sure why plugin and suite should use the the same icon, but that's what the report said. I will leave this upto Jano to decide and please send a new icon ASAP if you want a different icon for suite (makes sense to me). It's very simple to fix, of course, once we get the new icon. Attach the icon and reassign back to me to integrate if you want. I hate to see a P2 open for this, that's I did the hotfix.
If module suite is a fundamentally different project type, then it should have it's own icon. How about "library wrapper module" should it have a special icon as well? If the project node in the Project view uses the same icon as in the New Project wizard, then it's consistent. So I don't think this is a P2 bug.
I think that situation in NB <=5.5 was optimal. Suite is a container for modules so it should have the same icon (with those new adornments) as it has before Pavel's commit. Standalone module, suite component module and library wrapper module might have one, the same, icon. This is what current users are used to I think. In other words I would leave as it was (in NB <=5.5). But current situation is just worse - regression.
Created attachment 46971 [details] Module suite 5.0 versus 6.0
Jano please look at the screenshot in the attachments. Module Suite is very important project for developers who develops NetBeans applications. Let's imagine that you have 20 nbm projects in a module suite. If the module suite has the same icon like nbm project it will be to difficult to find it among 20 open projects. You need to invoke rebuild on the module suite if you want to rebuild all modules. The module suite also contains actions for running jnlp application, etc.
BTW: library wrapper modules are not technically different from any other modules, just a different initial template.
Created attachment 46983 [details] Temporary icon for module suite project.
As the icon designer is on vacation, I've created a temporary icon to fix this issue for Beta 1. See the previous attachment. Please integrate the icon and assign back to me (as P3 ;-). I'll then work with the icon designer to deliver proper icon for Beta 2.
So I committed the new suite icon. I also used it in the New Project wizard; and fixed icon references from JavaHelp, which were still using the old icons (as private copies, now linking into the module for easier maintenance). Checking in javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/about_create.html; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/about_create.html,v <-- about_create.html new revision: 1.16; previous revision: 1.15 done Checking in javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/filelevel_create/about_file_wizards.html; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/filelevel_create/about_file_wizards.html,v <-- about_file_wizards.html new revision: 1.17; previous revision: 1.16 done RCS file: /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/suite/resources/suite.png,v done Checking in src/org/netbeans/modules/apisupport/project/suite/resources/suite.png; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/suite/resources/suite.png,v <-- suite.png initial revision: 1.1 done Removing src/org/netbeans/modules/apisupport/project/suite/resources/suite.gif; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/suite/resources/suite.gif,v <-- suite.gif new revision: delete; previous revision: 1.3 done Checking in src/org/netbeans/modules/apisupport/project/suite/SuiteProject.java; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/suite/SuiteProject.java,v <-- SuiteProject.java new revision: 1.38; previous revision: 1.37 done Checking in javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/projectlevel_create/about_project_wizards.html; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/projectlevel_create/about_project_wizards.html,v <-- about_project_wizards.html new revision: 1.13; previous revision: 1.12 done Checking in src/org/netbeans/modules/apisupport/project/ui/resources/layer.xml; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/resources/layer.xml,v <-- layer.xml new revision: 1.54; previous revision: 1.53 done Removing javahelp/org/netbeans/modules/apisupport/project/docs/images/module.gif; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/images/module.gif,v <-- module.gif new revision: delete; previous revision: 1.1 done Removing javahelp/org/netbeans/modules/apisupport/project/docs/images/suite.gif; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/images/suite.gif,v <-- suite.gif new revision: delete; previous revision: 1.1 done
We have new icons from the visual designer. As the module and module suite icons didn't follow the new icon style properly (don't use rotated symbols), we had to redesign the module icon as well. I'll attach both icons.
Created attachment 51560 [details] Module icon
Created attachment 51562 [details] Module suite icon
Created attachment 51589 [details] Badge for suite's "Modules" pseudofolder is still old, but probably not a priority to fix
Checking in javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/about_create.html; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/about_create.html,v <-- about_create.html new revision: 1.17; previous revision: 1.16 done Checking in javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/filelevel_create/about_file_wizards.html; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/filelevel_create/about_file_wizards.html,v <-- about_file_wizards.html new revision: 1.20; previous revision: 1.19 done Checking in src/org/netbeans/modules/apisupport/project/NbModuleProject.java; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/NbModuleProject.java,v <-- NbModuleProject.java new revision: 1.159; previous revision: 1.158 done Checking in src/org/netbeans/modules/apisupport/project/suite/resources/suite.png; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/suite/resources/suite.png,v <-- suite.png new revision: 1.2; previous revision: 1.1 done Removing src/org/netbeans/modules/apisupport/project/resources/module.gif; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/resources/module.gif,v <-- module.gif new revision: delete; previous revision: 1.2 done RCS file: /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/resources/module.png,v done Checking in src/org/netbeans/modules/apisupport/project/resources/module.png; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/resources/module.png,v <-- module.png initial revision: 1.1 done Checking in javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/projectlevel_create/about_project_wizards.html; /shared/data/ccvs/repository/apisupport/project/javahelp/org/netbeans/modules/apisupport/project/docs/create_plugin/projectlevel_create/about_project_wizards.html,v <-- about_project_wizards.html new revision: 1.15; previous revision: 1.14 done Checking in src/org/netbeans/modules/apisupport/project/ui/resources/layer.xml; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/resources/layer.xml,v <-- layer.xml new revision: 1.58; previous revision: 1.57 done Removing src/org/netbeans/modules/apisupport/project/ui/resources/module.gif; /shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/resources/module.gif,v <-- module.gif new revision: delete; previous revision: 1.2 done