This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 92744 - "Add WSDL Import" and "Add Schema Import" should use the same Import dialog as those used by WSDL Editor and Schema Editor
Summary: "Add WSDL Import" and "Add Schema Import" should use the same Import dialog a...
Status: VERIFIED FIXED
Alias: None
Product: soa
Classification: Unclassified
Component: BPEL Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Nikita Krjukov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-17 23:58 UTC by _ hong_lin
Modified: 2007-02-21 17:46 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
BPEL WSDL Import dialog (24.22 KB, image/png)
2007-01-17 23:58 UTC, _ hong_lin 		Details
BPEL Schema Import dialog (24.81 KB, image/png)
2007-01-17 23:59 UTC, _ hong_lin 		Details
Import dialog from WSDL Editor (23.25 KB, image/png)
2007-01-18 00:01 UTC, _ hong_lin 		Details
Import dialog from Schema Editor (31.08 KB, image/png)
2007-01-18 00:03 UTC, _ hong_lin 		Details
Screen shot of the new "Add WSDL Import" dialog (25.22 KB, image/png)
2007-02-14 22:38 UTC, _ hong_lin 		Details
Screen shot of the new "Add Schema Import" dialog (23.76 KB, image/png)
2007-02-14 22:39 UTC, _ hong_lin 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ hong_lin 2007-01-17 23:58:28 UTC 
Build: Gavotte nightly build 070116_30

Steps to reproduce it:

1. Open a .bpel file into BPEL Editor.
2. In Navigator window, right-click "Import" node, select "Add WSDL Import..."
or select "Add Schema Import...". (See attachment BpelWSDLImport.png and
BpelSchemaImport.png)

The Import dialogs from WSDL Editor and Schema Editor are changed in Gavotte
build (see attachment WSDLImport.png and SchemaImport.png). 

These dialogs should be in sync.
Comment 1 _ hong_lin 2007-01-17 23:58:59 UTC 
Created attachment 37466 [details]
BPEL WSDL Import dialog
Comment 2 _ hong_lin 2007-01-17 23:59:31 UTC 
Created attachment 37467 [details]
BPEL Schema Import dialog
Comment 3 _ hong_lin 2007-01-18 00:01:42 UTC 
Created attachment 37468 [details]
Import dialog from WSDL Editor
Comment 4 _ hong_lin 2007-01-18 00:03:37 UTC 
Created attachment 37469 [details]
Import dialog from Schema Editor
Comment 5 Vitaly Bychkov 2007-02-14 10:59:43 UTC 
Fixed by supernikita as part of fix for 80243.
Comment 6 _ hong_lin 2007-02-14 22:35:21 UTC 
Vwrified the fix is in Gavotte daily build 070214_2. But the fix is not 100%
correct. I will file a separate bug.

For example, I created a SynchronousSample project. Here is my observation:

After clicking "Add WSDL Import" item, the import dialog pops up (See attached
BPELWsdlImport.png file):
1) the title of the dialog should be "Add Import", or "Add WSDL Import". Right
now, it is "Create New Import".
2) Under "By Namespace", there are two "SynchronousSample.wsdl" items listed.
One of them is even selectable. This is not right.
3) The default prefixes are all set to "ns1", each of them should be a unique
value, something like ns0, ns1, ns2, ...

After clicking "Add Schema Import" item, the import dialog pops up (See attached
BPELSchemaImport.png file):
1) the title of the dialog should be "Add Import", or "Add Schema Import". Right
now, it is "Create New Import".
2) Under "By Namespace", there are two "SynchronousSample.wsdl" items listed.
One of them is even selectable. This is not right.
3) Missing the prefixes default setting.

I am re-opening this issue. Please let me know if you prefer to log a new bug
about these issues and close this one.
Comment 7 _ hong_lin 2007-02-14 22:38:11 UTC 
Created attachment 38513 [details]
Screen shot of the new "Add WSDL Import" dialog
Comment 8 _ hong_lin 2007-02-14 22:39:44 UTC 
Created attachment 38514 [details]
Screen shot of the new "Add Schema Import" dialog
Comment 9 Sergey Lunegov 2007-02-15 06:54:41 UTC 
Nikita, please take a look.
Comment 10 Nikita Krjukov 2007-02-15 15:57:36 UTC 
Here is the response to the observations of hong_li:

1) I changed the title of dialogs to "Add WSDL Import" and "Add Schema Import" 
correspondingly.

2) I can't reproduce the mentioned wrong behaviour with a new SynchronousSample:
>> Under "By Namespace", there are two "SynchronousSample.wsdl" items listed.
>> One of them is even selectable. This is not right.
I suppose the WSDL file should appear at the tree only once. If it appears 
twice then it's obviously a defect. Maybe it worth to log a new issue for it. 
But a detailed description is required to be able to reproduce it. I think it 
should be able to reproduced this problem not only in dialogs in BPEL but also 
in WSDL and other places where the ExternalReferenceCreator class is used.

3) Current implementation behaves the following way:
 -- If the resource file is already imported, then its prefix is displayed.
 User doesn't allowed to modify the prefix. 

 -- If the resource file isn't imported yet, then prefix isn't provided 
automatically. But user able to specify whatever prefix he want. If user 
doesn't specify prefix explicitly, then an automatically generated prefix will 
be assigned. 

I don't think it reasonable to generate automatic prefixes preliminarily.
If user doesn't want to assign a specific value for prefix, then it doesn't 
matter to he what prefix will be generated. The only important thing for user 
in this case is to be sure that prefixes will be unique. 

If you insist that all prefixes should be shown, I suggest to create a new 
issue and assign to it the FEATURE or ENHANCEMENT type.
Comment 11 _ hong_lin 2007-02-15 23:37:26 UTC 
Please change the status to "RESOLVED" instead of "INVALID". The original issue
was a valid one. 

I will log an ENHANCEMENT later.

Thanks.
Comment 12 Sergey Lunegov 2007-02-16 06:25:51 UTC 
Should reopen to resolve it as fixed.
Comment 13 Sergey Lunegov 2007-02-16 06:26:41 UTC 
fixed indeed
Comment 14 _ hong_lin 2007-02-21 17:46:14 UTC 
Verified