This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 9219 - disable property string editor for disabled properties
Summary: disable property string editor for disabled properties
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P3 enhancement (vote)
Assignee: akemr
URL:
Keywords:
Depends on:
Blocks: 15100
  Show dependency tree
 
Reported: 2001-01-24 17:29 UTC by Jan Benway
Modified: 2008-12-22 16:39 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Benway 2001-01-24 17:29:22 UTC
If you click the "..." button for a disabled property with a string value, you
get an editor which allows you to make changes. However, once you ok those
changes, they are ignored.

It's nice that the user can open this editor because it makes an easy way to
view long strings without having the expand the properties window, but allowing
the user to edit and then ignoring these changes is misleading.

The basic string editor for all such properties in the IDE should be passed the
"uneditable" state, and should not allow editing.
Comment 1 Daniel Pfeffer 2001-04-06 10:37:58 UTC
The problem was fixed for String editor.
In general this problem is hard to solve as this feature is not supported
in Java Beans specification. Using NetBeans extensions it is possible to solve 
it for other NetBeans based custom property editors (using ExPropertyEditor...).
To harmonize this functionality within whole IDE, this changes should be done 
also for all modules, which introduce new custom property editors (if not 
working this way yet).
In case of further problems issue request for enhancement please.

Comment 2 Rochelle Raccah 2001-04-11 01:08:20 UTC
I would like to see the text area in the popup have a gray background instead of
a white one.
Comment 3 Rochelle Raccah 2001-05-25 23:21:00 UTC
My comment about gray vs. white still needs to be addressed.
Comment 4 David Strupl 2001-06-21 14:47:57 UTC
I have added this (to StringCustomEditor):

textArea.setEnabled(editor.isEditable());

It makes the area disabled --- I hope that LookAndFeel takes care of colors.
Probably wouldn't be wise to fiddle with colors directly.
Marking as fixed. If you have better idea please propose another solution.
Thanks for your comments.
Comment 5 Rochelle Raccah 2001-06-21 16:49:07 UTC
I think you should use setEditable instead of setEnabled otherwise I think
copy/paste won't work.
Comment 6 David Strupl 2001-06-21 17:13:28 UTC
SetEditable was there before and you didn't like it. So a added setEnabled
(right after setEditable).
Comment 7 Rochelle Raccah 2001-06-21 17:16:49 UTC
Sorry.  I guess the goal is: disabled text color + copy/paste support. Why don't
you check for the correct behavior on nbui?
Comment 8 Jan Zajicek 2001-06-22 13:46:41 UTC
New behaviour is adequate to me. If you think so, please mark this as verified,
thanks.
Comment 9 Jan Benway 2001-06-22 17:09:43 UTC
I agree that the goal here should be that the background color should indicate
that it is disabled, but we need to allow copy/paste. I confirmed with Dirk Ruiz
about how this should work.

We need to get rid of the setEnable call so that text can be copied. As for the
background color, it should be set to the window background color. This will
make it gray in most cases, but will respond to the L&F settings if window
backgrounds are some other color.
Comment 10 Martin Entlicher 2001-09-07 10:00:46 UTC
This seems to me more like a bug, then an enhancement. It disables
some functionality. In VCS there are many RO properties, that contain
valuable information. I would like to see it fixed in 3.3.

IMHO the TextArea should not be disabled, to allow copy, setEditable
should be enough. Just the color can be changed if it's needed to
emphasise, that it can not be changed (I agree with Jan Benway at this
point).
Comment 11 Martin Entlicher 2001-09-07 10:03:40 UTC
Changing to DEFECT, since it's a defect in functionality.
Comment 12 _ mruflin 2001-09-07 10:06:09 UTC
Background Color is ok.
Just the text color should be changed from black to gray,
that's all.
Comment 13 _ mruflin 2001-09-07 12:02:58 UTC
Fixed.
Comment 14 David Strupl 2001-09-10 17:34:26 UTC
*** Issue 15135 has been marked as a duplicate of this issue. ***
Comment 15 Lukas Hasik 2001-10-25 16:23:16 UTC
no more comments ?
marking as verified. I hope that you all will agree ;)
Comment 16 Jan Benway 2001-10-26 23:15:27 UTC
The colors still aren't right. The background should be gray and the text should be 
black. Right now, the background is white and the text is gray. When you select text, 
then it turns black.
Comment 17 Peter Zavadsky 2001-10-30 14:29:46 UTC
Jan, I'm closing this issue.

Seems that default colors for disabled textArea are white background and 
gray foreground, so I think it should follow the defaults.

If you don't agree, please let discuss the problem at [nbui] so we get
what audience wants.
Comment 18 Jan Benway 2001-11-17 00:53:23 UTC
Nbui discussion took place on this thread:

http://www.netbeans.org/servlets/ReadMsg?msgId=181371&listName=nbui

Consensus was that people thought that the colors should be changed.
There were no objections to my proposal to use textfield colors for
this.

I posted a summary/last call message on Nov 12th, but it seems to be
missing from the archives. Here is what it said:

I'd like to try to wrap up this thread, which started with this
message:

http://www.netbeans.org/servlets/ReadMsg?msgId=181371&listName=nbui

The proposal is to make the text areas in disabled string editors
appear
the same as disabled text fields (typically gray background with black
text).

In the discussion on this topic, there was general agreement that the
current colors were not acceptable. There were a number of alternative
solutions suggested, but I didn't hear any disagreement on the
proposal.

Therefore, I propose that we go ahead and change the colors for this
text area to match those of text fields.

Any further discussion?

If there are no objections by Wednesday, I will update the bug with
this
solution.

Thanks,

Jan Benway
HIE
Comment 19 David Strupl 2001-11-19 13:49:30 UTC
Jan,
I would love to have this bug fixed. But I have no idea what you mean
by "the same as disabled text fields". Your "typically ..." is not
very helpfull since those values can vary significantly across L&Fs.
Moreover (and please correct me if I am wrong) in Metal Look and Feel
the colors for disabled textfields are exactly the same as the colors
used in the custom panel now.Please reopen and state what colors
should be there (please don't send in any RGB but rather entries in
swing palette from the colors dialog or at leat any place in the IDE
where those are used). Don't you by chance know a UI engineer who
would like to volunteer on this issue? It would be better if someone
who closely watch the nbui list would do such changes.
The change should be extremely easy in
org.netbeans.beaninfo.editors.StringCustomEditor.
Thanks.
Comment 20 David Strupl 2001-11-20 14:22:33 UTC
x
Comment 21 David Strupl 2001-11-20 14:30:23 UTC
Jano is working on accesibility in the
org.netbeans.beaninfo.editors package - so assigning to him.
It is in StringCustomEditor.
Comment 22 Jan Chalupa 2001-11-27 11:50:51 UTC
Target milestone -> 3.3.1.
Comment 23 Jan Chalupa 2001-11-27 11:54:26 UTC
Target milestone -> 3.3.1.
Comment 24 Jan Chalupa 2002-01-11 14:04:36 UTC
Target milestone -> 3.4
Comment 25 Jan Chalupa 2002-01-11 14:08:27 UTC
Target milestone -> 3.4
Comment 26 Jan Chalupa 2002-01-11 14:09:22 UTC
Target milestone -> 3.4
Comment 27 Jan Chalupa 2002-01-11 14:11:56 UTC
Target milestone -> 3.4
Comment 28 Jiri Rechtacek 2002-05-23 17:56:54 UTC
It's an editor issue I reassing to Ales.
Comment 29 Jiri Rechtacek 2002-05-24 09:02:43 UTC
It's an editor issue I reassing to Ales.
Comment 30 akemr 2002-05-24 12:26:31 UTC
Fixed in trunk.

BTW: I also don't aggree with such ugly workarounds.. JTextArea is not
JTextField, so why it should behave like it?
Comment 31 Marian Mirilovic 2002-05-31 13:50:19 UTC
verified in [nb_dev](20020531)
Comment 32 Quality Engineering 2003-07-01 16:49:27 UTC
Resolved for 3.4.x or earlier, no new info since then -> closing.