This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
We have one breakpoint type already implemented - BPEL Activity Breakpoint, and want to add a new breakpoint type in gavotte - BPEL Fault Breakpoint. The required icons are to be used in the Breakpoints View - please see the attachment "BreakpointsView.png" for the view populated with Java breakpoints. For the Activity Breakpoint we use two icons taken from Java Line Breakpoint type (see attachments), but it doesn't seem to be appropriate. Those two icons are for enabled breakpoint (breakpoint.gif) and for disabled one (disabledbreakpoint.gif). We also would like to have an icon for the enabled breakpoint with the current position on it (something similar to "breakpoint+pc.gif") and the icon for broken breakpoint - when the activity for which the breakpoint is set was removed or bpel file is broken (maybe crossed breakpoint icon?). For the new BPEL Fault Breakpoint we need two icons - for enabled breakpoint and for disabled one. Two other icons described for Activity Breakpoint are not applicable for the Fault Breakpoint type.
Created attachment 36907 [details] Breakpoints View with Java Breakpoints
Created attachment 36908 [details] current icon for enabled BPEL Activity Breakpoint
Created attachment 36909 [details] current icon for disabled BPEL Activity Breakpoint
Created attachment 36910 [details] icon for Java Line Breakpoint with the current position pointer on it
The format for the icons could be either gif or png
Alexander, can we share the same icons with Java space? Are you able to get them? As for the BPEL Fault Breakpoint, would it make sense to use the "exception breakpoint" icon from Java space? If so, then we only need an icon for an activity that does not exist anymore (i.e. an invalid breakpoint). Is there anything like that in Java? I didn't manage to get to such a situation (breakpoints seem to jump to different lines, when deleted ...) If not, what is the BPEL story? Can an invalid breakpoint become valid again? And how do I actually get one? Is this the state where there is an activity on the client that does not exist on the server?
Jirka, I thought we would need our own icons for BPEL breakpoints rather than using Java ones bacause all the breakpoints are displayed together in the Breakpoints View and if have the same icons it's difficult to distinguish Java Breakpoints from BPEL ones. You would need to read through the source file name. But if you think it's appropriate to use the icons from Java world, it's OK for me - I can get those icons both for Activity Breakpont and for Fault Breakpoint (btw, in Java they are using the same icon for all the breakpoints that are not Line Breakpoints). About broken breakponts.. It's purely the client issue, doesn't have anything to do with the client and server sources synchronization (but you are right, there is such problem, but it's another story). You can reproduce the "broken breakpoints" behaivor if you do the following: -create SimpleAppProject -put a breakpoint on the assign activity -add new sequence activity to the main sequence -go to source view and cut'n'paste the assign activity from the main sequence to the new one. You'll see that the breakpoint is disappeared from the diagram and from the sources view, but it's still there in the Breakpoints View - with a "(broken)" state. It's supposed to be possible for a "broken" breakpoint to become "alive" agian, but currently it never happens (it is a known bug). Although, I'm not that sure we should show those "broken" breakpoints in the Breakpoints View. To be honest, right now I think we better not.
Re: Different icons for BPEL If we had different icons for BPEL, that we should probably have different icons for JSPs, JavaScript, maybe JRuby ... which is not the case so far. So let's use Java icons. Re: Broken breakpoint If broken breakpoint is not of any use then we should not show it. But help me to understand - when exactly could it be of any use? I assume that Cut & Paste does not need to keep the breakpoint. I also assume that relocating an activity should keep the breakpoint ... But then -- what are really the cases when one may need deal with broken breakpoint? Is it always when you do changes in source, which are incompatible with your breakpoints? It is the case that you actually delete an activity with breakpoint in source? If so, just remove the breakpoint (on tab switches) (i.e. such broken breakpoint should never become active again.
I agree with your points about different icons for BPEL. About "broken breakpoint" - let's get to it a little bit later, ok? For now it looks like you can close this issue either as FIXED or as INVALID..
Cool, Just - will you use the icons that are on the screenshot (the nice ones), or those that you attached in separate attachments (those ugly ones)? I assume we prefer the nice ones.
Difficult question... Can't answer right now...
Ok, I think you have all info you need from me. Reassigning this to you ... reassign to me, if you disagree ;-)
Fixed. The bottom line: for BPEL breakpoints we are using standard NB icons for breakpoints. Specifically, for BPEL Element Breakpoint we use the same icon which is used for Line Breakponts, for BPEL Fault Breakpoint we use the "default" icon (red triagle).
standard netbeans breakpoint icons are used for BPEL Debugger