This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 90588 - BPEL validation needs to invoke default xml validator for malformed WSDL/XSD
Summary: BPEL validation needs to invoke default xml validator for malformed WSDL/XSD
Status: VERIFIED FIXED
Alias: None
Product: soa
Classification: Unclassified
Component: BPEL Validation (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Denis Anisimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-05 13:30 UTC by Michael Frisino
Modified: 2007-02-13 16:18 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Frisino 2006-12-05 13:30:13 UTC
Steps to reproduce:

Create new SynchronousSample.
Run validation on SynchronousSample bpel process. It should be successful.
Open the SynchronousSample.wsdl file
make this file malformed - i.e. remove the last character in the file.
change:
</definitions>
to 
</definitions

This will make the wsdl file malformed. If you run the WSDL validation explictly
from the WSDL editor you will be told - correctly:

C:/Documents and
Settings/Mike/SynchronousSample41/SynchronousSample41/src/SynchronousSample.wsdl:44,1
XML document structures must start and end within the same entity.

Now, go back to the SynchronousSample.bpel editor.
Run the Validate XML action in the BPEL Design view (or source view )

The BPEL validator will report that there are 10 errors in the BPEL file.
However, it does not report ANY problem with the WSDL file. 
This is incorrect.  It should report the same thing that the explicit validation
action on WSDL editor reported.

------------------

I believe this is just an oversight in our BPEL validation logic. We do have
special logic in BPEL validation that determines if the BPEL file is malformed.
If it is malformed, then the BPEL validation will pass the XML validation
sub-system the BPEL file instead of the BPEL object model That logic assures
that a malformed BPEL file is properly validated by XML validation routine.

Basically, the BPEL validation subsystem needs to add similar conditional logic
to handle cases where the upstream artifacts - WSDL and Schema are malformed. In
such cases we need to pass file not OM to xml validation. 

I assume this is responsibility of BPEL validation system. If it is not BPEL
responsibility then we must re-assign this bug to WSDL or XSD team.
Comment 1 Sergey Lunegov 2007-02-06 08:56:16 UTC
Denis, was is the status of this issue ? Was it fixed as part of other
validation issues ?
Comment 2 Denis Anisimov 2007-02-06 09:59:50 UTC
No, is it need to be fixed with this priority ?
Comment 3 Sergey Lunegov 2007-02-06 10:11:20 UTC
I think yes. You've implemented 89685: "Better Validation for changes in
upstream artifacts" and 86274 "BPEL file needs to be reopen in designer to
reflect WSDL changes". And this particular issue looks very close to above.
Let's keep priority as P2.
Comment 4 Denis Anisimov 2007-02-06 11:51:36 UTC
This is fixed.
Please note : described scenario in original description still doesn't work.
BUT this is separate WSDL validation system issue.
WSDL doesn't perform validation against schema in the case broken XML.

This problem should be filed as separate issue on WSDL validation system.

I mark this issue as fixed.
Comment 5 Michael Frisino 2007-02-13 16:18:21 UTC
verified