This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 90144 - [Study][DB-11] Line breakpoint is not in the New Breakpoint dialog
Summary: [Study][DB-11] Line breakpoint is not in the New Breakpoint dialog
Status: CLOSED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Daniel Prusa
URL: http://ui.netbeans.org/usability/debu...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-28 09:03 UTC by jrojcek
Modified: 2010-04-29 09:31 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jrojcek 2006-11-28 09:03:53 UTC
Finding	
One participant wanted to define conditional breakpoint the New Breakpoint dialog. He didn't know how 
he was supposed to add a line breakpoint first and then modify it's properties. He went directly to "New 
Breakpoint" dialog and expected he can setup everything there.
Another participant also used the New Breakpoint dialog. He added "Method" breakpoint.

Severity	
Two participants expected such behavior. For completeness, it seems correct to show all breakpoint 
types in the New Breakpoint dialogs even though the line breakpoint would most likely by used with 
toggle action.

Recommendation	
Add "Line" breakpoints into the New Breakpoint dialog.
Comment 1 Martin Entlicher 2007-01-11 09:50:39 UTC
I'm not sure yet whether this was intentional or not. There is Toggle Breakpoint
action for line breakpoints. Perhaps the names are not the best...
Comment 2 Roman Ondruska 2007-07-03 14:49:25 UTC
I am not sure whether this is a good idea. From the usability point of view, it is really annoying to add line
breakpoints via dialog requesting a line number, it is definitely an obsolete approach. If we offer such way, it may
seem (to newbies) that there is no other way. AFAIK it is also not possible e.g. in Eclipse. 

We changed menu item 'Toggle Breakpoint' to 'Toggle Line Breakpoint' (this item is menu predecessor of general 'New
Breakpoint...'), so it should be much more intuitive how to add line breakpoints via main menu now.

Perhaps, we should be consistent with C/C++ debugger where it is possible to add line bkpt via dialog. Question is where
the change should be done.

For NB 6, the 'Toggle Line Breakpoint' should be an acceptable solution IMHO. We can discuss other ways for next NB
release. Until we have a clear clarification what the best solution is, marking as incomplete.
Comment 3 jrojcek 2007-07-09 16:55:28 UTC
Maybe participants wanted to use the dialog just because they wanted to see all the options associated with line breakpoints. Things like stop at certain 
number of hits, etc. For completeness, it should be there.
Comment 4 Petr Cyhelsky 2008-07-09 18:05:44 UTC
Because this issue seems to be solved by placing Toggle line breakpoint item just before the New breakpoint item in Run
menu and there is no activity or other suggestions concerning adding of line breakpoint option to the new breakpoint
dialog, I'm setting this issue to resolved fixed. Feel free to reopen the issue in case of further suggestions.
Comment 5 jrojcek 2008-07-10 13:14:17 UTC
Using the New Breakpoint dialog for setting conditional line breakpoints is an obvious choice. If it's not there, the user has to toggle line breakpoint and then right-click on 
it and modify its properties. Using the New Breakpoint dialog which automatically sets the line numbers and other properties seems like the clear solution to me.

Also, today I tried setting a new breakpoint and the dialog offered me to use "PHP" debugger even though I had a Java class open. Something seems to broken there.
Comment 6 Petr Cyhelsky 2008-07-10 13:33:01 UTC
Ok, seems reasonable. Btw. the PHP thing is covered in Issue #138779 so please vote for it :).
Comment 7 Daniel Prusa 2009-05-05 15:42:50 UTC
Fixed.
http://hg.netbeans.org/main/rev/dced783d8a78
Comment 8 Quality Engineering 2009-05-07 07:46:25 UTC
Integrated into 'main-golden', will be available in build *200905070201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/dced783d8a78
User: Daniel Prusa <dprusa@netbeans.org>
Log: #90144: [Study][DB-11] Line breakpoint is not in the New Breakpoint dialog
Comment 9 Quality Engineering 2010-04-29 09:31:10 UTC
Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.