This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I listen on modifier property change events and have a confirmation dialog for certain cases. When the modifier of a class is changed using the property editor (... from the property sheet) and abstract is checked on, my confirmation dialog comes up immediately - before the ok button on the property editor is chosen. Svata points out that this is fine for the customizer, but I am seeing this behavior from the property editor.
Property editors for modifiers, method parameters and implemented interfaces were changed, so that they did not fire their property change events and wait for OK button. Proposed patch will be attached in the next comment.
Created attachment 495 [details] proposed patch
Fixed
[010220_1] Verified
[dev-212] Regression
Is the regression in 3.2.1/Pilsen builds or 3.3/Trunk or both?
3.3 only
Sorry. I don't understand why it was reopened. Making invalid for now. I have fixed the property panel (PropertyPanel 1.27) to fire the changes. If you encounter the problem with current version of PropertyPanel please reopen and add more info (steps to reproduce etc.). Thanks for your help.
[dev-200106210100] Well, steps to reproduce: 1. Select field in Explorer and in Properties Window click [...] to change field's modifiers. -> Property Editor is invoked. 2. Check e.g. static check box -> "static" modifier appears before the field, although OK button was not pushed. 3. Push Cancel button -> "static" modifier remains in code.
Tomas, you didn't apply your proposed patch. See: http://www.netbeans.org/unbranded-source/browse/openide/src/org/openide/explorer/propertysheet/editors/ModifierEditor.java.diff?r1=1.7&r2=1.8 reassigning back.
Assigning back to David. :-))
*** Issue 13070 has been marked as a duplicate of this issue. ***
Seems to work. Many cruel things happened to the property sheet impl meanwhile.
[200109190100] Reopening, see my steps to reproduce (comment from 2001-06-21 04:46)
Now you can make the property editor without firing (waiting for the Ok button to be pressed). It can be achieved by supplying custom property named "changeImmediate" (with boolean value). For how to pass the custom parameter please check explorer documentation (or ask me directly).
fixed in trunk
[200110030100] Verified
Resolved for 3.4.x or earlier, no new info since then -> closing.