This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 88272 - Keyboard selection useless if FU window is in autoslide mode, and missing icon
Summary: Keyboard selection useless if FU window is in autoslide mode, and missing icon
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@java
URL:
Keywords: A11Y, REGRESSION
Depends on:
Blocks: 48371 51986
  Show dependency tree
 
Reported: 2006-10-30 18:42 UTC by Jesse Glick
Modified: 2007-08-07 16:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2006-10-30 18:42:25 UTC
Did you pick up an old version of the Find Usages window code for Retouche?
Lacks various fixes that were made during Javamodel times:

- no C-A-F accelerator for Window > Find Usages

- selecting the menu item from the keyboard when FU window is in autoslide mode
is useless, as it immediately closes itself again and jumps into editor

- no window icon (can't remember if Javamodel had it)
Comment 1 Jan Becicka 2006-11-01 13:13:39 UTC
Yes, I did.

Checking in api/resources/layer.xml;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/resources/layer.xml,v
 <--  layer.xml
new revision: 1.4; previous revision: 1.3
done
Checking in spi/impl/FindUsagesOpenAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/FindUsagesOpenAction.java,v
 <--  FindUsagesOpenAction.java
new revision: 1.3; previous revision: 1.2
done
Comment 2 Jesse Glick 2006-11-08 19:34:39 UTC
Not sure what exactly you fixed, but all three problems I listed are still
present in 061107.
Comment 3 Jan Becicka 2006-11-09 07:16:04 UTC
> no C-A-F accelerator for Window > Find Usages

There is no such action nor accelerator. There is Edit | Find Usages (Alt-F7)
and there is Window | Find Usages Result (A-S-U)

> selecting the menu item from the keyboard when FU window is in autoslide mode
is useless, as it immediately closes itself again and jumps into editor

Probably yes, but it is not a regression.

> no window icon (can't remember if Javamodel had it)
No output window has icon. I assigned icon to Window | Find Usages Result action.
Comment 4 Jesse Glick 2006-11-09 19:49:20 UTC
Re. accelerator: it seems that in 5.5 there is *both* C-A-F and A-S-U (for some
reason); only the latter is marked in the menu item. In 061109 neither work, and
nothing is marked as an accelerator in the menu item. So this is a regression.
See issue #51986.

Re. focus - it is true that it is not a regression that selecting the menu item
via mnemonics closes the window; this is also broken in 5.5. However in 5.5 the
accelerators A-S-U or C-A-F behave correctly, leaving the FU window open with
focus, while in dev builds there is no way to open and focus this window using
the KB at all.

Re. icon - the FU window had an icon in 5.5, matching the menu item, while in
061109 it has none, so this is also a regression, of #48371. BTW all the other
output windows (distinct from output *tabs*) have icons: Output, Search Results,
Versioning, JUnit Test Results; only Usages is missing an icon.
Comment 5 Jesse Glick 2007-04-12 23:55:03 UTC
Still broken in dev builds.
Comment 6 Jan Becicka 2007-08-07 16:44:35 UTC
Checking in api/resources/layer.xml;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/api/resources/layer.xml,v  <--  layer.xml
new revision: 1.19; previous revision: 1.18
done
Checking in spi/impl/RefactoringPreviewOpenAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/RefactoringPreviewOpenAction.java,v  <-- 
RefactoringPreviewOpenAction.java
new revision: 1.3; previous revision: 1.2
done
Checking in spi/impl/FindUsagesOpenAction.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/FindUsagesOpenAction.java,v  <-- 
FindUsagesOpenAction.java
new revision: 1.4; previous revision: 1.3
done
Checking in spi/impl/RefactoringPanelContainer.java;
/cvs/refactoring/api/src/org/netbeans/modules/refactoring/spi/impl/RefactoringPanelContainer.java,v  <-- 
RefactoringPanelContainer.java
new revision: 1.4; previous revision: 1.3
done