This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Create web application in index jsp type <jsp:useBean>| press Ctrl+Space end tag </jsp:usebean> is completed, but be </jsp:useBean> should added, because otherwise "jsp end tag unbalanced error" is caused by this code.
Let's fix in release55. Patch will be attached...
Created attachment 35261 [details] netbeans/enterprise3/modules/org-netbeans-modules-web-core-syntax.jar
Created attachment 35262 [details] netbeans/ide7/modules/org-netbeans-modules-html-editor-lib.jar
Sorry, the modules contains unneeded dependencties, I'll attach clean ones.
Created attachment 35265 [details] netbeans/ide7/modules/org-netbeans-modules-html-editor-lib.jar
Created attachment 35266 [details] netbeans/enterprise3/modules/org-netbeans-modules-web-core-syntax.jar
I verified the fix with patched modules in NB 5.5 FCS candidate.
Created attachment 35268 [details] The patch
Tomasz and Petr, please review the fix asap. Thanks!
fixed in release55_dev ... use it instead of the diff. Checking in html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java; /cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v <-- HTMLCompletionQuery.java new revision: 1.11.8.3.2.12.2.1; previous revision: 1.11.8.3.2.12 done Checking in web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java,v <-- JspSyntaxSupport.java new revision: 1.67.4.4.2.5.2.1; previous revision: 1.67.4.4.2.5 done
Ok, I agree with the commiting this fix to the release55 branch.
I am looking at the steps to reproduce again and I see that this is only reproducible when the caret is right after the opening tag. In other situations it is not reproducible: 1/ <jsp:useBean> | 2/ <jsp:useBean> some text | 3/ <jsp:useBean></| What are all the situations when this will happen and how common are they?
The solution looks acceptable as a quick fix
This really appears only at situation of autocompletion - not in more common situation of adding end tag in code, but it appears quite offten because end tag autocompletion is invoked automatically after typing ">" at the end of opening tag, so it invites user to use it. The only situation should be the one deskribed in steps. It can happen for all the taglibs used in JSP that have big cases in tag names(for ex. JSF)
fixed in release55 Checking in html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java; /cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v <-- HTMLCompletionQuery.java new revision: 1.11.8.3.2.13; previous revision: 1.11.8.3.2.12 done Checking in web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java,v <-- JspSyntaxSupport.java new revision: 1.67.4.4.2.6; previous revision: 1.67.4.4.2.5 done
Don't forget to merge the fix in release55u1 branch that is intended for Sun Studio development. Thanks Petr
fixed in release55_mars Checking in release55/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java; /cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v <-- HTMLCompletionQuery.java new revision: 1.11.8.3.2.12.6.1; previous revision: 1.11.8.3.2.12 done Checking in release55_dev/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java,v <-- JspSyntaxSupport.java new revision: 1.67.4.4.2.5.6.1; previous revision: 1.67.4.4.2.5 done
Verified in NB 5.5 FCS build 200610171010
fixed in trunk Checking in html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java; /cvs/html/editor/lib/src/org/netbeans/editor/ext/html/HTMLCompletionQuery.java,v <-- HTMLCompletionQuery.java new revision: 1.32; previous revision: 1.31 done Checking in web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/syntax/JspSyntaxSupport.java,v <-- JspSyntaxSupport.java new revision: 1.85; previous revision: 1.84 done