This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 86510 - TCR: Backport lexer to be usable with release55 branch
Summary: TCR: Backport lexer to be usable with release55 branch
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Lexer (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker with 1 vote (vote)
Assignee: issues@editor
URL:
Keywords:
Depends on:
Blocks: 51437
  Show dependency tree
 
Reported: 2006-10-04 19:27 UTC by Miloslav Metelka
Modified: 2007-07-19 10:19 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Patch to allow calculator example to work on the branch (2.69 KB, application/octet-stream)
2006-10-26 07:03 UTC, _ briansmith
Details
Patch to allow calculator example to work on the branch (2.69 KB, patch)
2006-10-26 07:04 UTC, _ briansmith
Details | Diff
Commit cvs output (17.08 KB, text/plain)
2006-10-26 21:50 UTC, Miloslav Metelka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miloslav Metelka 2006-10-04 19:27:38 UTC
It is necessary to be able to use the lexer module with the original editor/util
module so some new classes from it will have to be copied into the lexer directly.
The necessary modules:
lexer
lexer/editorbridge
lexer/nbbridge
appropriate lexers: e.g. java/lexer or html/lexer (not created yet)

Priority set to P3 as it's not directly related to the review.
Comment 1 Jaroslav Tulach 2006-10-11 07:36:38 UTC
TCR cannot be P3.
Comment 2 Jaroslav Tulach 2006-10-11 07:43:32 UTC
I've created a branch backportto55_86510 in lexer module which is rooted at 
backportto55_86510_root

I've made the lexer API compilable against release55 branch. All tests but one 
are passing, so the backport was more or less successful for the API. Help 
with finding  what I did wrong with the one test is welcomed.
Comment 3 _ briansmith 2006-10-26 07:02:53 UTC
If possible, could the backportto55_86510 branch be updated and kept up to date?
Would it help if I attached patches to do this?

I will attach a patch to the calc example which makes it work correctly (on the
branch). I believe that at least the layer.xml part needs to be applied to the
trunk as well.
Comment 4 _ briansmith 2006-10-26 07:03:44 UTC
Created attachment 35557 [details]
Patch to allow calculator example to work on the branch
Comment 5 _ briansmith 2006-10-26 07:04:02 UTC
Created attachment 35558 [details]
Patch to allow calculator example to work on the branch
Comment 6 Miloslav Metelka 2006-10-26 19:41:29 UTC
I would like to apply all the changes done in the trunk in the meantime till
begining of November. I have about three or four remaining changes that I
consider important and I would like to do them in the trunk before the
synchronization.
Comment 7 Miloslav Metelka 2006-10-26 21:50:19 UTC
Created attachment 35581 [details]
Commit cvs output
Comment 8 Miloslav Metelka 2006-10-26 21:53:04 UTC
Apologies for the attached commit.txt - it applies to another issue.
Comment 9 Miloslav Metelka 2007-03-10 22:58:04 UTC
I'm working on the backport:
- created tag backportto55_86510_20070309 on lexer's trunk and merged all
between it and backportto55_86510_root into backportto55_86510.
- fixed compilation errors and tests to compile
- corrected module version dependencies

I've checked the following modules:
lexer
lexer/nbbridge
lexer/editorbridge
lexer/editorbridge/calc

The lexer was already branched on release55 so I've first deleted release55 tag
by checking out lexer from release55 then
cvs tag -d release55
and then I re-created release55 branched based on backportto55_86510 by
cvs tag -r backportto55_86510 -b release55

All four modules now compile fine, I need to find out why the coloring does not
work yet, there might be possibly some problem related to LexerLayer.
Comment 10 Pavel Buzek 2007-07-18 17:30:26 UTC
Is this still needed now?
Comment 11 Vitezslav Stejskal 2007-07-19 10:19:31 UTC
Already fixed. AFAIK the backported lexer module is downloadable from some AUC. Not sure which one.