This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
In the files listed below there is used calling of method setMnemonic() or setDisplayedMnemonic(). Class org.openide.awt.Mnemonics should be used instead - see issue #67807. db\core\src\org\netbeans\modules\db\sql\execute\ui\ResultSetTableModel.java db\model\src\org\netbeans\modules\dbschema\jdbcimpl\wizard\DBSchemaTablesPanel.java db\model\src\org\netbeans\modules\dbschema\jdbcimpl\wizard\ProgressFrame.java db\sqleditor\src\org\netbeans\modules\db\sql\editor\ui\actions\ConnectionAction.java db\src\org\netbeans\modules\db\explorer\dataview\DataViewWindow.java db\src\org\netbeans\modules\db\explorer\dlg\AddDriverDialog.java db\src\org\netbeans\modules\db\explorer\dlg\AddIndexDialog.java db\src\org\netbeans\modules\db\explorer\dlg\AddTableColumnDialog.java db\src\org\netbeans\modules\db\explorer\dlg\AddViewDialog.java db\src\org\netbeans\modules\db\explorer\dlg\ConnectPanel.java db\src\org\netbeans\modules\db\explorer\dlg\CreateTableDialog.java db\src\org\netbeans\modules\db\explorer\dlg\LabeledTextFieldDialog.java db\src\org\netbeans\modules\db\explorer\dlg\NewConnectionPanel.java db\src\org\netbeans\modules\db\explorer\dlg\SchemaPanel.java
I can fix this but I can't test all the things so please verify my changes.
Checking in wizard/ProgressFrame.form; /shared/data/ccvs/repository/db/model/src/org/netbeans/modules/dbschema/jdbcimpl/wizard/ProgressFrame.form,v <-- ProgressFrame.form new revision: 1.3; previous revision: 1.2 done Checking in wizard/DBSchemaTablesPanel.form; /shared/data/ccvs/repository/db/model/src/org/netbeans/modules/dbschema/jdbcimpl/wizard/DBSchemaTablesPanel.form,v <-- DBSchemaTablesPanel.form new revision: 1.4; previous revision: 1.3 done Checking in wizard/DBSchemaTablesPanel.java; /shared/data/ccvs/repository/db/model/src/org/netbeans/modules/dbschema/jdbcimpl/wizard/DBSchemaTablesPanel.java,v <-- DBSchemaTablesPanel.java new revision: 1.8; previous revision: 1.7 done Checking in wizard/ProgressFrame.java; /shared/data/ccvs/repository/db/model/src/org/netbeans/modules/dbschema/jdbcimpl/wizard/ProgressFrame.java,v <-- ProgressFrame.java new revision: 1.5; previous revision: 1.4 done Checking in resources/Bundle.properties; /shared/data/ccvs/repository/db/model/src/org/netbeans/modules/dbschema/jdbcimpl/resources/Bundle.properties,v <-- Bundle.properties new revision: 1.7; previous revision: 1.6 done
Andrei, can you check? It looks to me that most of UI components works well but one place where I am not sure is DataViewWindow where text from button is maybe used for other purposes.
Created attachment 36709 [details] commit output
Thanks for working on this. I don't think DataViewWindows works correctly now, since it compares a string containing an ampersand (passed to Mnemonics.setLocalizedText()) with a string not containing one (returned by getText()). Hopefully fixed in DataViewWindow rev 1.49. A typo causes a NPE while adding a table column, fixed in /db/src/org/netbeans/modules/db/explorer/dlg/AddTableColumnDialog.java rev 1.39. What is the reason of the org.openide.awt.Mnemonics.setLocalizedText(progressMessageLabel, " "); call in SchemaPanel and AddDriverDialog? Just being prepared for a hypothetical progress message in the future?
Verified.
db-sql-visualeditor has keys using the 2 key/values - should this one be reopened or should a new issue be filed ? ken.frank@sun.com