85817 – JspParserImpl causes the web projects to leak

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 85817 - JspParserImpl causes the web projects to leak

Summary: JspParserImpl causes the web projects to leak

Status:	VERIFIED FIXED

Alias:	None

Product:	javaee
Classification:	Unclassified
Component:	JSP Parser (show other bugs)
Version:	5.x
Hardware:	All All

Importance:	P2 blocker (vote)
Assignee:	Tomas Mysik

URL:
Keywords:	PERFORMANCE

Duplicates (1):	125079 (view as bug list)
Depends on:
Blocks:	123530 70052
	Show dependency tree

Reported:	2006-09-26 18:36 UTC by Andrei Badea
Modified:	2008-09-16 15:29 UTC (History)
CC List:	4 users (show)

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrei Badea 2006-09-26 18:36:13 UTC

... because of the parseSupports HashMap. To reproduce just open a JSP file in
the editor and close the project -- it will never be garbage-collected.

Comment 1 Andrei Badea 2006-09-26 18:40:33 UTC

Fixed in release55_dev.

http://www.netbeans.org/source/browse/web/jspparser/extsrc/org/netbeans/modules/web/jspparser_ext/WebAppParseSupport.java?r1=1.1.12.1.2.7.2.1&r2=1.1.12.1.2.7.2.2
http://www.netbeans.org/source/browse/web/jspparser/src/org/netbeans/modules/web/jspparser/JspParserImpl.java?r1=1.27.12.2.2.3&r2=1.27.12.2.2.3.14.1
http://www.netbeans.org/source/browse/web/jspparser/src/org/netbeans/modules/web/jspparser/ParserServletContext.java?r1=1.6.128.2&r2=1.6.128.2.14.1

Comment 2 Andrei Badea 2006-09-26 23:10:25 UTC

Removing forgotten debugging code.

http://www.netbeans.org/source/browse/web/jspparser/src/org/netbeans/modules/web/jspparser/JspParserImpl.java?r1=1.27.12.2.2.3.14.1&r2=1.27.12.2.2.3.14.2

Comment 3 Andrei Badea 2006-09-27 11:20:27 UTC

Removing previous fix. Both WebAppParseSupport instances and
JspParserAPI.WebModule implementations were not held strongly and could be GCd
at any time.

http://www.netbeans.org/source/browse/web/jspparser/extsrc/org/netbeans/modules/web/jspparser_ext/WebAppParseSupport.java?r1=1.1.12.1.2.7.2.2&r2=1.1.12.1.2.7.2.3
http://www.netbeans.org/source/browse/web/jspparser/src/org/netbeans/modules/web/jspparser/JspParserImpl.java?r1=1.27.12.2.2.3.14.2&r2=1.27.12.2.2.3.14.3
http://www.netbeans.org/source/browse/web/jspparser/src/org/netbeans/modules/web/jspparser/ParserServletContext.java?r1=1.6.128.2.14.1&r2=1.6.128.2.14.2

Comment 4 Petr Blaha 2006-09-29 09:25:04 UTC

Can anybody verify this fix?

Comment 5 Jan Horvath 2006-09-29 13:21:41 UTC

is it possible to mark this issue as invalid?

Comment 6 Petr Jiricka 2006-10-02 11:05:11 UTC

This is not invalid, this is still an issue, but downgrading to P3 per team
agreement.

Comment 7 Andrei Badea 2006-10-02 11:40:26 UTC

Reassigning to subcomponent owner.

Comment 8 David Konecny 2007-10-10 14:18:14 UTC

Regardless of priority of this issue we should try to do something with it ASAP as it has all sorts of side effects
because it prevents closed project(s) from being GCed.

Comment 9 Tomas Mysik 2008-01-24 17:25:35 UTC

*** Issue 125079 has been marked as a duplicate of this issue. ***

Comment 10 Tomas Mysik 2008-02-26 14:56:22 UTC

Fixed.

changeset:   69670:447f86f2156b
user:        Tomas Mysik <tmysik@netbeans.org>
date:        Tue Feb 26 14:55:07 2008 +0100
summary:     #85817: JspParserImpl causes the web projects to leak

Comment 11 josin 2008-09-16 15:29:44 UTC

Seems to works ok. Changing to verified.