This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 84632 - Customized refactoring from WSDL/Schema not working properly
Summary: Customized refactoring from WSDL/Schema not working properly
Status: VERIFIED FIXED
Alias: None
Product: soa
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Vladimir Yaroslavskiy
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2006-09-11 17:48 UTC by Andrey Yamkovoy
Modified: 2006-10-16 13:28 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
proposed patch to bpel refactoring engine (1.03 KB, patch)
2006-09-14 05:39 UTC, Nam Nguyen 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Yamkovoy 2006-09-11 17:48:42 UTC 
Customized (rename only subset) refactoring from WSDL/Schama always renames all 
found strings.

Steps to reproduce:
- Create Synchronous sample project.
- Open xsd file in 'Schema' mode.
- Select Complex Types > simpleProcess > sequence > paramA.
- Invoke popup menu item 'Refactor > Rename...'.
- In appeared 'Rename' dialog enter some new name and press 'Next' button.
- Window 'XML refactoring' opens.
- Notice that there are found 2 places in bpel code for rename.
- Uncheck the checkbox for 1st of them.
- Press 'Do Refactoring' button.
- Open bpel source and noticeed that all 'paramA' strings were renamed.
Comment 1 Vladimir Yaroslavskiy 2006-09-12 11:02:15 UTC 
The problem is that refactoring engine requests to do renaming in all cases
whether check box is set or not. The same situation with wsdl file: add message
and set element from xsd to its part, do rename for the element, uncheck check
box, do refactoing, open wsdl file: part has renamed element.

Refactoring engine should process state of check boxes correctly.
Comment 2 Nam Nguyen 2006-09-14 02:15:09 UTC 
Fixed.  Cleaned up CheckNode constructors and their usages.

/cvs/xml/refactoring/src/org/netbeans/modules/xml/refactoring/ui/j/ui/Attic/CheckNode.java,v
 <--  CheckNode.java
new revision: 1.1.2.5; previous revision: 1.1.2.4
/cvs/xml/refactoring/src/org/netbeans/modules/xml/refactoring/ui/readers/Attic/WhereUsedReader.java,v
 <--  WhereUsedReader.java
new revision: 1.1.2.16; previous revision: 1.1.2.15
Comment 3 Nam Nguyen 2006-09-14 05:38:02 UTC 
The checkbox fix to persist user selection has been integrate, however the test
case still fail due to further change in bpel refactoring engine.  See attached
patch.  Reassig to bpel/refactoring.

Note that keyword REGRESSION is very dubious.  Base on the needed fixes (both in
refactoring checkbox UI and bpel refactoring engine, I doubt that this ever work
before even for xsd or wsdl usage components.
Comment 4 Nam Nguyen 2006-09-14 05:39:22 UTC 
Created attachment 33925 [details]
proposed patch to bpel refactoring engine
Comment 5 Vladimir Yaroslavskiy 2006-09-14 10:48:25 UTC 
fixed.
Comment 6 Andrey Yamkovoy 2006-09-21 11:35:47 UTC 
fixed
Comment 7 Mikhail Kondratyev 2006-10-05 12:15:17 UTC 
Could reproduce the issue with  build from 2006.10.04 with steps from description
Reopening the issue
Comment 8 Vladimir Yaroslavskiy 2006-10-05 13:09:08 UTC 
Fixed in both branches.
Comment 9 Andrey Yamkovoy 2006-10-16 13:28:29 UTC 
fixed