This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 84484 - Missing persistence unit warning doesn't match spec
Summary: Missing persistence unit warning doesn't match spec
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Persistence (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Andrei Badea
URL:
Keywords:
: 122824 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-08 00:43 UTC by Rochelle Raccah
Modified: 2008-07-25 23:22 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Screenshot (26.39 KB, image/png)
2006-09-08 12:01 UTC, Andrei Badea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rochelle Raccah 2006-09-08 00:43:22 UTC
This is in the entity from db wizard, but the others (jsf from entity, entity)
should be checked as well.

The spec <http://j2ee.netbeans.org/docs/promog/persistence-ui-spec.html> says
the warning should have a warning icon.  The warning used to show in the wizard
status area but was moved to a separate location to confirm to the spec.  Now
the color of the warning is black (not sure what it should be) and there is no
icon, so it doesn't draw the eye to the fact that it's a warning.
Comment 1 Andrei Badea 2006-09-08 12:01:27 UTC
Do I understand correctly that the wizard should look like in the attached
screenshot, that is, it is not a problem that two icons can be displayed at the
same time?
Comment 2 Andrei Badea 2006-09-08 12:01:49 UTC
Created attachment 33716 [details]
Screenshot
Comment 3 Rochelle Raccah 2006-09-08 21:48:54 UTC
I think it's for Jano to answer, but I'd like him to answer these as well:
- what should text color be?
- should the same change be made to the other wizards as well?
Comment 4 Andrei Badea 2006-09-13 14:05:54 UTC
Jano, could you please comment?
Comment 5 jrojcek 2006-10-09 16:09:57 UTC
> it is not a problem that two icons can be displayed at the 
> same time?

It is okay. The regular error area is used for errors and warning related to user input in the wizard 
fields. The persistence warning is a special case.

> what should text color be?

I think it is okay to use standard description text color (black).

> should the same change be made to the other wizards as well?

Yes. Lets use icon in all wizards and standard description text color (black on most L&Fs AFAIK).
Comment 6 Andrei Badea 2008-01-22 17:20:33 UTC
Fixed.

RCS file: /cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/warning.gif,v
done
Checking in src/org/netbeans/modules/j2ee/persistence/ui/resources/warning.gif;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/ui/resources/warning.gif,v  <--  warning.gif
initial revision: 1.1
done
Checking in src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizardDescriptor.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizardDescriptor.java,v  <-- 
EntityWizardDescriptor.java
new revision: 1.7; previous revision: 1.6
done
Checking in src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizardPanel.form;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizardPanel.form,v  <-- 
EntityWizardPanel.form
new revision: 1.4; previous revision: 1.3
done
Checking in src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizardPanel.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizardPanel.java,v  <-- 
EntityWizardPanel.java
new revision: 1.8; previous revision: 1.7
done
Checking in src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/EntityClassesPanel.form;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/EntityClassesPanel.form,v  <-- 
EntityClassesPanel.form
new revision: 1.4; previous revision: 1.3
done
Checking in src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/EntityClassesPanel.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/EntityClassesPanel.java,v  <-- 
EntityClassesPanel.java
new revision: 1.14; previous revision: 1.13
done
Comment 7 Dongmei Cao 2008-07-25 23:22:37 UTC
*** Issue 122824 has been marked as a duplicate of this issue. ***