This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I added import to projectized.xml in openide/build.xml in order to build test. building and running tests works fine. But I found other problem. Few modules depends on unit tests of 'org.openide' module. ModuleListParser is not able to find the module when is parsed project.xml. For example I'll attach patch to core/multiview/nbproject/project.xml. ant -f core/multiview/build.xml shows error message from code in ParseProjectXml that org.openide module doesn't exist. I don't know how to solve this problem. IMHO it will be better to move tests for org.openide to openide.explorer and openide.windows tests.
Created attachment 33362 [details] patch for openide and core/multiview
org.openide is not a real module and no maintained tests should remain there. Everything there is somehow deprecated or messed up in terms of dependencies. Does core/multiview really need it?
Yes, it needs it : public class MVInnerComponentGetLookupTest extends org.openide.windows.TopComponentGetLookupTest { the org.openide.windows.TopComponentGetLookupTest is in org.openide tests I am for to move the org.openide tests to core/multiview
I looked at the tests at org.openide: There are four packages org.openide.explorer org.openide.explorer.propertysheet org.openide.explorer.view org.openide.windows the first three packages can be moved ot org.openide.explorer module. The last can be moved to org.openide.windows package. I can try to do it if no one is against it.
The tests that remain in org.openide are those which cannot trivially be moved since they depend on things other than the module itself. For example, TopComponentActivatedNodesTest and TopComponentGetLookupOverridenTest [sic] have dependencies on org.openide.explorer, which org.openide.windows itself does not. These tests do not belong in org.openide.explorer either, since that has no dependency on org.openide.windows. Really such tests are not true unit tests, they are integration tests. Other tests in this project seem to have completely gratuitous dependencies on unrelated APIs and simply ought to be rewritten. For example, ExplorerPanelTest depends on Filesystems for no obvious reason; probably a mistake (can remove that dep). Of course ExplorerPanel is now in org.openide.compat so its test should be moved there. It may however be possible to move TopComponentGetLookupTest into org.openide.windows. I don't remember if I tried that when last I attempted to move as many tests as possible out of org.openide. Anyway, feel free to move unit tests to more appropriate places *if* you do not add new and inappropriate test deps on unrelated API modules.
The TopComponentGetLookupTest is already openide/windows/test/unit/src. I've changed the testdependcy to openide/windows/test and migrated all the dependencies in openide/* core/* projects /cvs/openide/build.xml,v <-- build.xml new revision: 1.198; previous revision: 1.197 done Checking in openide/looks/nbproject/project.properties; /cvs/openide/looks/nbproject/project.properties,v <-- project.properties new revision: 1.11; previous revision: 1.10 done Checking in openide/looks/nbproject/project.xml; /cvs/openide/looks/nbproject/project.xml,v <-- project.xml new revision: 1.10; previous revision: 1.9 done Checking in openide/nbproject/project.properties; /cvs/openide/nbproject/project.properties,v <-- project.properties new revision: 1.14; previous revision: 1.13 done Checking in openide/nbproject/project.xml; /cvs/openide/nbproject/project.xml,v <-- project.xml new revision: 1.11; previous revision: 1.10 done Checking in openide/registry/nbproject/project.properties; /cvs/openide/registry/nbproject/project.properties,v <-- project.properties new revision: 1.10; previous revision: 1.9 done Checking in openide/registry/nbproject/project.xml; /cvs/openide/registry/nbproject/project.xml,v <-- project.xml new revision: 1.9; previous revision: 1.8 done Checking in openide/util/enum/nbproject/project.xml; /cvs/openide/util/enum/nbproject/project.xml,v <-- project.xml new revision: 1.10; previous revision: 1.9 done Checking in core/multiview/nbproject/project.properties; /cvs/core/multiview/nbproject/project.properties,v <-- project.properties new revision: 1.10; previous revision: 1.9 done Checking in core/multiview/nbproject/project.xml; /cvs/core/multiview/nbproject/project.xml,v <-- project.xml new revision: 1.9; previous revision: 1.8 done Checking in core/navigator/nbproject/project.properties; /cvs/core/navigator/nbproject/project.properties,v <-- project.properties new revision: 1.7; previous revision: 1.6 done Checking in core/navigator/nbproject/project.xml; /cvs/core/navigator/nbproject/project.xml,v <-- project.xml new revision: 1.5; previous revision: 1.4 done Checking in core/palette/nbproject/project.properties; /cvs/core/palette/nbproject/project.properties,v <-- project.properties new revision: 1.7; previous revision: 1.6 done Checking in core/palette/nbproject/project.xml; /cvs/core/palette/nbproject/project.xml,v <-- project.xml new revision: 1.6; previous revision: 1.5 done Checking in core/registry/nbproject/project.properties; /cvs/core/registry/nbproject/project.properties,v <-- project.properties new revision: 1.14; previous revision: 1.13 done Checking in core/registry/nbproject/project.xml; /cvs/core/registry/nbproject/project.xml,v <-- project.xml new revision: 1.13; previous revision: 1.12 done
v