Please use the Apache issue tracking system for new NetBeans issues (https://issues.apache.org/jira/projects/NETBEANS0/issues) !!
Bug 83483 - Refactoring doesn't *change* method parameters
Refactoring doesn't *change* method parameters
Status: RESOLVED FIXED
Product: editor
Classification: Unclassified
Component: Refactoring
6.x
Macintosh Mac OS X
: P3 (vote)
: TBD
Assigned To: Ralph Ruijs
issues@java
:
Depends on:
Blocks: 65780
  Show dependency treegraph
 
Reported: 2006-08-25 16:21 UTC by hobel
Modified: 2011-06-10 14:48 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hobel 2006-08-25 16:21:04 UTC
Disclaimer: the Help File says "You can not remove parameters that were in the
method before you opened the dialog box."

But then what's the point of refactoring?  I cannot remove an old parameter, and
the dialog also doesn't allow me to change an old one in any way.

What I expect when I click "Change Method Parameters" is that that wizard allows
me to *change my method's parameters*.  (no offense, it's just misleading
advertising)

I think this is a severe bug, because it makes the refactoring dialog much less
useful (only if you want to add another parameter, but useless in any other
case).  Also I'd say it's not just a missing feature, but an actual bug, as the
behavior doesn't match the Menu entry's name at all (it should say "add method
parameter(s)").

I'm running the newest NB 6.0M2, sadly, but I hope work on this is planned...
Comment 1 scirka 2007-05-26 16:08:43 UTC
IDE 6.0 Preview (M9, build 070502)
1.6.0-dp; Java HotSpot(TM) Client VM 1.6.0-b88-17-release
Mac OS X version 10.4.9 running on i386

- refactoring doesn't do *anything*. I selected the class name, selected
refactor > rename...; the dialog appeared; enter the new name; press Refactor;
the dialog box closes, the file is unchanged.
Comment 2 Jiri Prox 2007-05-28 15:08:02 UTC
scirka: I've filed a separate issue for you problem (see issue 104961, you are
on CC), since it looks like a different bug. Please add any comment there. Thanks.
Comment 3 Jan Becicka 2007-06-25 16:44:49 UTC
Change method parameters implements these features:
1. Add parameters
2. Remove parameters
3. Reorder parameters

This is what it does. We will keep your comment as enhancement.


Comment 4 softwarevisualization 2008-02-07 16:42:41 UTC
I am voting for this issue. It's feel unnatural to not be able to click in the table cell and edit either the name of
the variable or , more often, its type. 

My driving use case was a desire to replace variables of StringBuffer with type StringBuilder, leaving their names and
ordering in the parameter list the same. 

The workaround is to 
1) add a new parameter, carefully re-typing all the information from the old parameter then 
2) deleting the old parameter. 

thank you for reading this. 
Comment 5 Ralph Ruijs 2011-06-08 10:59:21 UTC
Changeset: 1d8761a7aaa2
Author:    Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Date:      2011-06-08 12:53
Message:   
Issue #83483 - Refactoring doesn't *change* method parameters
Comment 6 Quality Engineering 2011-06-10 14:48:39 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/1d8761a7aaa2
User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org>
Log: Issue #83483 - Refactoring doesn't *change* method parameters


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2014, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo