This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 81029 - Add com.sun.rave.dataconnectivity as a friend of org.netbeans.modules.derby
Summary: Add com.sun.rave.dataconnectivity as a friend of org.netbeans.modules.derby
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Derby (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Andrei Badea
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 78597
  Show dependency tree
 
Reported: 2006-07-24 23:51 UTC by John Baker
Modified: 2006-08-09 22:50 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Baker 2006-07-24 23:51:48 UTC 
Hi,

I need to use the APIs in DerbyDatabases.
Please add my module to the friend list of module "Java DB Database Support" 

My module's code base name is com.sun.rave.dataconnectivity.
Major release is 1
Specification version is 2.0



Thank you
Comment 1 Andrei Badea 2006-07-25 10:38:58 UTC 
I would like to ask for a review for adding com.sun.rave.dataconnectivity as a
friend of org.netbeans.modules.derby. The API provided by
org.netbeans.modules.derby consists of a DerbyDatabases class (already in the CVS)

http://www.netbeans.org/source/browse/*checkout*/db/derby/src/org/netbeans/modules/derby/api/Attic/DerbyDatabases.java?rev=1.1.2.5

which allows a client to create new Derby databases. There is also an SPI, which
the new client will not use.
Comment 2 Andrei Badea 2006-08-03 10:38:12 UTC 
The reporter has retracted the request for this API.
Comment 3 John Baker 2006-08-04 11:02:40 UTC 
"OSLO" client is needed to create sample databases on a user-installed Derby
database system.

To create a sample database, checks are required to:
- verify a Derby installation (registration) by checking system home setting, etc.
- load driver 
- connect to database
- check if database already exists
- create Sample databases
...

After further investigation, the verification of Derby installation fails. 
The client module does not have access to org.netbeans.modules.derby.

The System option (for the Derby system home) is set by  DerbyOptions class
which is not public to external APIs (external to org.netbeans.modules.derby) 
However, DerbyDatabases.java is able to access DerbyOptions. 

 Therefore OSLO client requires com.sun.rave.dataconnectivity to be added to the
friend list of org.netbeans.modules.derby
Client will only use APIs in DerbyDatabases.java
Comment 4 Andrei Badea 2006-08-04 12:16:33 UTC 
Since this issue was assigned to apireviews for more than a week and there were
not comments, I take it as reviewed and will commit on Monday. Thank you for the
review.
Comment 5 Andrei Badea 2006-08-08 11:18:41 UTC 
Integrated.

Checking in db/derby/nbproject/project.xml;
/cvs/db/derby/nbproject/project.xml,v  <--  project.xml
new revision: 1.4.2.2.2.4; previous revision: 1.4.2.2.2.3
done
Checking in ide/golden/friend-packages.txt;
/cvs/ide/golden/friend-packages.txt,v  <--  friend-packages.txt
new revision: 1.15.4.1.2.121; previous revision: 1.15.4.1.2.120
done
Comment 6 John Baker 2006-08-09 22:50:33 UTC 
I see the fix is in the Aug 9 daily build.  Thank you