Nikita, why is there an N/A choice?

I think there should just be a boolean check box. And the default setting shoul
be the default as per the specification.

This N/A is unnecessry complexity, no?

well, maybe i see what you are worried about. You are worried that the Count
Completion condtion attrbibute is only meaningful if the completion condition is
non-null. You don't want to generate code for completion condtion if there is no
completion condtion. Yes? But you are perhaps worried that if user toggles the
Count Completion Condition property we will generate such code even when there
is no completion condtion value? Let me think about this. I still think we
should be able to use simple boolean for this property. It is just a question of
managing the code generation properly. Maybe Denis can manage this subtlety.
Maybe he can avoid generating code for Completion Condtion if it is empty string
or null.



	<complexType name="tForEach">
      	   <complexContent>
               <extension base="bpws:tActivity">
                   <sequence>
                       <element name="startCounterValue" type="bpws:tExpression"/>
                       <element name="finalCounterValue" type="bpws:tExpression"/>
		       <element name="completionCondition" type="bpws:tCompletionCondition"
minOccurs="0"/>
                       <element ref="bpws:scope" />
                   </sequence>
                   <attribute name="counterName" type="NCName"
                            use="required"/>
<!-- not supported by BPEL engine
                   <attribute name="parallel" type="bpws:tBoolean"
                            use="required"/>
-->
               </extension>
           </complexContent>
	</complexType>
	<complexType name="tCompletionCondition">
	   <complexContent>
               <extension base="bpws:tExtensibleElements">
                   <sequence>
                       <element name="branches">
		           <complexType> 
		             <complexContent>
			        <extension base="bpws:tExpression">
				    <attribute name="countCompletedBranchesOnly" type="bpws:tBoolean" /> 
				</extension> 
			     </complexContent> 
			   </complexType> 
		       </element> 
                   </sequence>
               </extension>
           </complexContent>
	</complexType> 

Ok, talked to Denis already. He will take look at this bug. We can leave the UI
as combo box for now, but we need to allow user to do two things.

User must be able to set  Count Completion Condition Branches propety to N/A
without getting exception.

User must be able to "remove" the Completion Condition entirely, without getting
"This is required property error". Because, in fact, completion condition is not
required. 

So testing should make sure that both of those cases will work as intended.

I didn't find OM issues.

Currently there is no exception, but dialog with error appear.

It appear by reason of absence "romever" for countCompletionBranchesOnly property.
This remover is reflection method in property sheet.
This is wrong assumption in property editor code because there exist method
removeCountCompletionBranchesOnly. Property editor should use this method for 
remove property countCompletionBranchesOnly at least.

So dialog can be fixed in Property editor.

About all other discussion : all needed behavior should be also done in 
property editor code. It could determine absence of Branches and delete element 
CompletionCondition at all from ForEach.

There is one more issue when one tries to set empty expression to branches.
In this case dialog also appears.

Branches is ContentElement and it dosn't have method removeContent().
But here should not be called removeContent() method. Here should be called 
method setContent( "" );

And possibly in this case Nikita don't need to call this method at all but he 
need to remove CompletionCondition element at all from ForEach container.
( expression is set to "" , so we don't need actually branches, but
CompletionCondition contains ONLY branches , so we can delete both - 
CompletionCondition and its child - Branches ).

I will take care about it.

I have implemented possibility to remove countCompletedBranchesOnly attribute.

Will try to implement removal CompletionCondition element when expression is set 
to "".

I implemented described above behavior.
( when one set empty completion condition then element CompletionCondition
will be deleted with all its content ).

Verified in build 17