This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 79928 - I18N - some possible hard coded font or window sizes
Summary: I18N - some possible hard coded font or window sizes
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 9 (show other bugs)
Version: 5.x
Hardware: Sun All
: P2 blocker (vote)
Assignee: _ pcw
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2006-07-10 18:47 UTC by Ken Frank
Modified: 2006-09-26 18:26 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2006-07-10 18:47:48 UTC
this is from code scanning for certain api calls, and
realize that some of these might not be in active
code or otherwise valid, and that some will need to be assigned to different
subcats -- the code scanning just looks for certain api calls using hardcoded
values.

These items are either possible hard coded font sizes or use of
non jdk font names.

This is a complement to the actual resize testing done to see these kind
of issues in real product.

as well as possible hard coding of window or dialog
sizes using setPreferred or setMinimumSize.

*** this isn't meant to be a total list as there might be other same situations
not found by the scanning - please check the code.

----
serverplugins

a. hardocoded font name and size ?

portField.setFont(new java.awt.Font("Tahoma", 0, 11));
./websphere6/src/org/netbeans/modules/j2ee/websphere6/ui/ConnectionTa
bVisualPanel.java

( I don't think Tahoma is not a standard jdk font name ?)

b. various setPreferredSize, setMinimumSize hardcoded ?

sun/appsrv/src/org/netbeans/modules/j2ee/sun/ide
sun/sunddui/src/org/netbeans/modules/j2ee/sun/share/configbean
sun/webserver7/src/org/netbeans/modules/j2ee/sun/ws7/serverresour ces
/wizards
weblogic9/src/org/netbeans/modules/j2ee/weblogic9/ui/wizard
Comment 1 Petr Jiricka 2006-07-11 11:03:18 UTC
Hi Ken, please use separate issues for Sun Appserver, WebLogic, WebSphere and
Sun WebServer, as each is owned by a different engineer/team.
Comment 2 Ken Frank 2006-07-11 16:25:09 UTC
I will file separate issues on the other servers today.

ken.frank@sun.com
Comment 3 _ pcw 2006-07-11 21:45:56 UTC
What exactly are the bugs here that need to be fixed?

For example, yes, there are calls to setPreferredSize() in sunddui module in
particular.  Those calls are carefully constructed to specifically size panels
that contain tables and lists nicely wrt/ everything else and are scaled
according to the other controls.  They do not use absolute values and are not
I18N bugs.

There are some other places in the SJSAS plugin where there are some I18N sizing
issues but there are specific bugs on those areas so in that respect, this is a
duplicate.

So rather than marking this as INVALID, I would like a more detailed description
of what needs to be fixed in the SJSAS plugin that is not already covered by
existing issues.
Comment 4 Ken Frank 2006-07-11 22:11:40 UTC
It's just that testing is not able to find all such problems and
source code checking can be complementary, even though not exact, and in past
has led to discovery of other such issues for other modules.
 But if the code
shows that all instances using the api calls are either covered
by existing bugs or not a resize kind of problem, then please
just close the issue.

ken.frank@sun.com
Comment 5 _ pcw 2006-09-09 01:53:37 UTC
I cleaned up a few obvious but minor problems related to this issue, so I'm
closing as fixed.

Most if not all remaining calls to the methods enumerated above take into
account fontsize, etc, as already mentioned.

If specific issues not already reported are found, please file them individually.
Comment 6 Ken Frank 2006-09-26 18:26:29 UTC
verified