Wizard framework (an part of Dialogs and Wizards API module) cannot declare
dependency of Progress API because circular depencency. It's blocks issue 58889
(Enhance wizard framework to display progress indication on Finish). I guess it
needs to slip Progress API module to API and implementation module.
as discussed offline:
progress depends on org.openide.dialogs and org.openide.windows.
we should use reflection in either wizards or progress to get rid of circular
splitting the progress APIs and impl would mean an incompatible change for the
API users. (as it's users need to declare required token next to the module
+1 for splitting API from impl. Have API find impl in lookup and include a
trivial implementation if none is found, which would e.g. do nothing or just use
logging to notify progress. Re. compatibility for progress API users, not a big
problem. Even as things stand you can use ModuleAutoDeps. But with issue #34699
you would be able to e.g.
which would have no impact on users.
Properly marking deps.
done the split of progress api and ui. Api now depends on openide/util only.
progress ui has implementation dependency on progress api and progress api uses
the OpenIDE-Modules-Needs token.
increased the version number and updated the apichanges document.
Created attachment 32144 [details]
progress api split changes
please review, diff attached.
BTW please: echo 'diff -u' >> ~/.cvsrc
No need to cast after calling Lookup.gD().lookup(PUIWP.class).
Class name org.netbeans.progress.spi.ProgressUIWorkerProvider does not match
token org.netbeans.spi.progress.ProgressUIWorkerProvider. Which is it?
Delete layer if empty.
the token should be based on the class. yarda made me change the package name,
but the token got lost on the way.
thanks for feedback, about to integrate
integrated in trunk.