Bug 76692 - Enhance FS with support for FS independent methodvalue
Enhance FS with support for FS independent methodvalue
Status: RESOLVED FIXED
Product: platform
Classification: Unclassified
Component: Filesystems
5.x
All All
: P2 (vote)
: 6.x
Assigned To: Jaroslav Tulach
issues@platform
: API, API_REVIEW_FAST
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-22 17:02 UTC by Jaroslav Tulach
Modified: 2008-12-23 00:22 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
:


Attachments
The test, docs and impl (13.21 KB, patch)
2006-05-22 17:42 UTC, Jaroslav Tulach
Details | Diff
Additional impl in core/startup's binaryfs (7.47 KB, patch)
2006-05-23 10:15 UTC, Jaroslav Tulach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2006-05-22 17:02:44 UTC
I am about to develop actions API which is going to depend on the 
XMLFileSystem's methodvalue heavilly. I do not need the dependency on 
filesystems API however. That is why I'd like to enhance the implementation of 
filesystems to support also some filesystems independent methodvalue. I 
propose to also recognize 

<V> static V methodValue(java.util.Map<String,Object> readOnlyAttrs)
and
<V> static V methodValue(java.util.Map<String,Object> readOnlyAttrs, String 
name)

methods as methodvalue targets. I'll create a patch.
Comment 1 Jaroslav Tulach 2006-05-22 17:42:39 UTC
Created attachment 30546 [details]
The test, docs and impl
Comment 2 Jaroslav Tulach 2006-05-22 17:43:54 UTC
A little enhancement in filesystems. Ok?
Comment 3 Jesse Glick 2006-05-22 18:43:09 UTC
"permissions" not "premitions"


BTW overriding remove and put in FileMap is unnecessary.


Please correct FileObject.getAttributes to return Enumeration<String> so you do
not need to cast it in AttrFileSet. Don't forget to find usages on this method
and correct code calling it, too. (Maybe Radek just forgot to do this? Seems
like generification of openide/fs was incomplete.)
Comment 4 Jaroslav Tulach 2006-05-23 10:15:41 UTC
Created attachment 30552 [details]
Additional impl in core/startup's binaryfs
Comment 5 Jaroslav Tulach 2006-05-30 08:03:22 UTC
Week is over, thanks for the review. Either me or Radek will integrate this 
change tomorrow.
Comment 6 Jaroslav Tulach 2006-05-31 16:42:36 UTC
IDE:-------------------------------------------------
IDE: [31.5.06 17:42] Committing 2 Projects started
Checking in 
core/startup/test/unit/src/org/netbeans/core/startup/layers/CacheManagerTestBaseHid.java;
/shared/data/ccvs/repository/core/startup/test/unit/src/org/netbeans/core/startup/layers/CacheManagerTestBaseHid.java,v  
<--  CacheManagerTestBaseHid.java
new revision: 1.2; previous revision: 1.1
done
Checking in core/startup/nbproject/project.xml;
/shared/data/ccvs/repository/core/startup/nbproject/project.xml,v  <--  
project.xml
new revision: 1.7; previous revision: 1.6
done
Checking in openide/fs/src/org/openide/filesystems/XMLFileSystem.java;
/shared/data/ccvs/repository/openide/fs/src/org/openide/filesystems/XMLFileSystem.java,v  
<--  XMLFileSystem.java
new revision: 1.12; previous revision: 1.11
done
Checking in openide/fs/src/org/openide/filesystems/XMLMapAttr.java;
/shared/data/ccvs/repository/openide/fs/src/org/openide/filesystems/XMLMapAttr.java,v  
<--  XMLMapAttr.java
new revision: 1.4; previous revision: 1.3
done
Checking in openide/fs/manifest.mf;
/shared/data/ccvs/repository/openide/fs/manifest.mf,v  <--  manifest.mf
new revision: 1.8; previous revision: 1.7
done
Checking in openide/fs/apichanges.xml;
/shared/data/ccvs/repository/openide/fs/apichanges.xml,v  <--  apichanges.xml
new revision: 1.8; previous revision: 1.7
done
Checking in 
openide/fs/test/unit/src/org/openide/filesystems/data/Attributes.xml;
/shared/data/ccvs/repository/openide/fs/test/unit/src/org/openide/filesystems/data/Attributes.xml,v  
<--  Attributes.xml
new revision: 1.2; previous revision: 1.1
done
Checking in 
openide/fs/test/unit/src/org/openide/filesystems/AttributesTestHidden.java;
/shared/data/ccvs/repository/openide/fs/test/unit/src/org/openide/filesystems/AttributesTestHidden.java,v  
<--  AttributesTestHidden.java
new revision: 1.4; previous revision: 1.3
done
Checking in core/startup/src/org/netbeans/core/startup/layers/BinaryFS.java;
/shared/data/ccvs/repository/core/startup/src/org/netbeans/core/startup/layers/BinaryFS.java,v  
<--  BinaryFS.java
new revision: 1.9; previous revision: 1.8
doneIDE:-------------------------------------------------
IDE: [31.5.06 17:42] Committing 2 Projects started
Checking in 
core/startup/test/unit/src/org/netbeans/core/startup/layers/CacheManagerTestBaseHid.java;
/shared/data/ccvs/repository/core/startup/test/unit/src/org/netbeans/core/startup/layers/CacheManagerTestBaseHid.java,v  
<--  CacheManagerTestBaseHid.java
new revision: 1.2; previous revision: 1.1
done
Checking in core/startup/nbproject/project.xml;
/shared/data/ccvs/repository/core/startup/nbproject/project.xml,v  <--  
project.xml
new revision: 1.7; previous revision: 1.6
done
Checking in openide/fs/src/org/openide/filesystems/XMLFileSystem.java;
/shared/data/ccvs/repository/openide/fs/src/org/openide/filesystems/XMLFileSystem.java,v  
<--  XMLFileSystem.java
new revision: 1.12; previous revision: 1.11
done
Checking in openide/fs/src/org/openide/filesystems/XMLMapAttr.java;
/shared/data/ccvs/repository/openide/fs/src/org/openide/filesystems/XMLMapAttr.java,v  
<--  XMLMapAttr.java
new revision: 1.4; previous revision: 1.3
done
Checking in openide/fs/manifest.mf;
/shared/data/ccvs/repository/openide/fs/manifest.mf,v  <--  manifest.mf
new revision: 1.8; previous revision: 1.7
done
Checking in openide/fs/apichanges.xml;
/shared/data/ccvs/repository/openide/fs/apichanges.xml,v  <--  apichanges.xml
new revision: 1.8; previous revision: 1.7
done
Checking in 
openide/fs/test/unit/src/org/openide/filesystems/data/Attributes.xml;
/shared/data/ccvs/repository/openide/fs/test/unit/src/org/openide/filesystems/data/Attributes.xml,v  
<--  Attributes.xml
new revision: 1.2; previous revision: 1.1
done
Checking in 
openide/fs/test/unit/src/org/openide/filesystems/AttributesTestHidden.java;
/shared/data/ccvs/repository/openide/fs/test/unit/src/org/openide/filesystems/AttributesTestHidden.java,v  
<--  AttributesTestHidden.java
new revision: 1.4; previous revision: 1.3
done
Checking in core/startup/src/org/netbeans/core/startup/layers/BinaryFS.java;
/shared/data/ccvs/repository/core/startup/src/org/netbeans/core/startup/layers/BinaryFS.java,v  
<--  BinaryFS.java
new revision: 1.9; previous revision: 1.8
done
Checking in 
core/startup/test/unit/src/org/netbeans/core/startup/layers/data/layer1.xml;
/shared/data/ccvs/repository/core/startup/test/unit/src/org/netbeans/core/startup/layers/data/layer1.xml,v  
<--  layer1.xml
new revision: 1.2; previous revision: 1.1
done
Checking in 
core/startup/test/unit/src/org/netbeans/core/startup/layers/data/layer1.xml;
/shared/data/ccvs/repository/core/startup/test/unit/src/org/netbeans/core/startup/layers/data/layer1.xml,v  
<--  layer1.xml
new revision: 1.2; previous revision: 1.1
done


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo