This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 75193 - Stop using deprecated EnhancedCustomPropertyEditor
Summary: Stop using deprecated EnhancedCustomPropertyEditor
Status: RESOLVED WONTFIX
Alias: None
Product: xml
Classification: Unclassified
Component: TAX (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Svata Dedic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-19 00:07 UTC by Thomas Preisler
Modified: 2015-09-17 13:17 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
List of files referencing EnhancedCustomPropertyEditor class (16.02 KB, text/plain)
2006-10-20 01:15 UTC, Vitezslav Stejskal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Preisler 2006-04-19 00:07:49 UTC
EnhancedCustomPropertyEditor has been deprecated for a long time now but no good
alternative has been provided. The deprecation message suggests to use
PropertyEnv instead, but it solves a completely different problem and would
require serious rewrites of your custom editors to use.

EnhancedCustomPropertyEditor is still used many places (40?) in NetBeans itself
and very few (if any) usages have been replaces with something else over the
years. Below is a thread from nbdev basically concluding that nobody remembers
why it was deprecated in the first place.

Please provide a useful replacement or 'un-deprecate' this interface. 

Date: Tue, 07 Mar 2006 17:36:16 +0100
From: Jaroslav Tulach <Jaroslav.Tulach@Sun.COM>
Content-type: text/plain; charset=iso-8859-1
Subject: [nbdev] EnhancedCustomPropertyEditor

Dne Monday 06 March 2006 17:41 Thomas Preisler napsal(a):
> Jaroslav Tulach wrote:
> > Dne Thursday 02 March 2006 08:13 Thomas Preisler napsal(a):
> >>org.openide.explorer.propertysheet.editors.EnhancedCustomPropertyEditor
> >>has been deprecated. It says 'Use PropertyEnv instead.'. What does that
> >>mean?
> >
> > It means to use org.openide.explorer.propertysheet.PropertyEnv.
> >
> >>How to do that?
> >
> > I hope the howto is at
> > http://www.netbeans.org/download/dev/javadoc/org-openide-explorer/org/ope
> >nide/explorer/propertysheet/PropertyEnv.html
> >
> > If you feel something is not explained enough, advice an improvement (in
> > form of patch to the source) please.
> > -jst
> >
> >>Also I noticed it is still being used many places. Does that mean it is
> >>not going away anytime soon?
> >
> > PS: I do not know of anybody trying to rewrite our property sheet...
>
> I tried to figure out how to rewrite the old code to use PropertyEnv,
> but it is *not* a trivial change. I was looking for some guidelines of
> how to do it. 

I've just updated the javadoc[1] to point to
http://www.netbeans.org/source/browse/core/src/org/netbeans/beaninfo/editors/RectangleCustomEditor.java?r1=1.25&r2=1.26
which is an example of rewrite.

> Why is EnhancedCustomPropertyEditor deprecated? 

I guess I am supposed to know, but I do not. Maybe we tried to cleanup the 
implementation of property sheet from old hacks, but as far as I know all 
these old interfaces are still supported...

-jst
Comment 1 Jaroslav Tulach 2006-04-27 11:34:50 UTC
"#75193: Removing usage of EnhancedCustomPropertyEditor from platform cluster"
Checking in src/org/netbeans/beaninfo/DataLoaderBeanInfo.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/DataLoaderBeanInfo.java,v  
<--  DataLoaderBeanInfo.java
new revision: 1.13; previous revision: 1.12
done
Checking in src/org/netbeans/beaninfo/LoaderActionsPanel.form;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/LoaderActionsPanel.form,v  
<--  LoaderActionsPanel.form
new revision: 1.9; previous revision: 1.8
done
Checking in src/org/netbeans/beaninfo/LoaderActionsPanel.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/LoaderActionsPanel.java,v  
<--  LoaderActionsPanel.java
new revision: 1.17; previous revision: 1.16
done
Checking in src/org/netbeans/beaninfo/editors/DataFolderEditor.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/DataFolderEditor.java,v  
<--  DataFolderEditor.java
new revision: 1.10; previous revision: 1.9
done
Checking in src/org/netbeans/beaninfo/editors/DataFolderPanel.form;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/DataFolderPanel.form,v  
<--  DataFolderPanel.form
new revision: 1.9; previous revision: 1.8
done
Checking in src/org/netbeans/beaninfo/editors/DataFolderPanel.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/DataFolderPanel.java,v  
<--  DataFolderPanel.java
new revision: 1.33; previous revision: 1.32
done
Checking in src/org/netbeans/beaninfo/editors/DimensionCustomEditor.form;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/DimensionCustomEditor.form,v  
<--  DimensionCustomEditor.form
new revision: 1.8; previous revision: 1.7
done
Checking in src/org/netbeans/beaninfo/editors/DimensionCustomEditor.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/DimensionCustomEditor.java,v  
<--  DimensionCustomEditor.java
new revision: 1.26; previous revision: 1.25
done
Checking in src/org/netbeans/beaninfo/editors/FileEditor.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/FileEditor.java,v  
<--  FileEditor.java
new revision: 1.36; previous revision: 1.35
done
Checking in src/org/netbeans/beaninfo/editors/InsetsCustomEditor.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/InsetsCustomEditor.java,v  
<--  InsetsCustomEditor.java
new revision: 1.27; previous revision: 1.26
done
Checking in src/org/netbeans/beaninfo/editors/StringCustomEditor.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/StringCustomEditor.java,v  
<--  StringCustomEditor.java
new revision: 1.28; previous revision: 1.27
done
Checking in src/org/netbeans/beaninfo/editors/StringEditor.java;
/shared/data/ccvs/repository/core/src/org/netbeans/beaninfo/editors/StringEditor.java,v  
<--  StringEditor.java
new revision: 1.21; previous revision: 1.20
Comment 2 Jaroslav Tulach 2006-04-27 11:39:03 UTC
All usages of the EnhancedCustomPropertyEditor removed from the platform, next 
in round is the ide cluster. Let's start with editor. Please remove the usage 
of the interface from:

editor/src/org/netbeans/modules/editor/options/ScrollInsetsCustomEditor.java
editor/src/org/netbeans/modules/editor/options/ScrollInsetsCustomEditor.java

and send to next siner, please.
Comment 3 Vitezslav Stejskal 2006-10-20 01:14:14 UTC
Fixed in editor, moving to beans module.
Comment 4 Vitezslav Stejskal 2006-10-20 01:15:34 UTC
Created attachment 35400 [details]
List of files referencing EnhancedCustomPropertyEditor class
Comment 5 Jan Pokorsky 2007-08-07 16:31:43 UTC
The beans module will not be part of nb 6.0. Reassigning to the form.
Comment 6 Tomas Pavek 2007-09-25 10:47:42 UTC
I've removed use of EnhancedCustomPropertyEditor from form and i18n.

The next seems to be serverplugins, reassigning.

serverplugins/sun/appsrv/src/org/netbeans/modules/j2ee/sun/ide/editors/ui/DDTablePanel.java
Comment 7 pslechta 2008-08-22 14:14:25 UTC
Cannot find any occurence of EnhancedCustomPropertyEditor in j2ee.sun.appsrv.
Is this issue still active or can it be closed?
Comment 8 Nitya Doraisamy 2008-08-22 19:24:13 UTC
EnhancedCustomPropertyEditor is still used in sun/appsrv/src/org/netbeans/modules/j2ee/sun/ide/editors/ui/DDTablePanel.java

Will look into this asap.
Comment 9 Nitya Doraisamy 2008-09-10 14:32:25 UTC
The serverplugin code using EnhancedCustomPropertyEditor needs to be redone. Filed Issue 146786 for this.
Moving issue to the xml/tax
Comment 10 Martin Balin 2015-09-17 13:17:19 UTC
Report from old NetBeans version. Due to code changes since it was reported likely not reproducible now. Feel free to reopen if happens in 8.0.2 or 8.1.