This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
It would be good to define constants for well known 'tools' supported by the isToolSupported method sothat other modules and server plugins can use those without worry of changing strings. For web services these are: jsr109 wscompile wsimport wsgen jwsdp
Created attachment 29376 [details] javadoc
Created attachment 29377 [details] diff of changes
Please review the following API change. Many j2eeplatform tools like wscompile need properties like main class or JVM options. The getToolProperty method, which will be added by this API change, will allow to get those properties now, so far these properties had to be hardcoded. The constats for the tools and the tool properties were added to avoid problems that might occur if the tool string changes. Interfaces impacted by this change: org.netbeans.modules.j2ee.deployment.devmodules.api.J2eePlatform org.netbeans.modules.j2ee.deployment.plugins.api.J2eePlatformImpl
I know I asked for this and provided input to the list, but I realized there's actually 2 more we should have there: KEYSTORE TRUSTSTORE Would it be possible to add these as well?
to be more specific: KEYSTORE KEYSTORE_CLIENT TRUSTSTORE TRUSTSTORE_CLIENT
no problem, I will update the javadoc and the diff
Can we add JSF as well? Will be there chance to find out the version of the tool?
There are not plans to introduce a JSF tool contant since JSF is not a 'tool'. Libraries are a bit different from tools, they can be for example deployed on the server, and therefore we need to introduce a new API in order to support them. So far you can use a hack and make a silent contract between the server plugin and your module and use the tool support for JSF.
Created attachment 29438 [details] updated diff with added constants
Created attachment 29439 [details] updated javadoc with added constants
If there are no farther comments or objections, I will proceed with the commit tomorrow.
F. Checking in j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/Utils.java; /cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/Attic/Utils.java,v <-- Utils.java new revision: 1.1.4.4; previous revision: 1.1.4.3 done Checking in j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/api/AppClientProjectGenerator.java; /cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/api/Attic/AppClientProjectGenerator.java,v <-- AppClientProjectGenerator.java new revision: 1.1.4.8; previous revision: 1.1.4.7 done Checking in j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/AppClientProjectProperties.java; /cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/Attic/AppClientProjectProperties.java,v <-- AppClientProjectProperties.java new revision: 1.1.4.7; previous revision: 1.1.4.6 done Checking in j2ee/earproject/src/org/netbeans/modules/j2ee/earproject/EarProjectGenerator.java; /cvs/j2ee/earproject/src/org/netbeans/modules/j2ee/earproject/EarProjectGenerator.java,v <-- EarProjectGenerator.java new revision: 1.21.2.2.2.4; previous revision: 1.21.2.2.2.3 done Checking in j2ee/earproject/src/org/netbeans/modules/j2ee/earproject/ui/customizer/EarProjectProperties.java; /cvs/j2ee/earproject/src/org/netbeans/modules/j2ee/earproject/ui/customizer/EarProjectProperties.java,v <-- EarProjectProperties.java new revision: 1.20.2.2.2.3; previous revision: 1.20.2.2.2.2 done Checking in j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/api/EjbJarProjectGenerator.java; /cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/api/EjbJarProjectGenerator.java,v <-- EjbJarProjectGenerator.java new revision: 1.1.2.6.2.2; previous revision: 1.1.2.6.2.1 done Checking in j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/EjbJarProjectProperties.java; /cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/EjbJarProjectProperties.java,v <-- EjbJarProjectProperties.java new revision: 1.27.2.3.2.2; previous revision: 1.27.2.3.2.1 done Checking in j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/logicalview/LogicalViewChildren.java; /cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/logicalview/LogicalViewChildren.java,v <-- LogicalViewChildren.java new revision: 1.25.2.14.2.10; previous revision: 1.25.2.14.2.9 done Checking in j2eeserver/apichanges.xml; /cvs/j2eeserver/apichanges.xml,v <-- apichanges.xml new revision: 1.16.6.3.2.2; previous revision: 1.16.6.3.2.1 done Checking in j2eeserver/nbproject/project.properties; /cvs/j2eeserver/nbproject/project.properties,v <-- project.properties new revision: 1.9.34.3; previous revision: 1.9.34.2 done Checking in j2eeserver/src/org/netbeans/modules/j2ee/deployment/devmodules/api/J2eePlatform.java; /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/devmodules/api/J2eePlatform.java,v <-- J2eePlatform.java new revision: 1.7.6.1.2.2; previous revision: 1.7.6.1.2.1 done Checking in j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/J2eePlatformImpl.java; /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/J2eePlatformImpl.java,v <-- J2eePlatformImpl.java new revision: 1.3.42.1.2.3; previous revision: 1.3.42.1.2.2 done Checking in serverplugins/jboss4/src/org/netbeans/modules/j2ee/jboss4/ide/JBJ2eePlatformFactory.java; /cvs/serverplugins/jboss4/src/org/netbeans/modules/j2ee/jboss4/ide/JBJ2eePlatformFactory.java,v <-- JBJ2eePlatformFactory.java new revision: 1.5.8.4.2.5; previous revision: 1.5.8.4.2.4 done Checking in serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/PlatformImpl.java; /cvs/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/PlatformImpl.java,v <-- PlatformImpl.java new revision: 1.3.8.7.2.9; previous revision: 1.3.8.7.2.8 done Checking in tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/TomcatPlatformImpl.java; /cvs/tomcatint/tomcat5/src/org/netbeans/modules/tomcat5/TomcatPlatformImpl.java,v <-- TomcatPlatformImpl.java new revision: 1.9.10.1.2.4; previous revision: 1.9.10.1.2.3 done Checking in web/project/src/org/netbeans/modules/web/project/api/WebProjectUtilities.java; /cvs/web/project/src/org/netbeans/modules/web/project/api/WebProjectUtilities.java,v <-- WebProjectUtilities.java new revision: 1.2.2.5.2.5; previous revision: 1.2.2.5.2.4 done Checking in web/project/src/org/netbeans/modules/web/project/ui/WebViews.java; /cvs/web/project/src/org/netbeans/modules/web/project/ui/WebViews.java,v <-- WebViews.java new revision: 1.46.2.4.2.9; previous revision: 1.46.2.4.2.8 done Checking in web/project/src/org/netbeans/modules/web/project/ui/customizer/WebProjectProperties.java; /cvs/web/project/src/org/netbeans/modules/web/project/ui/customizer/WebProjectProperties.java,v <-- WebProjectProperties.java new revision: 1.94.6.3.2.3; previous revision: 1.94.6.3.2.2 done Checking in websvc/core/src/org/netbeans/modules/websvc/core/client/wizard/ClientInfo.java; /cvs/websvc/core/src/org/netbeans/modules/websvc/core/client/wizard/ClientInfo.java,v <-- ClientInfo.java new revision: 1.20.8.3.2.9; previous revision: 1.20.8.3.2.8 done Checking in websvc/dev/src/org/netbeans/modules/websvc/dev/wizard/WebServiceCreator.java; /cvs/websvc/dev/src/org/netbeans/modules/websvc/dev/wizard/Attic/WebServiceCreator.java,v <-- WebServiceCreator.java new revision: 1.1.2.17; previous revision: 1.1.2.16 done Checking in websvc/dev/src/org/netbeans/modules/websvc/dev/wizard/WebServiceWizardDescriptor.java; /cvs/websvc/dev/src/org/netbeans/modules/websvc/dev/wizard/WebServiceWizardDescriptor.java,v <-- WebServiceWizardDescriptor.java new revision: 1.13.28.4.2.1; previous revision: 1.13.28.4 done Checking in websvc/websvcapi/src/org/netbeans/modules/websvc/spi/webservices/WebServicesConstants.java; /cvs/websvc/websvcapi/src/org/netbeans/modules/websvc/spi/webservices/WebServicesConstants.java,v <-- WebServicesConstants.java new revision: 1.7.28.3; previous revision: 1.7.28.2 done
verified in 5.5