Bug 72427 - Fix/clean_up ModuleDependency's hashCode, equals, compareTo trio
Fix/clean_up ModuleDependency's hashCode, equals, compareTo trio
Status: RESOLVED FIXED
Product: apisupport
Classification: Unclassified
Component: Project
5.x
All All
: P1 (vote)
: 5.x
Assigned To: Martin Krauskopf
issues@apisupport
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-08 17:32 UTC by Martin Krauskopf
Modified: 2006-02-09 21:11 UTC (History)
0 users

See Also:
Issue Type: TASK
:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Krauskopf 2006-02-08 17:32:03 UTC
and refactor other code accordingly. Do not forgot about Libraries Node.
Comment 1 Jesse Glick 2006-02-08 18:05:49 UTC
BTW I recently added hashCode for some classes with equals, acc. to FindBugs;
hope it was correct.
Comment 2 Martin Krauskopf 2006-02-08 20:49:30 UTC
Surely not :). I just think I misunderstand some concepts in the beginning so I
presumably caused a little mess on some places which use ModuleDependencies
(mainly in the GUI).
Comment 3 Martin Krauskopf 2006-02-09 12:26:18 UTC
test/unit/ui/customizer/ModuleDependencyTest.java; 1.3 -> 1.4;
ProjectXMLManager.java; 1.44 -> 1.45;
ui/LibrariesNode.java; 1.7 -> 1.8;
ui/customizer/ModuleDependency.java; 1.19 -> 1.20;
ui/customizer/SingleModuleProperties.java; 1.53 -> 1.54;
Comment 4 Martin Krauskopf 2006-02-09 12:30:13 UTC
Forgot mark as fixed.
Comment 5 Martin Krauskopf 2006-02-09 14:47:56 UTC
Backported into 5.0u1

project/ProjectXMLManager.java; 1.44 -> 1.44.2.1;
project/ui/customizer/ModuleDependency.java; 1.19 -> 1.19.2.1;
project/ui/customizer/SingleModuleProperties.java; 1.53 -> 1.53.2.1;
project/test/unit/ui/customizer/ModuleDependencyTest.java; 1.3 -> 1.3.6.1;
project/ui/LibrariesNode.java; 1.7 -> 1.7.2.1;

Note this was actually bug (and/or allows to fix another one)
Comment 6 Jesse Glick 2006-02-09 21:11:25 UTC
Note: as part of issue #72463 I will discard most of this, so that MD instances
are compared and sorted only by code name base. This is not mathematically
accurate but I think it doesn't matter - AFAIK there will never be two MD's with
the same code name base in one set at once. And supporting lazy evaluation of
the specification version while retaining mathematical correctness is just not
possible. Review will be requested.


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2012, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo