This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 72124 - Add Module Dialog does not show suite components in the same suite
Summary: Add Module Dialog does not show suite components in the same suite
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2006-02-01 14:45 UTC by Martin Krauskopf
Modified: 2006-02-13 13:01 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Krauskopf 2006-02-01 14:45:02 UTC 
This is regresion caused by:

http://apisupport.netbeans.org/source/browse/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java?r1=1.48&r2=1.49

Since this suite component's cluster is not contained in the enabledClusters,
all suite components in the same suite will be excluded. So the user is unable
to add dependency on them.

There are more ways to fix this directly in the
SingleModuleProperties.getUniverseDependencies().

But not sure if it should not be fixed on the SuiteProject's evaluator level.
Comment 1 Jesse Glick 2006-02-01 15:44:16 UTC 
The evaluator is fine, getUniverseDependencies was wrong.

Checking in
test/unit/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModulePropertiesTest.java;
/shared/data/ccvs/repository/apisupport/project/test/unit/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModulePropertiesTest.java,v
 <--  SingleModulePropertiesTest.java
new revision: 1.34; previous revision: 1.33
done
Checking in
src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java;
/shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java,v
 <--  SingleModuleProperties.java
new revision: 1.52; previous revision: 1.51
done
Comment 2 Tomas Danek 2006-02-13 13:01:01 UTC 
If suite component does not contain public packages, it is shown only if Show
non API modules checkbox is selected. Verifed in 50u1