This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 71283 - No need to implement FileChangeListener in WsCompileConfigDataObject
Summary: No need to implement FileChangeListener in WsCompileConfigDataObject
Status: RESOLVED FIXED
Alias: None
Product: webservices
Classification: Unclassified
Component: Code (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Milan Kuchtiak
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2006-01-11 21:26 UTC by _ rkubacki
Modified: 2009-02-19 23:28 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2006-01-11 21:26:34 UTC
While looking into sources of websvc I see that WsCompileConfigDataObject
implements FileChangeListener although I do not see the need for it. To make it
more strange there is also FileObserver implementing the same interface that is
instantiated but not attached to anything. This is just wasting of memory. 

BTW: If you really want a class like FileObserver consider subclassing
FileChangeAdapter - you will only override methods that are interesting for you.
Comment 1 _ pcw 2006-01-11 23:19:26 UTC
FileChangeListener as implemented by WsCompileConfigDataObject (which is just a
skeleton) is proof-of-concept code related to JWSDP 1.4 implementation of
handlers in the configuration file, but this changed in JWSDP 1.5 and this code
is probably obsolete.

The FileObserver implementation is for proper triggering of reparsing the XML
due to external changes to the configuration file.  The listener is attached in
the constructor to the FileObject passed in.  It is entirely possible there are
bugs or unnecessary steps going on here.  I'm sure a code review by someone
versed in the art of DDAPI implemenations and/or File event structures would be
more than welcome.
Comment 2 _ rkubacki 2006-01-12 13:27:12 UTC
Sorry, I missed that FileObserver is attached in constructor. So removing
'implements FCL' and methods  from outer class should be enough.
Comment 3 Milan Kuchtiak 2008-11-21 14:51:40 UTC
Fixed:
http://hg.netbeans.org/main?cmd=changeset;node=33de8d877786
Comment 4 Quality Engineering 2008-11-23 17:03:54 UTC
Integrated into 'main-golden', will be available in build *200811231401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/33de8d877786
User: mkuchtiak@netbeans.org
Log: #71283: removing implements clause(FCL)