This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 71205 - JNLP build - branding variants incorrectly marked as locale variants
Summary: JNLP build - branding variants incorrectly marked as locale variants
Status: RESOLVED WONTFIX
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 5.x
Hardware: All All
: P4 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks: 71129
  Show dependency tree
 
Reported: 2006-01-09 19:00 UTC by Jesse Glick
Modified: 2006-01-11 23:44 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2006-01-09 19:00:19 UTC
See

http://nbbuild.netbeans.org/servlets/ReadMsg?list=cvs&msgNo=3382

Probably low priority for now since it seems that actual core_nb.jar etc. are in
the nb5.0 cluster and not included in the platform-based JNLP build anyway, nor
can you even include them if you wanted to (if you check NB IDE Branding in the
nb5.0 cluster, the build fails).
Comment 1 Jaroslav Tulach 2006-01-10 10:34:00 UTC
Well, we do not want people to use nb5.0 cluster - the warning could be nicer 
than just a failed build, but they should not do it. I suggest wontfix. 
Comment 2 Jesse Glick 2006-01-10 16:47:55 UTC
It is only accidental that the same module that includes core_nb.jar also has
some other files that cause its build to break. This condition might not be true
in a derivative IDE (or in NB in the future). I am OK with WONTFIX though I
might suggest a partial fix such as checking whether a presumed locale infix
matches either _xx for xx in Locale.getISOLanguages or _xx_yy for xx in
Locale.getISOLanguages and yy in Locale.getISOCountries; if not, at least print
a build warning that the result might be incorrect. Should be simple enough;
reassign to me if you prefer.
Comment 3 Jaroslav Tulach 2006-01-11 17:08:32 UTC
The warning I get when including nb5.0 cluster is:  
  
/doma/jarda/tmp/nb/netbeans/harness/jnlp.xml:95: Cannot build JNLP for  
module /doma/jarda/tmp/nb/netbeans/nb5.0/modules/org-netbeans-modules-ide-branding.jar  
as these files are in module's NBM, but are not referenced from any path:  
[modules/locale/org-netbeans-core_nb_ja.jar,  
modules/locale/org-netbeans-core-windows_nb_zh_CN.jar,  
modules/locale/org-netbeans-core_nb.jar, shortcuts.pdf,  
core/locale/core_nb.jar, netbeans.icns, nbos2icons.zip,  
modules/locale/org-netbeans-core_nb_zh_CN.jar, netbeans.png,  
modules/locale/org-netbeans-core-windows_nb_ja.jar,  
modules/ext/locale/updater_nb.jar, modules/ext/locale/updater_nb_zh_CN.jar,  
modules/locale/org-netbeans-core-windows_nb.jar, core/locale/core_nb_ja.jar,  
core/locale/core_nb_zh_CN.jar, modules/ext/locale/updater_nb_ja.jar]  
BUILD FAILED (total time: 8 seconds)  
  
Well, that is ok. This module has not been made JNLP ready and there is  
nothing to do about that. A lot of files is just laying around without being  
referenced from the main JAR file.   
  
According to   
http://installer.netbeans.org/docs/jnlpInstaller.html  
this is module of type #4. Those are not supported and buildable from binary  
distribution they have to override their own "jnlp" target and package  
themselves manually.  
 
Imho assuming that everything that contains file with _ is a branding can do 
more bad than good. I am not sure what you would like to change in the 
MakeJNLP to make this module buildable? 
Comment 4 Jesse Glick 2006-01-11 23:39:34 UTC
I guess ide/branding could not be built automatically. Only an issue if
core_nb.jar etc. were included in the core module.