This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 71052 - Add Module Dep - exclude non-API modules by default
Summary: Add Module Dep - exclude non-API modules by default
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2006-01-05 19:28 UTC by Jesse Glick
Modified: 2006-01-30 09:48 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2006-01-05 19:28:12 UTC 
Currently API-providing modules are supposed to be boldfaced in the Add Module
Dep dialog, but this isn't obvious and usually you don't want to see them at all.

Suggest having a checkbox (off by default)

[ ] Show Non-API Modules

If checked, behave as now, minus boldfacing. If unchecked, exclude any module
for which the current module could not access any packages without an impl dep.
(I.e. include only modules with some public packages, or friend packages where
this module is a friend.)
Comment 1 Martin Krauskopf 2006-01-26 23:26:06 UTC 
Working on this.
Comment 2 Martin Krauskopf 2006-01-27 10:12:37 UTC 
Also working (needed presuambly also for another parts) on the support for
friends through the infrastructure.
Comment 3 Martin Krauskopf 2006-01-27 13:15:36 UTC 
Support for friends in ModuleEntries
 ManifestManager.java; 1.26 -> 1.27;
 test/unit/ManifestManagerTest.java; 1.3 -> 1.4;
 universe/AbstractEntry.java; 1.5 -> 1.6;
 universe/BinaryEntry.java; 1.5 -> 1.6;
 universe/ExternalEntry.java; 1.4 -> 1.5;
 universe/ModuleEntry.java; 1.5 -> 1.6;
 universe/ModuleList.java; 1.24 -> 1.25;
 universe/NetBeansOrgEntry.java; 1.5 -> 1.6;

#71052: Add Module Dep - exclude non-API modules by default
 test/unit/ui/customizer/SingleModulePropertiesTest.java; 1.32 -> 1.33;
 ui/customizer/SingleModuleProperties.java; 1.49 -> 1.50;
 ui/customizer/AddModulePanel.form; 1.9 -> 1.10;
 ui/customizer/AddModulePanel.java; 1.35 -> 1.36;
Comment 4 Jesse Glick 2006-01-27 18:56:43 UTC 
Can you update the UI spec too please?
Comment 5 Jesse Glick 2006-01-29 23:18:36 UTC 
You forgot the bundle key; was throwing MRE when used:

Checking in Bundle.properties;
/shared/data/ccvs/repository/apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.71; previous revision: 1.70
done
Comment 6 Martin Krauskopf 2006-01-30 09:48:31 UTC 
> Can you update the UI spec too please?

Sure. Forgot about it, sorry.

Checking in 50u1-ui.html;
new revision: 1.9; previous revision: 1.8

> You forgot the bundle key; was throwing MRE when used:

Ups. Thanks.