This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 70759 - CNFE from navigator module when using -J-Dnetbeans.preresolve.classes=true
Summary: CNFE from navigator module when using -J-Dnetbeans.preresolve.classes=true
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Navigator (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: SIMPLEFIX
Depends on:
Blocks:
 
Reported: 2005-12-23 02:06 UTC by Jesse Glick
Modified: 2008-12-22 21:48 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Proposed patch for release50 (10.60 KB, patch)
2005-12-23 15:09 UTC, Jesse Glick 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2005-12-23 02:06:07 UTC 
If you use this module class loader debugging flag, you get spurious warnings:

java.lang.ClassNotFoundException: Will not load classes from default package
(BasicNavPanelImpl)
	at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:154)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
	at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:242)
[catch] at
org.netbeans.core.startup.NbInstaller.preresolveClasses(NbInstaller.java:1428)

Reason is that

core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl.java

actually gets compiled into the module JAR - into the default package. This is
accidental; it is just supposed to be used for documentation.
Comment 1 Jesse Glick 2005-12-23 02:09:14 UTC 
Trivial fix. I think it should be put in 5.0 to make the flag useful in that branch.

Checking in core/navigator/arch.xml;
/cvs/core/navigator/arch.xml,v  <--  arch.xml
new revision: 1.6; previous revision: 1.5
done
Removing
core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl.java;
/cvs/core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl.java,v
 <--  BasicNavPanelImpl.java
new revision: delete; previous revision: 1.3
done
RCS file:
/cvs/core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl_java,v
done
Checking in
core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl_java;
/cvs/core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl_java,v
 <--  BasicNavPanelImpl_java
initial revision: 1.1
done
Comment 2 Jesse Glick 2005-12-23 02:11:00 UTC 
Also to make this kind of mistake (*.class in default package) simpler to
diagnose, so you can see which module is responsible:

Checking in core/startup/src/org/netbeans/core/startup/NbInstaller.java;
/cvs/core/startup/src/org/netbeans/core/startup/NbInstaller.java,v  <-- 
NbInstaller.java
new revision: 1.22; previous revision: 1.21
done

Could also be merged to release50 but less critical.
Comment 3 Jesse Glick 2005-12-23 02:11:29 UTC 
Dafe could you review sometime?
Comment 4 David Simonek 2005-12-23 12:24:39 UTC 
Yes, reviewed, thank you for catching this, I didn't know that BasicNavPanelImpl
gets compiled.
Comment 5 Jesse Glick 2005-12-23 15:09:24 UTC 
Created attachment 28053 [details]
Proposed patch for release50
Comment 6 Jesse Glick 2006-01-02 19:50:30 UTC 
Checking in core/navigator/arch.xml;
/cvs/core/navigator/arch.xml,v  <--  arch.xml
new revision: 1.5.2.1; previous revision: 1.5
done
Removing
core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl.java;
/cvs/core/navigator/src/org/netbeans/spi/navigator/doc-files/Attic/BasicNavPanelImpl.java,v
 <--  BasicNavPanelImpl.java
new revision: delete; previous revision: 1.3.22
done
Checking in
core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl_java;
/cvs/core/navigator/src/org/netbeans/spi/navigator/doc-files/BasicNavPanelImpl_java,v
 <--  BasicNavPanelImpl_java
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in core/startup/src/org/netbeans/core/startup/NbInstaller.java;
/cvs/core/startup/src/org/netbeans/core/startup/NbInstaller.java,v  <-- 
NbInstaller.java
new revision: 1.21.2.1; previous revision: 1.21
done
Comment 7 Marian Mirilovic 2006-01-03 08:52:51 UTC 
verified