This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 70695 - [50cat] NPE thrown when closing all documents
Summary: [50cat] NPE thrown when closing all documents
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: SQL Editor (show other bugs)
Version: 5.x
Hardware: PC All
: P2 blocker (vote)
Assignee: Andrei Badea
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-21 13:38 UTC by misterm
Modified: 2006-01-17 12:33 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description misterm 2005-12-21 13:38:09 UTC
[ BUILD # : 20051218 ]
[ JDK VERSION : 1.4.2_xx ]

The following exception was thrown when closing all documents with a SQL editor tab open:

java.lang.NullPointerException
	at org.netbeans.modules.db.sql.loader.SQLEditorSupport$SQLCloneableEditor.createResultComponent(SQLEditorSupport.java:449)
	at org.netbeans.modules.db.sql.loader.SQLEditorSupport$SQLCloneableEditor.getResultComponent(SQLEditorSupport.java:442)
	at org.netbeans.modules.db.sql.loader.SQLEditorSupport$4.run(SQLEditorSupport.java:328)
	at org.openide.util.Mutex.doEvent(Mutex.java:1152)
	at org.openide.util.Mutex.writeAccess(Mutex.java:369)
	at org.netbeans.modules.db.sql.loader.SQLEditorSupport.setResultModelToEditors(SQLEditorSupport.java:323)
	at org.netbeans.modules.db.sql.loader.SQLEditorSupport.closeExecutionResult(SQLEditorSupport.java:343)
	at org.netbeans.modules.db.sql.loader.SQLEditorSupport.notifyClosed(SQLEditorSupport.java:187)
	at org.openide.text.CloneableEditor.closeLast(CloneableEditor.java:331)
	at org.openide.windows.CloneableTopComponent$Ref.unregister(CloneableTopComponent.java:330)
	at org.openide.windows.CloneableTopComponent$Ref.access$300(CloneableTopComponent.java:222)
	at org.openide.windows.CloneableTopComponent.canClose(CloneableTopComponent.java:174)
	at org.openide.text.CloneableEditor.canClose(CloneableEditor.java:133)
	at org.openide.windows.TopComponent.close(TopComponent.java:345)
	at org.openide.windows.TopComponent.close(TopComponent.java:333)
	at org.netbeans.core.windows.actions.ActionUtils.closeAllDocuments(ActionUtils.java:212)
	at org.netbeans.core.windows.actions.CloseAllDocumentsAction.actionPerformed(CloseAllDocumentsAction.java:50)
	at org.openide.windows.TopComponent.processKeyBinding(TopComponent.java:848)
	at javax.swing.JComponent.processKeyBindings(JComponent.java:2484)
	at javax.swing.JComponent.processKeyEvent(JComponent.java:2401)
	at java.awt.Component.processEvent(Component.java:4909)
	at java.awt.Container.processEvent(Container.java:1569)
	at java.awt.Component.dispatchEventImpl(Component.java:3615)
	at java.awt.Container.dispatchEventImpl(Container.java:1627)
	at java.awt.Component.dispatchEvent(Component.java:3477)
	at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1713)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:627)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:831)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:741)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:592)
	at java.awt.Component.dispatchEventImpl(Component.java:3506)
	at java.awt.Container.dispatchEventImpl(Container.java:1627)
	at java.awt.Window.dispatchEventImpl(Window.java:1606)
	at java.awt.Component.dispatchEvent(Component.java:3477)
[catch] at java.awt.EventQueue.dispatchEvent(EventQueue.java:456)
	at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:151)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:145)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:137)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:100)
Comment 1 Andrei Badea 2005-12-21 15:52:36 UTC
I will be very grateful if you can find reproducible steps for this -- would
make it a P2. I've seen it once, but I was unable to reproduce it. 
Comment 2 Andrei Badea 2005-12-22 09:37:39 UTC
Steps to reproduce:

1. Start with a clean userdir, add a new database connection.
2. Invoke the Execute Command action on the connection node at least three times.
3. Restart NetBeans.
4. Invoke the Close All Documents action.

ERROR: the NPE attached in the original document is thrown.

Upgrading to P2.
Comment 3 Andrei Badea 2005-12-22 10:34:57 UTC
Fixed in the trunk.

Checking in src/org/netbeans/modules/db/sql/loader/SQLEditorSupport.java;
/cvs/db/core/src/org/netbeans/modules/db/sql/loader/SQLEditorSupport.java,v  <--
 SQLEditorSupport.java
new revision: 1.13; previous revision: 1.12
done
Comment 4 Jan Horvath 2005-12-22 12:08:45 UTC
verifyed on custom build
Comment 5 Jaroslav Tulach 2005-12-22 12:44:04 UTC
The patch seems to add check for certain border situations and handles them in 
correct way. Other functionality is likely not affected. I believe that this 
can only improve the situation and shall not cause any regressions. 
Comment 7 Andrei Badea 2005-12-22 21:18:59 UTC
Fixed in the release50 branch.

Checking in src/org/netbeans/modules/db/sql/loader/SQLEditorSupport.java;
/cvs/db/core/src/org/netbeans/modules/db/sql/loader/SQLEditorSupport.java,v  <--
 SQLEditorSupport.java
new revision: 1.12.2.1; previous revision: 1.12
done
Comment 8 Lukasz Grela 2006-01-17 12:33:19 UTC
v.