This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 69169 - [50cat] Condition field has too small height
Summary: [50cat] Condition field has too small height
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Miloslav Metelka
URL:
Keywords: REGRESSION
: 69468 69760 70022 70182 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-11-23 10:55 UTC by _ lcincura
Modified: 2007-11-05 13:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Screenshot showing the problem (30.38 KB, image/jpeg)
2005-12-07 15:18 UTC, misterm 		Details
Possible fix for testing (760 bytes, patch)
2005-12-12 15:18 UTC, Miloslav Metelka 		Details | Diff
Second attempt of patch (3.15 KB, patch)
2005-12-13 17:02 UTC, Miloslav Metelka 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ lcincura 2005-11-23 10:55:10 UTC 
NetBeans IDE 5.0 [200511221900] on jdk 1.5.0_05

Condition field in Customize Breakpoint dialog (for line breakpoints) has too
small height. Currently only few pixels, thus the condition is not visible.
This should be fixed in the release.
Comment 1 _ lcincura 2005-11-28 16:33:08 UTC 
*** Issue 69468 has been marked as a duplicate of this issue. ***
Comment 2 Roman Ondruska 2005-12-06 16:12:19 UTC 
Lubo, I am not able to reproduce this with current build. Please, reopen if it
reapears.
Comment 3 _ lcincura 2005-12-07 10:28:26 UTC 
Reproducible on daily build 200512051900 with clean userdir.
Comment 4 Roman Ondruska 2005-12-07 13:19:50 UTC 
It would be really helpful if you could search when this started. ;-)
Comment 5 Roman Ondruska 2005-12-07 15:15:31 UTC 
*** Issue 70022 has been marked as a duplicate of this issue. ***
Comment 6 misterm 2005-12-07 15:18:28 UTC 
Created attachment 27633 [details]
Screenshot showing the problem
Comment 7 _ lcincura 2005-12-08 10:36:08 UTC 
It started with build 200511161900
Comment 8 Roman Ondruska 2005-12-08 16:18:10 UTC 
Milo, please evaluate it. See also your commit

http://editor.netbeans.org/servlets/ReadMsg?list=cvs&msgNo=5404

Thanks!
Comment 9 Miloslav Metelka 2005-12-12 11:58:41 UTC 
I will attempt to fix this.
Comment 10 Miloslav Metelka 2005-12-12 15:18:08 UTC 
Created attachment 27749 [details]
Possible fix for testing
Comment 11 Martin Roskanin 2005-12-12 15:59:17 UTC 
the patch didn't help
Comment 12 Jan Pokorsky 2005-12-13 14:50:10 UTC 
*** Issue 70182 has been marked as a duplicate of this issue. ***
Comment 13 Jan Pokorsky 2005-12-13 14:54:32 UTC 
*** Issue 69760 has been marked as a duplicate of this issue. ***
Comment 14 Miloslav Metelka 2005-12-13 17:02:02 UTC 
Created attachment 27799 [details]
Second attempt of patch
Comment 15 Martin Roskanin 2005-12-13 17:09:21 UTC 
The patch works OK.
Comment 16 Miloslav Metelka 2005-12-13 17:40:51 UTC 
Fixed.

Checking in libsrc/org/netbeans/editor/BaseTextUI.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseTextUI.java,v  <--  BaseTextUI.java
new revision: 1.80; previous revision: 1.79
done
Checking in libsrc/org/netbeans/editor/EditorUI.java;
/cvs/editor/libsrc/org/netbeans/editor/EditorUI.java,v  <--  EditorUI.java
new revision: 1.84; previous revision: 1.83

IMHO this is a visible problem that would be worth making a P2 and backporting
into 5.0. Does QE agree with fixing in 5.0?
Comment 17 Roman Strobl 2005-12-13 17:45:40 UTC 
How dangerous is the fix? If you don't expect side effects, I agree with fixing
in 5.0.
Comment 19 Martin Roskanin 2005-12-14 09:15:48 UTC 
I approve the fix
Comment 20 Miloslav Metelka 2005-12-15 12:47:05 UTC 
Fixed in release50:
Checking in libsrc/org/netbeans/editor/BaseTextUI.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseTextUI.java,v  <--  BaseTextUI.java
new revision: 1.79.4.1; previous revision: 1.79
done
Checking in libsrc/org/netbeans/editor/EditorUI.java;
/cvs/editor/libsrc/org/netbeans/editor/EditorUI.java,v  <--  EditorUI.java
new revision: 1.83.2.1; previous revision: 1.83
Comment 21 _ lcincura 2005-12-20 12:46:48 UTC 
Verified in 200512181900