This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 68329 - [50cat] CC of XML files doesn't work
Summary: [50cat] CC of XML files doesn't work
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Dusan Balek
URL:
Keywords:
Depends on:
Blocks: 68331
  Show dependency tree
 
Reported: 2005-11-09 06:57 UTC by wulgar
Modified: 2007-11-05 13:44 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description wulgar 2005-11-09 06:57:35 UTC
[ BUILD # : 200511081900 ]
[ JDK VERSION : 1.5.0_05 ]

When you start typing "<" it is shown, but later Ctrl-space doesnt work
Comment 1 Jesse Glick 2005-11-09 21:50:55 UTC
Nothing has changed in the ant/grammar module recently, and its unit tests still
pass. I too have noticed (on Linux) that sometimes the code completion popup
simply doesn't appear, for no apparent reason. I am guessing that the problem
lies in the xml/text-edit module, but I don't know of any way to turn on logging
for this module to see what it is passing to ant/grammar (if anything) and what
it is getting back.
Comment 2 Marek Fukala 2005-11-14 09:56:35 UTC
The issue is 100% reproducible. The CC for XML files doesn't work when you press
Ctrl+space. Using completion autopopup makes it working. It seems to me that the
problem is a regression in editor module (The XML CC is not rewritten to use the
new editor completion API). I have already asked Dusan Balek to look at it.
Comment 3 Marek Fukala 2005-11-14 11:32:27 UTC
This really seems not to be a XML editor issue => reassigning to editor.
Comment 4 Martin Balin 2005-11-14 12:42:41 UTC
Has to be fixed for Beta 2 as functionality is completely missing.
Comment 5 Miloslav Metelka 2005-11-14 13:28:14 UTC
Unfortunately this is regression caused by fix of issue 67922.
We will attempt to fix by invoking the legacy completion functionality from the
new completion implementation in case there are no new providers (but we will
not re-add the old completion actions). This way we should be able to retain the
issue above fixed and fix this one as well.
Comment 6 Dusan Balek 2005-11-14 14:42:17 UTC
Fixed in [maintrunk]. A terrible hack added to allow for calling the XML
completion via the legacy completion infrastrucure.

Checking in src/org/netbeans/modules/editor/completion/CompletionImpl.java;
/cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java,v
 <--  CompletionImpl.java
new revision: 1.32; previous revision: 1.31
done

Comment 7 Dusan Balek 2005-11-14 16:15:04 UTC
Fix in [maintrunk] cont.

Checking in src/org/netbeans/modules/editor/completion/CompletionImpl.java;
/cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java,v
 <--  CompletionImpl.java
new revision: 1.33; previous revision: 1.32
done
Checking in org/netbeans/editor/ext/ListCompletionView.java;
/cvs/editor/libsrc/org/netbeans/editor/ext/ListCompletionView.java,v  <-- 
ListCompletionView.java
new revision: 1.15; previous revision: 1.14
done
Comment 8 Roman Strobl 2005-11-14 16:30:43 UTC
After second commit it works without exceptions, please proceed with commit to
release50_beta2 branch. I will verify it on beta build tomorrow.
Comment 9 Miloslav Metelka 2005-11-14 16:50:57 UTC
Fixed in release50_beta2:
Checking in
completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java;
/cvs/editor/completion/src/org/netbeans/modules/editor/completion/CompletionImpl.java,v
 <--  CompletionImpl.java
new revision: 1.27.2.2; previous revision: 1.27.2.1
done
Checking in libsrc/org/netbeans/editor/ext/ListCompletionView.java;
/cvs/editor/libsrc/org/netbeans/editor/ext/ListCompletionView.java,v  <-- 
ListCompletionView.java
new revision: 1.14.2.1; previous revision: 1.14
Comment 10 Martin Schovanek 2005-11-15 11:24:26 UTC
Verified in release50_beta2 and trunk.