This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 68101 - Move CVS menu back to editor tabs
Summary: Move CVS menu back to editor tabs
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks: 68331
  Show dependency tree
 
Reported: 2005-11-04 14:07 UTC by David Simonek
Modified: 2007-01-04 17:14 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Simonek 2005-11-04 14:07:41 UTC
This is followup issue from 66214 and 66933.

Currently, after removal of cvs actions from document tabs, cvs actions related
to the active document opened in editor are available only from main menu. While
main menu is fine for greenhorns, for everyday use it is too "far away" and
there is weaker asociation between main menu nad active document.

I suggest to add CVS actions to editor popup menu, preferrably at the same
position where it was with older cvs support. Please see 66933, mmetelka's
comment for possible implementation.

I'm sorry for higher priority, but I found this usability problem to be
important for everyday CVS use.
Comment 1 Marian Mirilovic 2005-11-04 14:22:17 UTC
Because, I am getting lost in issues regarding this feature, I would like to
collect issue numbers ;)

So, as decided by jrojcek (HIE) to don't remove CVS action from the editor tab's
popup menu - issue 66933, here is the comment:

========================
------- Additional comments from jrojcek Fri Oct 21 08:19:24 +0000 2005 -------
Okay it's too late for this change. We don't have time to wait for user feedback
and even integrating this menu with editor contextual menu is not trivial as
each editor type (Java, JSP, plain text) has different contextual menu. Also
it's not yet clear what to do in case of visual editors.

Dafe, please don't implement it now.

========================

The fix we would like to revert - issue 66214
Comment 2 Roman Strobl 2005-11-04 14:29:10 UTC
The final decision is to remove the menu from the tab because it really doesn't
belong there (it's only for window-related actions). It would be hard to remove
it in next release because users could get used to it. Users need fast access to
the CVS actions, thus they will be added to editor. It was decided on a
usability meeting two weeks ago, several days after this comment.
Comment 3 _ pkuzel 2005-11-04 14:29:52 UTC
Latest conclusion is to remove CVS submenu from editor tabs.

  - greenhorns can use main menu using mouse
  - experts can use main menu using Alt+C & mnemonic

Comment 4 Marian Mirilovic 2005-11-04 14:58:57 UTC
Very very interesting, the left hand have no idea about the existance of the
right one. 
The usability team, I would kindly ask you to inform the rest of the world about
your decisions in the future. At least somebody from HIE/xDesign/UI team should
know about your decisions.

The current solution: I partially agree. I don't miss the CVS action on the tab
contextual menu. But I think it could be better to have CVS actions accessible
through the editor popup menu.
Comment 5 David Simonek 2005-11-04 16:02:55 UTC
pkuzel, who made this "final conclusion"? I'm not aware of that.
I'm aware that latest conclusion on usability team was to include actions in the
editor tab. Is it really so much hard to implement? Every nb engineer I asked
(phrebejk, anebuzelsky, rkubacki, pnejedly) told me the same opinion - they
would like to see cvs in editor popup menu and found it usability gain.

I don't want to heat the discussion more and I agree that I didn't express
usability team conclusion well, so I won't reopen myself...but I have strong
feeling that our cvs support will be crippled a bit if things stay in current
state and we will regret it later. I already saw one user's report annoyed by
non existence of cvs submenu in editor area popup menu.

pkuzels arguments doesn't sound compelling to me, as they don't cover majority
of users. There is a large group (I'd say over 50%) of everyday users which use
mouse, "click and go" approach.
Comment 6 _ pkuzel 2005-11-04 16:23:59 UTC
I tend to agree regarding editor pane popup. Please file RFE/bug for editor
module to address it at right place.

Here you lob for the action on (possibly inactive) document tabs. The final
decision comes from the UI spec, it was updated and communicated by Jano. Sigh.
Comment 7 Jiri Skrivanek 2005-11-08 08:21:03 UTC
I really don't know why this issue is closed as wontfix. Everybody agrees that
CVS submenu should be in editor pane popup and the same is expressed in the
summary of the issue.
Are there any obstacles or UI decisions which prevent you from fixing this
issue? As I understand from issue 66933 it should be enough to add CVS actions
to Editors/Popup folder in layer.
Comment 8 jrojcek 2005-11-08 13:45:04 UTC
I think I caused this confusion. We agreed on CVS i-team to remove CVS actions from editor tab. Then I 
filed the bug to remove it from tabs. Then we had a discussion about possible impacts in the usability 
team and decided to not do it for 5.0, but I forgot to inform CVS team. So they removed the action from 
editor tabs.

Okay that was the whole story. And now I will prepare a mini spec how to integrate CVS actions into editor 
tab.

Ccing Talley to inform him about this late UI change.
Comment 9 Maros Sandor 2005-11-09 16:12:25 UTC
For future releases, the CVS menu should be present in Editor popup menu. It is
too late to fix it now so in the meantime, we will put CVS menu back into Editor
tabs.
Comment 10 Marian Mirilovic 2005-11-09 16:19:34 UTC
Maros, 
I don't think this is an enhancement. 

From discucion above I've got feeling, that HIE (Jano) will prepare mini-UI spec
and we do something with current state, because now CVS actions are accessible
only from main menu, and IMHO nobody agreed with this, if I understand it correctly.

Comment 11 Maros Sandor 2005-11-09 16:27:50 UTC
"... we will put CVS menu back into Editor tabs." I already did that.
Comment 12 jrojcek 2005-11-09 17:08:21 UTC
Yes, we decided to not do it for 5.0 and move back CVS actions into the editor tabs. This is the final 
decision. It appears to be quite complicated at this point to add CVS actions into all editors, form editor 
and other visual editors like ejb-jar.xml etc. Thus we won't do it for 5.0.

As CVS actions are back in editor tabs now, I think marking this as an enhancement is approriate.
Comment 13 Marian Mirilovic 2005-11-09 17:24:00 UTC
Well, I have to agree. I've tried to run NB4.1 and CVS actions are also
available only from tab popup menu, so I hope our users are getting useed to
this place for such actions.
Thanks for your patience.
Comment 14 Maros Sandor 2005-11-09 18:26:10 UTC
Great, I am more than glad that we finally came to a conclusion.
Comment 15 Peter Pis 2005-11-10 10:37:33 UTC
This is showstopper, fix this also to release50_beta2 branch, please.
Comment 16 Maros Sandor 2005-11-10 10:55:47 UTC
Fixed in trunk.
Comment 17 Peter Pis 2005-11-10 11:04:57 UTC
Verified in NB 200511091900.
Comment 18 Maros Sandor 2005-11-10 13:10:48 UTC
Integrated into release50_beta2 branch.

/shared/data/ccvs/repository/openide/text/src/org/openide/text/CloneableEditor.java,v
 <--  CloneableEditor.java
new revision: 1.9.2.1; previous revision: 1.9